From: Sean Nyekjaer <sean@geanix.com>
To: Dan Murphy <dmurphy@ti.com>, mkl@pengutronix.de
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio
Date: Fri, 6 Dec 2019 14:49:52 +0100 [thread overview]
Message-ID: <bd4586d0-4ea7-e247-d72d-a759c99860b0@geanix.com> (raw)
In-Reply-To: <d34673db-cc43-6e1d-6f4a-07b25c2c8f7b@geanix.com>
On 05/12/2019 08.36, Sean Nyekjaer wrote:
>
>
> On 04/12/2019 18.51, Dan Murphy wrote:
>> The wake-up of the device can be configured as an optional
>> feature of the device. Move the wake-up gpio from a requried
>> property to an optional property.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> CC: Rob Herring <robh@kernel.org>
> Reviewed-by: Sean Nyekjaer <sean@geanix.com>
Tested-by: Sean Nyekjaer <sean@geanix.com>
>> ---
>> Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> index 27e1b4cebfbd..7cf5ef7acba4 100644
>> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> @@ -10,7 +10,6 @@ Required properties:
>> - #size-cells: 0
>> - spi-max-frequency: Maximum frequency of the SPI bus the chip can
>> operate at should be less than or equal to 18 MHz.
>> - - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>> - interrupt-parent: the phandle to the interrupt controller
>> which provides
>> the interrupt.
>> - interrupts: interrupt specification for data-ready.
>> @@ -23,6 +22,7 @@ Optional properties:
>> reset.
>> - device-state-gpios: Input GPIO that indicates if the device is in
>> a sleep state or if the device is active.
>> + - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>> Example:
>> tcan4x5x: tcan4x5x@0 {
>>
next prev parent reply other threads:[~2019-12-06 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 17:51 [PATCH 1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio Dan Murphy
2019-12-04 17:51 ` [PATCH 2/2] net: m_can: Make wake-up gpio an optional Dan Murphy
2019-12-05 7:39 ` Sean Nyekjaer
2019-12-05 13:26 ` Dan Murphy
2019-12-05 14:39 ` Marc Kleine-Budde
2019-12-05 15:01 ` Dan Murphy
2019-12-05 15:35 ` Marc Kleine-Budde
2019-12-09 21:01 ` Dan Murphy
2019-12-09 21:06 ` Marc Kleine-Budde
2019-12-09 21:07 ` Dan Murphy
2019-12-09 21:10 ` Marc Kleine-Budde
2019-12-05 7:36 ` [PATCH 1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio Sean Nyekjaer
2019-12-06 13:49 ` Sean Nyekjaer [this message]
2019-12-06 13:49 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4586d0-4ea7-e247-d72d-a759c99860b0@geanix.com \
--to=sean@geanix.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).