From: Lucas Stach <l.stach@pengutronix.de>
To: Marek Vasut <marex@denx.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, "Guido Günther" <agx@sigxcpu.org>,
"Stefan Agner" <stefan@agner.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML
Date: Wed, 07 Oct 2020 10:43:25 +0200 [thread overview]
Message-ID: <bef04042ebd7dc1c744b51ab2b1c614a2f04084f.camel@pengutronix.de> (raw)
In-Reply-To: <daabffc8-24e9-4963-58a9-6c62724e7a11@denx.de>
On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote:
> On 10/7/20 3:24 AM, Laurent Pinchart wrote:
> [...]
> > +properties:
> > + compatible:
> > + enum:
> > + - fsl,imx23-lcdif
> > + - fsl,imx28-lcdif
> > + - fsl,imx6sx-lcdif
> > + - fsl,imx8mq-lcdif
>
> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c,
> so the DT must specify compatible = "fsl,imx8mq-lcdif",
> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4).
>
> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or
> dropped from the YAML file or neither ?
Neither. As far as we know the block is compatible, so the DT should
claim that it's compatible to "fsl,imx28-lcdif". However we don't know
if there are any surprises, so we add the SoC specific compatible to be
able to change the driver matching later without changing the DT if the
need arises. For the DT validation to pass the SoC specific compatible
needs to be documented, even if it currently unused by the driver.
Regards,
Lucas
next prev parent reply other threads:[~2020-10-07 8:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 1:24 [PATCH v2 0/7] drm: mxsfb: Allow overriding bus width Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Laurent Pinchart
2020-10-07 8:32 ` Marek Vasut
2020-10-07 8:43 ` Lucas Stach [this message]
2020-10-07 8:55 ` Marek Vasut
2020-10-07 13:33 ` Laurent Pinchart
2020-10-07 14:20 ` Marek Vasut
2020-10-07 16:00 ` Rob Herring
2020-10-07 16:02 ` Rob Herring
2020-10-09 23:52 ` Laurent Pinchart
2021-01-15 7:59 ` Martin Kepplinger
2021-01-15 22:25 ` Laurent Pinchart
2021-01-16 6:41 ` Martin Kepplinger
2020-10-07 1:24 ` [PATCH v2 2/7] dt-bindings: display: mxsfb: Add and fix compatible strings Laurent Pinchart
2020-10-07 8:35 ` Marek Vasut
2020-10-07 16:01 ` Rob Herring
2020-10-07 1:24 ` [PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property Laurent Pinchart
2020-10-07 8:40 ` Marek Vasut
2020-10-09 23:58 ` Laurent Pinchart
2020-10-10 8:47 ` Marek Vasut
2020-10-13 2:06 ` Laurent Pinchart
2020-10-13 11:03 ` Marek Vasut
2020-10-07 16:03 ` Rob Herring
2020-10-07 1:24 ` [PATCH v2 4/7] ARM: dts: imx: Fix LCDIF compatible strings Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 5/7] arm64: dts: imx8mq: " Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 6/7] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock Laurent Pinchart
2020-10-07 1:24 ` [PATCH v2 7/7] drm: mxsfb: Add support for the bus-width DT property Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bef04042ebd7dc1c744b51ab2b1c614a2f04084f.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).