From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D6BC433F5 for ; Wed, 1 Dec 2021 04:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbhLAFCf (ORCPT ); Wed, 1 Dec 2021 00:02:35 -0500 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:49685 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbhLAFCf (ORCPT ); Wed, 1 Dec 2021 00:02:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1638334755; x=1669870755; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=zi3Ni4efeR2heYySqn8vxzRN8Cn8WQlhVOJ6OgVH5Jk=; b=h9ZEit3CQiZKxWFjQlaF7NOLHrXTGNQJh3XXkj68ZQlg07c+9MX6TbV7 YaKu/Jpkrb72dDutSjPlyZg5gIXek7+UOhua4KDXTpjhkHjG7Ove+IL3Z 3NtEFDUN++L4GOJWe4nt4yz3I/MtO5E+AdyfYL2dkQLIzAOllp/rDW3VK I=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 30 Nov 2021 20:59:15 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 20:59:14 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Tue, 30 Nov 2021 20:59:14 -0800 Received: from [10.216.2.11] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Tue, 30 Nov 2021 20:59:10 -0800 Subject: Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi To: Matthias Kaehlcke CC: Rob Herring , Andy Gross , "Bjorn Andersson" , Stephen Boyd , Doug Anderson , , , , , References: <1637837815-8532-1-git-send-email-quic_c_sanm@quicinc.com> <1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com> From: Sandeep Maheswaram Message-ID: Date: Wed, 1 Dec 2021 10:29:07 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/29/2021 11:32 PM, Matthias Kaehlcke wrote: > On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote: >> Remove USB2 controller and phy nodes from common dtsi file as it is >> required only for SKU1 board. >> >> Signed-off-by: Sandeep Maheswaram > A series shouldn't break things if it is only applied partially (in order). In > this case the USB2 controller wouldn't work on the SKU1 board if only this patch > is applied. It should be squashed with patch 2 of this series ("arm64: qcom: > sc7280: Add USB2 controller and phy nodes for SKU1 board"). > > Also doing the move in a single patch instead of two separate patches for remove > and add makes it easier to review the latter part, since it's evident from the > patch itself that it's just a move. Ok. Will do in next version.