From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-watchdog@vger.kernel.org,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller
Date: Fri, 05 Jun 2020 20:44:52 +0200 [thread overview]
Message-ID: <bf587fc3f907d58609a0ea3d65cd5b37@walle.cc> (raw)
In-Reply-To: <20200605131525.GK2428291@smile.fi.intel.com>
Am 2020-06-05 15:15, schrieb Andy Shevchenko:
> On Fri, Jun 05, 2020 at 02:42:53PM +0200, Michael Walle wrote:
>> Am 2020-06-05 14:00, schrieb Andy Shevchenko:
>> > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle <michael@walle.cc> wrote:
>
>> > > + return devm_regmap_add_irq_chip_np(dev, dev_of_node(dev),
>> > > regmap,
>> >
>> > It seems regmap needs to be converted to use fwnode.
>>
>> Mhh, this _np functions was actually part of this series in the
>> beginning.
>
> Then, please, make them fwnode aware rather than OF centric.
ok
>
>> > > IRQF_ONESHOT, 0,
>> > > + irq_chip, &gpio->irq_data);
>
> ...
>
>> > > + dev_id = platform_get_device_id(pdev);
>> > > + if (dev_id)
>> > > + type = dev_id->driver_data;
>> >
>> > Oh, no. In new code we don't need this. We have facilities to provide
>> > platform data in a form of fwnode.
>>
>> Ok I'll look into that.
>>
>> But I already have a question, so there are of_property_read_xx(),
>> which
>> seems to be the old functions, then there is device_property_read_xx()
>> and
>> fwnode_property_read_xx(). What is the difference between the latter
>> two?
>
> It's easy. device_*() requires struct device to be established for
> this, so,
> operates only against devices, while the fwnode_*() operates on pure
> data which
> might or might not be related to any devices. If you understand OF
> examples
> better, consider device node vs. child of such node.
Ahh thanks, got it.
>
> ...
>
>> > > + if (irq_support &&
>> >
>> > Why do you need this flag? Can't simple IRQ number be sufficient?
>>
>> I want to make sure, the is no misconfiguration. Eg. only GPIO
>> flavors which has irq_support set, have the additional interrupt
>> registers.
>
> In gpio-dwapb, for example, we simple check two things: a) hardware
> limitation
> (if IRQ is assigned to a proper port) and b) if there is any IRQ comes
> from DT,
> ACPI, etc.
I can't follow you here. irq_support is like your (a); or the
"pp->idx == 0" in your example.
>> > > + device_property_read_bool(&pdev->dev,
>> > > "interrupt-controller")) {
>> > > + irq = platform_get_irq(pdev, 0);
>> > > + if (irq < 0)
>> > > + return irq;
>> > > +
>> > > + ret = sl28cpld_gpio_irq_init(&pdev->dev, gpio, regmap,
>> > > + base, irq);
>> > > + if (ret)
>> > > + return ret;
>> > > +
>> > > + config.irq_domain =
>> > > regmap_irq_get_domain(gpio->irq_data);
>> > > + }
>
> ...
>
>> > > + { .compatible = "kontron,sl28cpld-gpio",
>> > > + .data = (void *)SL28CPLD_GPIO },
>> > > + { .compatible = "kontron,sl28cpld-gpi",
>> > > + .data = (void *)SL28CPLD_GPI },
>> > > + { .compatible = "kontron,sl28cpld-gpo",
>> > > + .data = (void *)SL28CPLD_GPO },
>> >
>> > All above can be twice less LOCs.
>>
>> They are longer than 80 chars. Or do I miss something?
>
> We have 100 :-)
oh come on, since 6 days *g*
>> > > + .name = KBUILD_MODNAME,
>> >
>> > This actually not good idea in long term. File name can change and break
>> > an ABI.
>>
>> Ahh an explanation, why this is bad. Ok makes sense, although to be
>> fair,
>> .id_table should be used for the driver name matching. I'm not sure if
>> this is used somewhere else, though.
>
> I saw in my practice chain of renames for a driver. Now, if somebody
> somewhere would like to instantiate a platform driver by its name...
> Oops, ABI breakage.
>
> And of course using platform data for such device makes less sense.
i just removed the id_table from all drivers anyways.
-michael
next prev parent reply other threads:[~2020-06-05 18:45 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 21:10 [PATCH v4 00/11] Add support for Kontron sl28cpld Michael Walle
2020-06-04 21:10 ` [PATCH v4 01/11] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-06-09 16:28 ` Rob Herring
2020-06-04 21:10 ` [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller Michael Walle
2020-06-05 6:57 ` Lee Jones
2020-06-05 9:51 ` Michael Walle
2020-06-05 10:50 ` Mark Brown
2020-06-05 20:07 ` Michael Walle
2020-06-06 11:46 ` Mark Brown
2020-06-06 12:45 ` Michael Walle
2020-06-08 8:28 ` Lee Jones
2020-06-08 10:02 ` Andy Shevchenko
2020-06-08 15:41 ` Michael Walle
2020-06-08 18:56 ` Lee Jones
2020-06-08 21:09 ` Michael Walle
2020-06-09 6:47 ` Lee Jones
2020-06-09 14:38 ` Michael Walle
2020-06-09 14:42 ` Mark Brown
2020-06-09 15:01 ` Michael Walle
2020-06-09 17:15 ` Rob Herring
2020-06-09 17:29 ` Mark Brown
2020-06-09 18:41 ` Lee Jones
2020-06-09 15:19 ` Lee Jones
2020-06-09 15:30 ` Michael Walle
2020-06-09 19:45 ` Lee Jones
2020-06-10 7:10 ` Michael Walle
2020-06-10 7:19 ` Lee Jones
2020-06-10 7:49 ` Michael Walle
2020-06-10 7:56 ` Lee Jones
2020-06-10 9:27 ` Michael Walle
2020-06-10 18:30 ` Lee Jones
2020-06-10 17:16 ` Rob Herring
2020-06-10 18:02 ` Lee Jones
2020-06-08 18:20 ` Lee Jones
2020-06-09 16:54 ` Rob Herring
2020-06-09 18:52 ` Lee Jones
2020-06-05 8:01 ` Andy Shevchenko
2020-06-05 8:02 ` Andy Shevchenko
2020-06-05 10:09 ` Michael Walle
2020-06-05 10:48 ` Andy Shevchenko
2020-06-05 11:51 ` Michael Walle
2020-06-04 21:10 ` [PATCH v4 03/11] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-06-05 1:26 ` kernel test robot
2020-06-05 8:07 ` Andy Shevchenko
2020-06-08 15:12 ` kernel test robot
2020-06-04 21:10 ` [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog Michael Walle
2020-06-05 8:14 ` Andy Shevchenko
2020-06-05 10:24 ` Michael Walle
2020-06-05 10:50 ` Andy Shevchenko
2020-06-05 13:52 ` Guenter Roeck
2020-06-05 14:09 ` Andy Shevchenko
2020-06-05 15:05 ` Guenter Roeck
2020-06-05 16:04 ` Andy Shevchenko
2020-06-05 16:34 ` Guenter Roeck
2020-06-04 21:10 ` [PATCH v4 05/11] pwm: add support for sl28cpld PWM controller Michael Walle
2020-06-05 8:15 ` Andy Shevchenko
2020-06-05 8:49 ` Lee Jones
2020-06-05 9:33 ` Andy Shevchenko
2020-06-05 11:39 ` Michael Walle
2020-06-05 18:17 ` Michael Walle
2020-06-08 7:46 ` Lee Jones
2020-06-04 21:10 ` [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-06-05 12:00 ` Andy Shevchenko
2020-06-05 12:42 ` Michael Walle
2020-06-05 13:15 ` Andy Shevchenko
2020-06-05 18:44 ` Michael Walle [this message]
2020-06-05 21:19 ` Andy Shevchenko
2020-06-04 21:10 ` [PATCH v4 07/11] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-06-05 12:06 ` Andy Shevchenko
2020-06-04 21:10 ` [PATCH v4 08/11] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-06-04 21:10 ` [PATCH v4 09/11] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-06-04 21:10 ` [PATCH v4 10/11] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-06-04 21:10 ` [PATCH v4 11/11] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-06-05 6:13 ` [PATCH v4 00/11] Add support for Kontron sl28cpld Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf587fc3f907d58609a0ea3d65cd5b37@walle.cc \
--to=michael@walle.cc \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).