From: Dinh Nguyen <dinguyen@kernel.org>
To: "Janne Grunau" <j@jannau.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Mailing List" <devicetree-spec@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"van Spriel" <arend@broadcom.com>,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
"Ley Foon Tan" <lftan@altera.com>,
"Chee Nouk Phoon" <cnphoon@altera.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 4/4] nios2: dts: Fix tse_mac "max-frame-size" property
Date: Thu, 16 Feb 2023 09:54:02 -0600 [thread overview]
Message-ID: <c4ca87f9-6603-444c-f95d-deff8c8b36b0@kernel.org> (raw)
In-Reply-To: <20230203-dt-bindings-network-class-v2-4-499686795073@jannau.net>
On 2/12/23 06:16, Janne Grunau wrote:
> The given value of 1518 seems to refer to the layer 2 ethernet frame
> size without 802.1Q tag. Actual use of the "max-frame-size" including in
> the consumer of the "altr,tse-1.0" compatible is the MTU.
>
> Fixes: 95acd4c7b69c ("nios2: Device tree support")
> Fixes: 61c610ec61bb ("nios2: Add Max10 device tree")
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> arch/nios2/boot/dts/10m50_devboard.dts | 2 +-
> arch/nios2/boot/dts/3c120_devboard.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nios2/boot/dts/10m50_devboard.dts b/arch/nios2/boot/dts/10m50_devboard.dts
> index 56339bef3247..0e7e5b0dd685 100644
> --- a/arch/nios2/boot/dts/10m50_devboard.dts
> +++ b/arch/nios2/boot/dts/10m50_devboard.dts
> @@ -97,7 +97,7 @@ rgmii_0_eth_tse_0: ethernet@400 {
> rx-fifo-depth = <8192>;
> tx-fifo-depth = <8192>;
> address-bits = <48>;
> - max-frame-size = <1518>;
> + max-frame-size = <1500>;
> local-mac-address = [00 00 00 00 00 00];
> altr,has-supplementary-unicast;
> altr,enable-sup-addr = <1>;
> diff --git a/arch/nios2/boot/dts/3c120_devboard.dts b/arch/nios2/boot/dts/3c120_devboard.dts
> index d10fb81686c7..3ee316906379 100644
> --- a/arch/nios2/boot/dts/3c120_devboard.dts
> +++ b/arch/nios2/boot/dts/3c120_devboard.dts
> @@ -106,7 +106,7 @@ tse_mac: ethernet@4000 {
> interrupt-names = "rx_irq", "tx_irq";
> rx-fifo-depth = <8192>;
> tx-fifo-depth = <8192>;
> - max-frame-size = <1518>;
> + max-frame-size = <1500>;
> local-mac-address = [ 00 00 00 00 00 00 ];
> phy-mode = "rgmii-id";
> phy-handle = <&phy0>;
>
Applied!
Thanks,
Dinh
next prev parent reply other threads:[~2023-02-16 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 12:16 [PATCH v2 0/4] dt-bindings: net: Add network-class.yaml schema Janne Grunau
2023-02-12 12:16 ` [PATCH v2 1/4] dt-bindings: net: Add network-class schema for mac-address properties Janne Grunau
2023-02-12 15:39 ` Andrew Lunn
2023-02-12 12:16 ` [PATCH v2 2/4] dt-bindings: wireless: bcm4329-fmac: Use network-class.yaml schema Janne Grunau
2023-02-12 15:49 ` Andrew Lunn
2023-02-12 12:16 ` [PATCH v2 3/4] dt-bindings: wireless: silabs,wfx: Use network-class.yaml Janne Grunau
2023-02-12 12:16 ` [PATCH v2 4/4] nios2: dts: Fix tse_mac "max-frame-size" property Janne Grunau
2023-02-16 15:54 ` Dinh Nguyen [this message]
2023-02-20 19:40 ` [PATCH v2 0/4] dt-bindings: net: Add network-class.yaml schema Jakub Kicinski
2023-02-20 21:49 ` Rob Herring
2023-02-20 22:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ca87f9-6603-444c-f95d-deff8c8b36b0@kernel.org \
--to=dinguyen@kernel.org \
--cc=arend@broadcom.com \
--cc=cnphoon@altera.com \
--cc=davem@davemloft.net \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=j@jannau.net \
--cc=jerome.pouiller@silabs.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).