From: kgunda@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
lee.jones@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
rnayak@codeaurora.org
Subject: Re: [PATCH V2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
Date: Wed, 06 Nov 2019 12:13:59 +0530 [thread overview]
Message-ID: <c4cee81775c6d82024ca05250290f603@codeaurora.org> (raw)
In-Reply-To: <5dc1cb4c.1c69fb81.af253.0b8a@mx.google.com>
On 2019-11-06 00:49, Stephen Boyd wrote:
> Quoting Kiran Gunda (2019-11-04 21:21:49)
>> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
>> found on SC7180 based platforms.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> - Changes from V1:
>> Sorted the macros and compatibles.
>
> I don't see anything sorted though.
>
Sorry .. I might have misunderstood your comment. Let me know if my
understanding is correct.
>>>> And compatible here.
>>> And on macro name here.
This means you want to sort all the existing compatible and macros in
alpha numeric order ?
>>>> Please sort on compatible string
This means you want sort in the order how the compatibles are defined ?
>>
>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++
>> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> index 1437062..b5fc64e 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> @@ -32,6 +32,8 @@ Required properties:
>> "qcom,pm8998",
>> "qcom,pmi8998",
>> "qcom,pm8005",
>> + "qcom,pm6150",
>> + "qcom,pm6150l",
>
> And this looks badly tabbed or something?
>
My bad, I used tabs. Will correct it in next post.
>> or generalized "qcom,spmi-pmic".
>> - reg: Specifies the SPMI USID slave address for this
>> device.
>> For more information see:
>> diff --git a/drivers/mfd/qcom-spmi-pmic.c
>> b/drivers/mfd/qcom-spmi-pmic.c
>> index e8fe705..74b7980 100644
>> --- a/drivers/mfd/qcom-spmi-pmic.c
>> +++ b/drivers/mfd/qcom-spmi-pmic.c
>> @@ -34,6 +34,8 @@
>> #define PM8998_SUBTYPE 0x14
>> #define PMI8998_SUBTYPE 0x15
>> #define PM8005_SUBTYPE 0x18
>> +#define PM6150_SUBTYPE 0x28
>> +#define PM6150L_SUBTYPE 0x27
>>
>> static const struct of_device_id pmic_spmi_id_table[] = {
>> { .compatible = "qcom,spmi-pmic", .data = (void
>> *)COMMON_SUBTYPE },
>> @@ -53,6 +55,8 @@
>> { .compatible = "qcom,pm8998", .data = (void
>> *)PM8998_SUBTYPE },
>> { .compatible = "qcom,pmi8998", .data = (void
>> *)PMI8998_SUBTYPE },
>> { .compatible = "qcom,pm8005", .data = (void
>> *)PM8005_SUBTYPE },
>> + { .compatible = "qcom,pm6150", .data = (void
>> *)PM6150_SUBTYPE },
>> + { .compatible = "qcom,pm6150l", .data = (void
>> *)PM6150L_SUBTYPE },
>> { }
>> };
>>
next prev parent reply other threads:[~2019-11-06 6:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 5:21 [PATCH V2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
2019-11-05 19:19 ` Stephen Boyd
2019-11-06 6:43 ` kgunda [this message]
2019-11-06 16:38 ` Stephen Boyd
2019-11-11 6:15 ` kgunda
2020-01-21 19:34 ` Matthias Kaehlcke
2020-01-23 5:55 ` kgunda
2019-11-06 16:38 ` Stephen Boyd
2019-11-11 6:14 ` kgunda
2019-11-11 11:28 ` Lee Jones
2019-11-12 9:03 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4cee81775c6d82024ca05250290f603@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).