From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>, Ben Pai <Ben_Pai@wistron.com>
Cc: robh+dt@kernel.org, jdelvare@suse.com,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, corbet@lwn.net, wangat@tw.ibm.com,
Andy_YF_Wang@wistron.com, Claire_Ku@wistron.com
Subject: Re: [ v2] hwmon: (pmbus) Add Wistron power supply pmbus driver
Date: Thu, 12 Dec 2019 18:28:24 -0800 [thread overview]
Message-ID: <c5d72bfe-0ebc-5d9a-ebad-092ff802cc5c@roeck-us.net> (raw)
In-Reply-To: <97651ec9-e467-dbd9-dcb8-b3efe1387fef@linux.ibm.com>
On 12/12/19 3:54 PM, Eddie James wrote:
>
> On 12/8/19 7:44 AM, Ben Pai wrote:
>> Add the driver to monitor Wisreon power supplies with hwmon over pmbus.
>
>
> Hi Ben.
>
>
> This driver looks very similar to the IBM CFFPS driver. If you think they are similar enough, you may want to simply add a new version to that driver that supports your PSU.
>
It would be nice to have datasheets for those power supplies.
Eddie - is it possible that the IBM power supply supports the WRITE_PROTECT
command and has a write protect bit set ? If yes, I just submitted a patch
for the PMBus core to address the situation; see
https://patchwork.kernel.org/patch/11289717/
Thanks,
Guenter
prev parent reply other threads:[~2019-12-13 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 13:44 [ v2] hwmon: (pmbus) Add Wistron power supply pmbus driver Ben Pai
2019-12-08 15:34 ` Guenter Roeck
2019-12-12 23:54 ` Eddie James
2019-12-13 2:28 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5d72bfe-0ebc-5d9a-ebad-092ff802cc5c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Andy_YF_Wang@wistron.com \
--cc=Ben_Pai@wistron.com \
--cc=Claire_Ku@wistron.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wangat@tw.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).