From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F42C4338F for ; Wed, 18 Aug 2021 06:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1149B60FE6 for ; Wed, 18 Aug 2021 06:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238057AbhHRGuB (ORCPT ); Wed, 18 Aug 2021 02:50:01 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:52936 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238081AbhHRGuA (ORCPT ); Wed, 18 Aug 2021 02:50:00 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id AAAD3412B6 for ; Wed, 18 Aug 2021 06:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629269365; bh=koyaZ5FIZxDdS33SITxLj7wHGHh/MSdOiD6GS5fpHeg=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=LxH8xivxknKbu4PGoNssjfpIhFmTTJS13p40vXmGzRWBM8fZhw6sjJJ3oQsC3RUOq xQ5m3MjNoHlNhJAdVnea8HHideSZIFVb4Mgwjjc1uOoHuQeIAKLor5aqiZ5u7surzl MSG0eQR9xo6hBnlKXLo3x07cAGB4DZqTLinqtwjLLqa0Xv+HGtmDnRG0SIa8Ln7UA+ 6ITkLPfu+K6zc9F2O8ajLai2sVydqLk4SNqnYeK++s8/ARpuioYq/zVPC1M7SdYVcf bfI91/PpBabdySBu6YuShmiUOyM0BpLCcLZEUHdwY8S99Iss0SEkLp8br90B2/XTlH Zq7vAM6m8K7ag== Received: by mail-ed1-f70.google.com with SMTP id v20-20020aa7d9d40000b02903be68450bf3so517150eds.23 for ; Tue, 17 Aug 2021 23:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=koyaZ5FIZxDdS33SITxLj7wHGHh/MSdOiD6GS5fpHeg=; b=fsrquieJzj3nDTcAwAi7S050vnTIYv66Lvk+A/TM72D/FDADbu5E/his6pcBbhV5a1 QqBWbCD1QwndJxfkCxvMZs9gmrGe1OrRXNlNrr2Qm8Q+lCyoEXJYYni2iQRsBAS+I0e8 xc6WbF1RCbMlMtd3vsbLWXZ07VdWsbCiVulEzh1aluN15wtHl2EZ0WlLDOAhSNZe+Bb1 e7D//zW/3ruoPqVo2qx6VsG3+XluS8YuvFhiumseslpNsygiilVWqfgO/g3hiZiRMrMP HOO33KNXUF8k+lfUyFdiivZY9l3gbKEYIm1zA7vDkpzgCIaK00xIv9yHWA1fW72ueujU rqpg== X-Gm-Message-State: AOAM5307NcKtHPLOjauEtdA82CSRZVFMOGBoO38h7IRXIp6yiCrB1Ce3 b/6NSMXA5AjqVMhPiafXI4f6WRBpyTGb/zgfWUAwCJlm0fvhjl0qvWCoYGxaLWHwSLQ0X+jR+iI u4My1VyqKW2ISC53kutdrVGz+ftLM1IVCJ4utyCs= X-Received: by 2002:a17:906:1f8e:: with SMTP id t14mr8154727ejr.313.1629269365328; Tue, 17 Aug 2021 23:49:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWhQFCV598TtTdTr1EoTmYGq5dI5oFgzC45QcBRmM+oIeH6pPwo+Is9DtzMEBVJyV2Y08tYw== X-Received: by 2002:a17:906:1f8e:: with SMTP id t14mr8154708ejr.313.1629269365121; Tue, 17 Aug 2021 23:49:25 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id f20sm1580873ejz.30.2021.08.17.23.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 23:49:24 -0700 (PDT) Subject: Re: [PATCH v2 1/8] dt-bindings: clock: samsung: convert Exynos5250 to dtschema To: Rob Herring Cc: Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Protsenko References: <20210810093145.26153-1-krzysztof.kozlowski@canonical.com> <20210810093145.26153-2-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Wed, 18 Aug 2021 08:49:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/08/2021 22:16, Rob Herring wrote: > On Tue, Aug 10, 2021 at 11:31:38AM +0200, Krzysztof Kozlowski wrote: >> Convert Samsung Exynos5250 clock controller bindings to DT schema format >> using json-schema. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/clock/exynos5250-clock.txt | 41 ---------------- >> .../bindings/clock/samsung,exynos-clock.yaml | 48 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 3 files changed, 49 insertions(+), 41 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/clock/exynos5250-clock.txt >> create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynos-clock.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/exynos5250-clock.txt b/Documentation/devicetree/bindings/clock/exynos5250-clock.txt >> deleted file mode 100644 >> index aff266a12eeb..000000000000 >> --- a/Documentation/devicetree/bindings/clock/exynos5250-clock.txt >> +++ /dev/null >> @@ -1,41 +0,0 @@ >> -* Samsung Exynos5250 Clock Controller >> - >> -The Exynos5250 clock controller generates and supplies clock to various >> -controllers within the Exynos5250 SoC. >> - >> -Required Properties: >> - >> -- compatible: should be one of the following. >> - - "samsung,exynos5250-clock" - controller compatible with Exynos5250 SoC. >> - >> -- reg: physical base address of the controller and length of memory mapped >> - region. >> - >> -- #clock-cells: should be 1. >> - >> -Each clock is assigned an identifier and client nodes can use this identifier >> -to specify the clock which they consume. >> - >> -All available clocks are defined as preprocessor macros in >> -dt-bindings/clock/exynos5250.h header and can be used in device >> -tree sources. >> - >> -Example 1: An example of a clock controller node is listed below. >> - >> - clock: clock-controller@10010000 { >> - compatible = "samsung,exynos5250-clock"; >> - reg = <0x10010000 0x30000>; >> - #clock-cells = <1>; >> - }; >> - >> -Example 2: UART controller node that consumes the clock generated by the clock >> - controller. Refer to the standard clock bindings for information >> - about 'clocks' and 'clock-names' property. >> - >> - serial@13820000 { >> - compatible = "samsung,exynos4210-uart"; >> - reg = <0x13820000 0x100>; >> - interrupts = <0 54 0>; >> - clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; >> - clock-names = "uart", "clk_uart_baud0"; >> - }; >> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos-clock.yaml >> new file mode 100644 >> index 000000000000..cd6567bd8cc7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/samsung,exynos-clock.yaml >> @@ -0,0 +1,48 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/samsung,exynos-clock.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Samsung Exynos SoC clock controller >> + >> +maintainers: >> + - Chanwoo Choi >> + - Krzysztof Kozlowski >> + - Sylwester Nawrocki >> + - Tomasz Figa >> + >> +description: | >> + All available clocks are defined as preprocessor macros in >> + dt-bindings/clock/ headers. >> + >> +properties: >> + compatible: >> + const: samsung,exynos5250-clock >> + >> + assigned-clocks: true >> + assigned-clock-parents: true >> + assigned-clock-rates: true > > These can be dropped. They are always allowed if 'clocks' is present. > >> + clocks: true > > This needs to define how many. > Right, thanks. Best regards, Krzysztof