From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA039C43217 for ; Tue, 9 Nov 2021 12:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C66F96109F for ; Tue, 9 Nov 2021 12:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234143AbhKIM7o (ORCPT ); Tue, 9 Nov 2021 07:59:44 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:54058 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234190AbhKIM7m (ORCPT ); Tue, 9 Nov 2021 07:59:42 -0500 Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id ABFBE4081B for ; Tue, 9 Nov 2021 12:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636462615; bh=yZUG7Tb7m1UqX5nCLe8b1PQIfsTUxqRuBTIMx3/ftko=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D898EUzhhoElf0sywtzsUznZ36Op/5YBxwsBhHFD0m8DnlugqjDtj1RS3Q/C5RFaX 8tYrYzaiKczM1SCuQ8LOY6BR0qDsikWiAH/drxnwjz5qS7y6WF1eL8auLVe409GofX lu7PZPI1JeAAqh+9GhaKMuOtogVNDGUDU3Q0+KQpiD/lUAizNihpSUNXLxcDtrns/r 6Rk9xs4VZbXFGahmQZjLIUX2e7yYA6FNhKO5qDCB2ZMlh23mL7eSC3iiVaS83CmJt8 tP0AGxhJC8gG4rfMITA3WggNea7flHGNg+zx2OUnI84Ts8yTjQHYer2Qn8EFPwuMv9 2POczwnP8MT2g== Received: by mail-lj1-f200.google.com with SMTP id v13-20020a2e2f0d000000b0021126b5cca2so6109711ljv.19 for ; Tue, 09 Nov 2021 04:56:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yZUG7Tb7m1UqX5nCLe8b1PQIfsTUxqRuBTIMx3/ftko=; b=iNGTPFm1/4ZNGpGdR2+m419WqJADSjWFf5Se6i2LXotzPuxCRvw8QrQmz3wRtV1Y8F eUA6sHHAjj1PH5HHYclPvCI3fLXBy4+04c+5WOxxonpQQj1xC+PuepODmHegZjwjY2FY X7Vip6dgF7L6nV5yknUvPEox65GsMb9u1V1KWULQYGq43Wu/Tt1tK2r7N+TopJiPmhBL orBu7U8QteFJOn7Z3QA8RJHCqJ9cWVIBEUlVrkjmt32q+2TVzxGqpwQV3HlRGj7wy+Y5 puLvfle4OJ/MLbj1eDMg83lUTGMKOnwfG9lKaYUHc3lUFIOe/bjED3t7H2W55nREsdpJ SwQg== X-Gm-Message-State: AOAM533utuAYzlEfHJIJi4pPdAJtUkcAwKSsXxC1emDARKOlXK3ptdsh R7LoXfZyj1eSS2dE3zi3Kceix938VTnm/WhceZySN1heMHcbi3vaPYO/kWzCugfh7uCveNVqAPF Gap/wTziKpUMGs709umy+SRSBeNanbkJplLRpcIg= X-Received: by 2002:a05:6512:1045:: with SMTP id c5mr6954932lfb.115.1636462614630; Tue, 09 Nov 2021 04:56:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwITYDenNraLQf7L9QCEZpNJX/wzJp+LTTIyOssbyLIHoaCcJ+w/+l+RGCCEXGOEyjZkvgRIA== X-Received: by 2002:a05:6512:1045:: with SMTP id c5mr6954909lfb.115.1636462614426; Tue, 09 Nov 2021 04:56:54 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id n7sm2131681lft.309.2021.11.09.04.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 04:56:53 -0800 (PST) Message-ID: Date: Tue, 9 Nov 2021 13:56:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 06/13] dt-bindings: rng: add bindings for microchip mpfs rng Content-Language: en-US To: Conor.Dooley@microchip.com Cc: broonie@kernel.org, aou@eecs.berkeley.edu, robh+dt@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, palmer@dabbelt.com, paul.walmsley@sifive.com, jassisinghbrar@gmail.com, atish.patra@wdc.com, Daire.McNamara@microchip.com, Lewis.Hanly@microchip.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, geert@linux-m68k.org, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, linux-crypto@vger.kernel.org, linux-usb@vger.kernel.org, bin.meng@windriver.com, linux-i2c@vger.kernel.org, alexandre.belloni@bootlin.com, Ivan.Griffin@microchip.com, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, a.zummo@towertech.it, gregkh@linuxfoundation.org References: <20211108150554.4457-1-conor.dooley@microchip.com> <20211108150554.4457-7-conor.dooley@microchip.com> <71c6917e-1463-c708-550a-726e5fe1566d@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <71c6917e-1463-c708-550a-726e5fe1566d@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2021 13:54, Conor.Dooley@microchip.com wrote: > On 08/11/2021 21:16, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 08/11/2021 16:05, conor.dooley@microchip.com wrote: >>> From: Conor Dooley >>> >>> Add device tree bindings for the hardware rng device accessed via >>> the system services on the Microchip PolarFire SoC. >>> >>> Signed-off-by: Conor Dooley >>> --- >>> .../bindings/rng/microchip,mpfs-rng.yaml | 31 +++++++++++++++++++ >>> 1 file changed, 31 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml b/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml >>> new file mode 100644 >>> index 000000000000..e8ecb3538a86 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/rng/microchip,mpfs-rng.yaml >>> @@ -0,0 +1,31 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: "http://devicetree.org/schemas/rng/microchip,mpfs-rng.yaml#" >>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >>> + >>> +title: Microchip MPFS random number generator >>> + >>> +maintainers: >>> + - Conor Dooley >>> + >>> +properties: >>> + compatible: >>> + const: microchip,polarfire-soc-rng >>> + >>> + syscontroller: >>> + maxItems: 1 >>> + description: name of the system controller device node >> >> There are several issues with this: >> 1. You need to describe the type. >> 2. Description is not helpful (just copying the name of property) and >> actually misleading because you do not put there the name of device node. >> 3. What is it? Looks like syscon (or sometimes called sysreg). If yes, >> please use existing syscon bindings. > 1 & 2 - Correct, it is bad & I'll write a better description for it. > 3 - Its a system controller implemented as a mailbox. The syscontroller > is the mailbox client, which the rng and generic drivers both use. I understood that pointed device node is a mailbox, not this node. But here, what is it here? How do you use it here? Best regards, Krzysztof