From: "Wells Lu 呂芳騰" <wells.lu@sunplus.com>
To: Andrew Lunn <andrew@lunn.ch>, Wells Lu <wellslutw@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"Vincent Shih 施錕鴻" <vincent.shih@sunplus.com>
Subject: RE: [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.
Date: Wed, 1 Dec 2021 07:02:19 +0000 [thread overview]
Message-ID: <cafbb308e5554fa2ab5db4ffe01a777d@sphcmbx02.sunplus.com.tw> (raw)
In-Reply-To: <YabWUQdIP288U09d@lunn.ch>
Hi Andrew,
Thank you very much for review.
I'll move properties nvmem-cells and nvmem-cell-names to ethernet ports
and change value of nvmem-cell-names to "mac-address" next patch.
I'll refer to "nvmem_get_mac_address()" when modifying code.
Best regards,
Wells
> > + nvmem-cells:
> > + items:
> > + - description: nvmem cell address of MAC address of 1st MAC
> > + - description: nvmem cell address of MAC address of 2nd MAC
> > +
> > + nvmem-cell-names:
> > + description: names corresponding to the nvmem cells of MAC address
> > + items:
> > + - const: mac_addr0
> > + - const: mac_addr1
>
> These are port properties, so put them in the port section.
>
> Also, the name you should use is well defined, "mac-address". See nvmem_get_mac_address().
> But you won't be able to use that helper because it take dev, not an of node.
>
> Andrew
next prev parent reply other threads:[~2021-12-01 7:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 10:02 [PATCH net-next v3 0/2] This is a patch series for pinctrl driver for Sunplus SP7021 SoC Wells Lu
2021-11-30 10:02 ` [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2021-12-01 1:56 ` Andrew Lunn
2021-12-01 7:02 ` Wells Lu 呂芳騰 [this message]
2021-11-30 10:02 ` [PATCH net-next v3 2/2] net: ethernet: Add driver " Wells Lu
2021-11-30 13:51 ` kernel test robot
2021-12-01 3:30 ` Andrew Lunn
2021-12-02 11:20 ` Wells Lu 呂芳騰
2021-12-02 13:04 ` Andrew Lunn
2021-12-02 18:46 ` Wells Lu 呂芳騰
2021-12-02 19:03 ` Andrew Lunn
2021-12-03 1:36 ` Wells Lu 呂芳騰
2021-11-30 20:17 ` [PATCH net-next v3 0/2] This is a patch series for pinctrl driver for Sunplus SP7021 SoC Andrew Lunn
2021-12-01 1:42 ` Wells Lu 呂芳騰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cafbb308e5554fa2ab5db4ffe01a777d@sphcmbx02.sunplus.com.tw \
--to=wells.lu@sunplus.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vincent.shih@sunplus.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).