From: "Andreas Färber" <afaerber@suse.de>
To: "James Tai [戴志峰]" <james.tai@realtek.com>
Cc: "linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB
Date: Wed, 15 Apr 2020 11:19:38 +0200 [thread overview]
Message-ID: <cb724434-bebf-2a23-fd90-8cd82078459d@suse.de> (raw)
In-Reply-To: <a9685d4560a6445d81c4919b2a323f68@realtek.com>
Hi James,
Am 15.04.20 um 10:58 schrieb James Tai [戴志峰]:
>>> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml
>>> b/Documentation/devicetree/bindings/arm/realtek.yaml
>>> index 845f9c76d6f7..3b48ae71fdd8 100644
>>> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
>>> @@ -42,6 +42,12 @@ properties:
>>> - synology,ds418 # Synology DiskStation DS418
>>> - const: realtek,rtd1296
>>>
>>> + # RTD1319 SoC based boards
>>> + - items:
>>> + - enum:
>>> + - realtek,pymparticle # Realtek PymParticle EVB
>>
>> The board seems labelled "PYM_PARTICLES".
>>
>> While Wikipedia has nothing on that, I found this explanation:
>> https://marvel.fandom.com/wiki/Pym_Particles
>>
>> So, are you sure it's PymParticle and not "Pym Particle" with space or "Pym
>> Particles" with space and plural S? The S would affect also the .dts filename.
>>
> I should change the string to "Pym Particles".
Okay, in that case I suggest rtd1319-pymparticles.dts for consistency.
Unless you want to change rtd1395-lionskin.dts to rtd1395-lion-skin.dts.
>> For the compatible string the question is pymparticle or pym-particle.
>>
> The compatible string is "pym-particles".
Works for me. (always assuming we both imply the "realtek," prefix)
If you send a v4, please double-check the comments in patch 2/2.
>> By comparison, LION-SKIN was named lion-skin in the compatible and spelled
>> Lion Skin in textual form. If you believe that should be fixed, now would be the
>> time to revisit those patches that didn't make v5.7.
>>
> I'll check those relevant patches.
Thanks,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2020-04-15 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 14:52 [PATCH v3 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai
2020-02-04 14:52 ` [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai
2020-02-05 16:47 ` Rob Herring
2020-02-07 2:53 ` James Tai [戴志峰]
2020-04-13 0:17 ` Andreas Färber
2020-04-15 8:58 ` James Tai [戴志峰]
2020-04-15 9:19 ` Andreas Färber [this message]
2020-02-04 14:52 ` [PATCH v3 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai
2020-04-15 11:41 ` Andreas Färber
2020-04-16 8:47 ` James Tai [戴志峰]
2020-04-16 9:45 ` Robin Murphy
2020-04-16 15:00 ` James Tai [戴志峰]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb724434-bebf-2a23-fd90-8cd82078459d@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=james.tai@realtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).