From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BF9C433FE for ; Tue, 9 Nov 2021 13:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B4EB61175 for ; Tue, 9 Nov 2021 13:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239362AbhKINHN (ORCPT ); Tue, 9 Nov 2021 08:07:13 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:54452 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239327AbhKINHL (ORCPT ); Tue, 9 Nov 2021 08:07:11 -0500 Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A3CC83F1B9 for ; Tue, 9 Nov 2021 13:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636463064; bh=2z2NwvSe6pbSG5kNNw29eMx53Iup6V00jrvNyErV2mE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oQzMfY1O2Uz/81RkOpqyzvDEI9byM73TqP12Ol+u+emwUpLNmcSAOjdgz+muVyCUQ S1w8NbeXoHkFg7TLaYs0PkmCEiiyaNzCEsi9R0+fJeB+3yW18Lai8xUPXMcHSlrbEb w6mn0VvXHTIleMptnJFZjYQc8nPa/YLcGdhyUKX1mq5bxanYe3l/v0UvaclXMqkIgG SKuaM9omNc5ZOmNS4IViIZEMCgRJER5sCqLka76mmXnEZdIuQ+6XX7/LXzU/tew/2M 1gY6olEBjrxmL4bKAVW+4yYKQbjLU094xtZzkjYOQ6hKxJ64ttmMsg5sIqAWj7Hact V+G9KuIgWjNoQ== Received: by mail-lj1-f198.google.com with SMTP id bn14-20020a05651c178e00b002164a557684so6186564ljb.6 for ; Tue, 09 Nov 2021 05:04:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2z2NwvSe6pbSG5kNNw29eMx53Iup6V00jrvNyErV2mE=; b=U17jaYy5faSu92fQCqn96RIayXHM7ZvQXeeia5XJsNKQio//IXNILOV+2fqkpdzZhV TlLBMCOj5Ae5+uzUBJSdSXNG+4UAdSzJ4BpQRFdjj9B3Om8kAerIhskzjKbiDE/KIy/5 zt5kabHNN4Gok1xWNez8PWX5oycSxjpI0lGNlrzwpPsi9qoWyo3fWNN07SyIyN1Sokok asqCe9CsFKYOPMl7KDHOak3mZCgKJVepC15Si2MmDip9uwQ9fZEB0wgn465kl+XFyXw1 a/N8E4mX82f2Fkos17fV7yucdobHCsUB11ab2KXp5MV0b6kspDa3qE45jr0BQxKBIUof DtZg== X-Gm-Message-State: AOAM531ys6Xh9bDZMsOxlBHBcTx4oSbO0/9ptmp37WGhdI1QJvgC1Z3p E0GbxGJ/U4WHex59S9XFCpCHVSIpglXksotuIBCCG0YU+F5GqW6gMLYkD5QRYMPaqX8nVULWnoy yo8JCIhEh68sbCVNEa89aRytBHpDrd9gM+tYrXNc= X-Received: by 2002:a19:f10a:: with SMTP id p10mr6630527lfh.487.1636463063942; Tue, 09 Nov 2021 05:04:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGfpAHgwdqfMj0s/66s42howwCx2sXSklpMlY9GdmuaJ26SPoUGcHRWzMdDHEWP4UUsor7zg== X-Received: by 2002:a19:f10a:: with SMTP id p10mr6630507lfh.487.1636463063757; Tue, 09 Nov 2021 05:04:23 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id bq3sm2139606lfb.173.2021.11.09.05.04.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 05:04:15 -0800 (PST) Message-ID: Date: Tue, 9 Nov 2021 14:04:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 10/13] dt-bindings: spi: add bindings for microchip mpfs spi Content-Language: en-US To: Conor.Dooley@microchip.com, robh@kernel.org Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, linux-usb@vger.kernel.org, Daire.McNamara@microchip.com, linux-spi@vger.kernel.org, geert@linux-m68k.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, palmer@dabbelt.com, bgolaszewski@baylibre.com, jassisinghbrar@gmail.com, linux-crypto@vger.kernel.org, Ivan.Griffin@microchip.com, atish.patra@wdc.com, Lewis.Hanly@microchip.com, bin.meng@windriver.com, alexandre.belloni@bootlin.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, a.zummo@towertech.it References: <20211108150554.4457-1-conor.dooley@microchip.com> <20211108150554.4457-11-conor.dooley@microchip.com> <1636430789.935637.743042.nullmailer@robh.at.kernel.org> <96005893-8819-1d76-6dea-7d173655258f@microchip.com> <0d996393-20b9-4f16-cbd0-c9bff2b54112@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2021 13:58, Conor.Dooley@microchip.com wrote: > On 09/11/2021 12:53, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 09/11/2021 13:16, Conor.Dooley@microchip.com wrote: >>> On 09/11/2021 04:06, Rob Herring wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>> >>>> On Mon, 08 Nov 2021 15:05:51 +0000, conor.dooley@microchip.com wrote: >>>>> From: Conor Dooley >>>>> >>>>> Add device tree bindings for the {q,}spi controller on >>>>> the Microchip PolarFire SoC. >>>>> >>>>> Signed-off-by: Conor Dooley >>>>> --- >>>>> .../bindings/spi/microchip,mpfs-spi.yaml | 72 +++++++++++++++++++ >>>>> 1 file changed, 72 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml >>>>> >>>> >>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>>> >>>> yamllint warnings/errors: >>>> >>>> dtschema/dtc warnings/errors: >>>> Documentation/devicetree/bindings/spi/microchip,mpfs-spi.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory >>>> 19 | #include "dt-bindings/clock/microchip,mpfs-clock.h" >>> Rob, >>> Should I drop the header from the example or is there a way for me >>> specify the dependent patch to pass this check? >> >> The error has to be fixed, although not necessarily by dropping the >> header, but by posting it. How this can pass on your system? There is no >> such file added in this patchset. > I linked the patch adding the clock as a dependency in the cover letter > [1], which is why I was wondering if there was a better way to do so > that would get picked up by the checker bot. It's not only about the bot, but dependency when applied. If you did not warn clk maintainer that clock bindings should go via Rob's tree or should be provided as a tag, the patches here cannot be applied in this cycle. Best regards, Krzysztof