From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E6EC352A2 for ; Fri, 7 Feb 2020 11:09:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92DA7222C2 for ; Fri, 7 Feb 2020 11:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581073795; bh=YtjeGCn68V/W0a9LzM3q6bLhd/qtIlFq6rULUBv7KcU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=MYLX8edpgAahGy1JcEkrDT1PoqAW16IOyiN0P1qHcD7OmW4aWq3z4vuDh9BqffRXx MP1Y4KatvTexotMVPXVxQA03JI/jCFHrhoPfrYBjfg3INJ6JtzrZxaRw9PtG0ooKmI xwAk76kHVAZ1AQO+QEe45wnlQKqL62Cw8TyRbbOo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbgBGLJw (ORCPT ); Fri, 7 Feb 2020 06:09:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:52092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGLJv (ORCPT ); Fri, 7 Feb 2020 06:09:51 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D25320720; Fri, 7 Feb 2020 11:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581073790; bh=YtjeGCn68V/W0a9LzM3q6bLhd/qtIlFq6rULUBv7KcU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Tk5hFyqLF7Lwyb8GIAxvdOqUCLSt9+nWA/f58u7fk6oB0Uk5vh/77OrtCccUaSKJi tUUERm4UmMVStUrK6mUeUxXImz5fIPdgFMw3WG8YgZmKrBb0JRakYr/lkrAbm2k2VY 8XbjT4SCQekNlRz0tiV3Hq13GBeY2hpo0nVJDqTU= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j01W8-003W5T-RP; Fri, 07 Feb 2020 11:09:48 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Feb 2020 11:09:48 +0000 From: Marc Zyngier To: Peng Fan Cc: Sudeep Holla , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, f.fainelli@gmail.com, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, dl-linux-imx , andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transports In-Reply-To: References: <1580994086-17850-1-git-send-email-peng.fan@nxp.com> <1580994086-17850-2-git-send-email-peng.fan@nxp.com> <7875e2533c4ba23b8ca0a2a296699497@kernel.org> <20200207104736.GB36345@bogus> <5a073c37e877d23977e440de52dba6e0@kernel.org> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: peng.fan@nxp.com, sudeep.holla@arm.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, f.fainelli@gmail.com, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-02-07 11:00, Peng Fan wrote: >> Subject: Re: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc >> transports >> >> On 2020-02-07 10:47, Sudeep Holla wrote: >> > On Fri, Feb 07, 2020 at 10:08:36AM +0000, Marc Zyngier wrote: >> >> On 2020-02-06 13:01, peng.fan@nxp.com wrote: >> >> > From: Peng Fan >> >> > >> >> > SCMI could use SMC/HVC as tranports, so add into devicetree binding >> >> > doc. >> >> > >> >> > Signed-off-by: Peng Fan >> >> > --- >> >> > Documentation/devicetree/bindings/arm/arm,scmi.txt | 4 +++- >> >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> >> > >> >> > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt >> >> > b/Documentation/devicetree/bindings/arm/arm,scmi.txt >> >> > index f493d69e6194..03cff8b55a93 100644 >> >> > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt >> >> > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt >> >> > @@ -14,7 +14,7 @@ Required properties: >> >> > >> >> > The scmi node with the following properties shall be under the >> >> > /firmware/ node. >> >> > >> >> > -- compatible : shall be "arm,scmi" >> >> > +- compatible : shall be "arm,scmi" or "arm,scmi-smc" >> >> > - mboxes: List of phandle and mailbox channel specifiers. It >> >> > should contain >> >> > exactly one or two mailboxes, one for transmitting messages("tx") >> >> > and another optional for receiving the notifications("rx") if >> >> > @@ -25,6 +25,8 @@ The scmi node with the following properties shall >> >> > be under the /firmware/ node. >> >> > protocol identifier for a given sub-node. >> >> > - #size-cells : should be '0' as 'reg' property doesn't have any size >> >> > associated with it. >> >> > +- arm,smc-id : SMC id required when using smc transports >> >> > +- arm,hvc-id : HVC id required when using hvc transports >> >> > >> >> > Optional properties: >> >> >> >> Not directly related to DT: Why do we need to distinguish between SMC >> >> and HVC? >> > >> > IIUC you want just one property to get the function ID ? Does that >> > align with what you are saying ? I wanted to ask the same question and >> > I see no need for 2 different properties. >> >> Exactly. Using SMC or HVC should come from the context, and there is >> zero >> value in having different different IDs, depending on the conduit. >> >> We *really* want SMC and HVC to behave the same way. Any attempt to >> make them different should just be NAKed. > > ok. Then just like psci node, > Add a "method" property for each protocol, and add "arm,func-id" to > indicate the ID. > > How about this? Or rather just a function ID, full stop. the conduit *MUST* be inherited from the PSCI context. M. -- Jazz is not dead. It just smells funny...