From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH 1/4] dmaengine: qcom: bam_dma: make bam clk optional Date: Wed, 17 Jan 2018 09:46:31 +0000 Message-ID: References: <20180116190236.14558-1-srinivas.kandagatla@linaro.org> <20180116190236.14558-2-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sagar Dharia , Vinod Koul , Andy Gross , dmaengine@vger.kernel.org Cc: Rob Herring , Mark Rutland , David Brown , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, yanhe@quicinc.com, ramkri@qti.qualcomm.com, sdharia@quicinc.com List-Id: devicetree@vger.kernel.org On 16/01/18 19:38, Sagar Dharia wrote: > > On 1/16/2018 12:02 PM, srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla >> >> When BAM is remotely controlled it does not sound correct to control >> its clk on Linux side. Make it optional, so that its not madatory >> for remote controlled BAM instances. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/dma/qcom/bam_dma.c | 15 ++++++++------- >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c >> index 03c4eb3fd314..78e488e8f96d 100644 >> --- a/drivers/dma/qcom/bam_dma.c >> +++ b/drivers/dma/qcom/bam_dma.c >> @@ -1180,13 +1180,14 @@ static int bam_dma_probe(struct >> platform_device *pdev) >> "qcom,controlled-remotely"); >> bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); >> - if (IS_ERR(bdev->bamclk)) >> - return PTR_ERR(bdev->bamclk); >> - >> - ret = clk_prepare_enable(bdev->bamclk); >> - if (ret) { >> - dev_err(bdev->dev, "failed to prepare/enable clock\n"); >> - return ret; >> + if (IS_ERR(bdev->bamclk)) { >> + bdev->bamclk = NULL; >> + } else { >> + ret = clk_prepare_enable(bdev->bamclk); >> + if (ret) { >> + dev_err(bdev->dev, "failed to prepare/enable clock\n"); >> + return ret; >> + } > I believe you can also keep pm_runtime disabled if BAM is remotely > controlled. Yes, that's another topic which should be fixed too. I will add that patch in next version. thanks, srini > > Thanks > Sagar >> } >> ret = bam_init(bdev); >