From: Randy Dunlap <rdunlap@infradead.org>
To: Dan Robertson <dan@dlrobertson.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
devicetree@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5 2/2] iio: (bma400) add driver for the BMA400
Date: Sun, 8 Dec 2019 18:54:44 -0800 [thread overview]
Message-ID: <cf3f2297-dc01-b2c9-657b-933f24b15594@infradead.org> (raw)
In-Reply-To: <20191209014320.13149-3-dan@dlrobertson.com>
Hi,
On 12/8/19 5:43 PM, Dan Robertson wrote:
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index d4ef35aeb579..dc9bc646d403 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -112,6 +112,22 @@ config BMA220
> To compile this driver as a module, choose M here: the
> module will be called bma220_spi.
>
> +config BMA400
> + tristate "Bosch BMA400 3-Axis Accelerometer Driver"
> + select REGMAP
> + select BMA400_I2C if (I2C)
What's with the parentheses? I see that there are roughly 2700
"select ... if X" without parens and around 95 like
"select ... if (" [using rough grep expressions].
The parens are unnecessary. They are often used on complex
expressions, but certainly not on simple ones (except in iio).
> + help
> + Say Y here if you want to build a driver for the Bosch BMA400
> + triaxial acceleration sensor.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called bma400_core and you will also get
> + bma400_i2c for I2C.
iff I2C is set/enabled, so could be confusing.
> +
> +config BMA400_I2C
> + tristate
> + depends on BMA400
> +
> config BMC150_ACCEL
> tristate "Bosch BMC150 Accelerometer Driver"
> select IIO_BUFFER
--
~Randy
next prev parent reply other threads:[~2019-12-09 2:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 1:43 [PATCH v5 0/2] iio: add driver for Bosch BMA400 accelerometer Dan Robertson
2019-12-09 1:43 ` [PATCH v5 1/2] dt-bindings: iio: accel: bma400: add bindings Dan Robertson
2019-12-09 1:43 ` [PATCH v5 2/2] iio: (bma400) add driver for the BMA400 Dan Robertson
2019-12-09 2:54 ` Randy Dunlap [this message]
2019-12-09 18:11 ` Dan Robertson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3f2297-dc01-b2c9-657b-933f24b15594@infradead.org \
--to=rdunlap@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).