* [PATCH v3 00/15] usb: dwc3: Add new updates for DWC_usb31
@ 2018-01-18 1:51 Thinh Nguyen
[not found] ` <cover.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Thinh Nguyen @ 2018-01-18 1:51 UTC (permalink / raw)
To: Felipe Balbi, Thinh Nguyen, linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Laurent Pinchart,
Alan Stern, Vamsi Krishna Samavedam, Mark Rutland, Li Jun,
Gustavo A. R. Silva, Takashi Iwai
Cc: John Youn
This patch series adds new updates and some fixes for DWC_usb31.
Changes in v3:
- Add "usb: dwc3: Check controller type before setting speed" to series
Changes in v2:
- Add another patch to the series to increase mass_storage max_speed
- Separate "usb: dwc3: ep0: Reset TRB counter for ep0 IN" from series
- Separate "usb: dwc3: gadget: Set maxpacket size for ep0 IN" from series
- Use msleep() instead of mdelay() for SoftReset PHY sync delay
- Rename new USB31 macros from DWC3_USB31_* to DWC31_*
- Rename device properties and replace '_' with '-'
- Minor fixes in the commit messages
Thinh Nguyen (15):
usb: dwc3: Add SoftReset PHY synchonization delay
usb: core: urb: Check SSP isoc ep comp descriptor
usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields
usb: dwc3: Check IP revision for GTXFIFOSIZ
usb: dwc3: Add DWC_usb31 GRXTHRCFG bit fields
usb: dwc3: gadget: Check IP revision for GRXTHRCFG
usb: dwc3: Add DWC_usb31 GTXTHRCFG reg fields
usb: dwc3: Make TX/RX threshold configurable
usb: dwc3: Check for ESS TX/RX threshold config
usb: dwc3: Dump LSP and BMU debug info
usb: dwc3: Track DWC_usb31 VERSIONTYPE
usb: dwc3: Add disabling of start_transfer failure quirk
usb: dwc3: Add workaround for isoc start transfer failure
usb: dwc3: Check controller type before setting speed
usb: gadget: mass_storage: Set max_speed to SSP
Documentation/devicetree/bindings/usb/dwc3.txt | 7 +
drivers/usb/core/urb.c | 8 +
drivers/usb/dwc3/core.c | 72 ++++++++-
drivers/usb/dwc3/core.h | 53 +++++++
drivers/usb/dwc3/debugfs.c | 5 +
drivers/usb/dwc3/gadget.c | 205 ++++++++++++++++++++++++-
drivers/usb/gadget/legacy/mass_storage.c | 2 +-
7 files changed, 342 insertions(+), 10 deletions(-)
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 08/15] usb: dwc3: Make TX/RX threshold configurable
[not found] ` <cover.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
@ 2018-01-18 1:57 ` Thinh Nguyen
[not found] ` <4afe5640926fac3698abb323cb7be01f32b30ab7.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-18 1:58 ` [PATCH v3 12/15] usb: dwc3: Add disabling of start_transfer failure quirk Thinh Nguyen
1 sibling, 1 reply; 5+ messages in thread
From: Thinh Nguyen @ 2018-01-18 1:57 UTC (permalink / raw)
To: Felipe Balbi, Thinh Nguyen, linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Mark Rutland
Cc: John Youn
DWC_usb31 periodic transfer at 48K+ bytes per interval may need
modification to the TX/RX packet threshold to achieve optimal result.
Add properties to make it configurable.
Cc: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Signed-off-by: Thinh Nguyen <thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
---
Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index 52fb41046b34..a532fa6bf884 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -55,6 +55,10 @@ Optional properties:
- snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ
register for post-silicon frame length adjustment when the
fladj_30mhz_sdbnd signal is invalid or incorrect.
+ - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count.
+ - snps,rx-max-burst-prd: Max periodic ESS RX burst size.
+ - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count.
+ - snps,tx-max-burst-prd: Max periodic ESS TX burst size.
- <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 12/15] usb: dwc3: Add disabling of start_transfer failure quirk
[not found] ` <cover.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-18 1:57 ` [PATCH v3 08/15] usb: dwc3: Make TX/RX threshold configurable Thinh Nguyen
@ 2018-01-18 1:58 ` Thinh Nguyen
1 sibling, 0 replies; 5+ messages in thread
From: Thinh Nguyen @ 2018-01-18 1:58 UTC (permalink / raw)
To: Felipe Balbi, Thinh Nguyen, linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Mark Rutland
Cc: John Youn
In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc
START TRANSFER command failure. However, some affected versions may have
RTL patches to fix this without a SW workaround. Add this quirk to
disable the SW workaround when it is not needed.
Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
endpoints.
Cc: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Signed-off-by: Thinh Nguyen <thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
---
Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index a532fa6bf884..db53d8506084 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -15,6 +15,9 @@ Optional properties:
- phys: from the *Generic PHY* bindings
- phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy"
or "usb3-phy".
+ - snps,dis-start-transfer-quirk: when set, disable isoc START TRANSFER command
+ failure SW work-around for DWC_usb31 version 1.70a-ea06
+ and prior.
- snps,usb3_lpm_capable: determines if platform is USB3 LPM capable
- snps,disable_scramble_quirk: true when SW should disable data scrambling.
Only really useful for FPGA builds.
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 08/15] usb: dwc3: Make TX/RX threshold configurable
[not found] ` <4afe5640926fac3698abb323cb7be01f32b30ab7.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
@ 2018-01-29 18:46 ` Rob Herring
2018-01-29 20:08 ` Thinh Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-01-29 18:46 UTC (permalink / raw)
To: Thinh Nguyen
Cc: Felipe Balbi, linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Mark Rutland, John Youn
On Wed, Jan 17, 2018 at 05:57:15PM -0800, Thinh Nguyen wrote:
> DWC_usb31 periodic transfer at 48K+ bytes per interval may need
> modification to the TX/RX packet threshold to achieve optimal result.
> Add properties to make it configurable.
>
> Cc: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Thinh Nguyen <thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 52fb41046b34..a532fa6bf884 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -55,6 +55,10 @@ Optional properties:
> - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ
> register for post-silicon frame length adjustment when the
> fladj_30mhz_sdbnd signal is invalid or incorrect.
> + - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count.
> + - snps,rx-max-burst-prd: Max periodic ESS RX burst size.
> + - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count.
> + - snps,tx-max-burst-prd: Max periodic ESS TX burst size.
What are the defaults if not set?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 08/15] usb: dwc3: Make TX/RX threshold configurable
2018-01-29 18:46 ` Rob Herring
@ 2018-01-29 20:08 ` Thinh Nguyen
0 siblings, 0 replies; 5+ messages in thread
From: Thinh Nguyen @ 2018-01-29 20:08 UTC (permalink / raw)
To: Rob Herring, Thinh Nguyen
Cc: Felipe Balbi, linux-usb-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Mark Rutland, John Youn
Hi,
On 1/29/2018 10:46 AM, Rob Herring wrote:
> On Wed, Jan 17, 2018 at 05:57:15PM -0800, Thinh Nguyen wrote:
>> DWC_usb31 periodic transfer at 48K+ bytes per interval may need
>> modification to the TX/RX packet threshold to achieve optimal result.
>> Add properties to make it configurable.
>>
>> Cc: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Thinh Nguyen <thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
>> ---
>> Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
>> index 52fb41046b34..a532fa6bf884 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
>> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
>> @@ -55,6 +55,10 @@ Optional properties:
>> - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ
>> register for post-silicon frame length adjustment when the
>> fladj_30mhz_sdbnd signal is invalid or incorrect.
>> + - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count.
>> + - snps,rx-max-burst-prd: Max periodic ESS RX burst size.
>> + - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count.
>> + - snps,tx-max-burst-prd: Max periodic ESS TX burst size.
>
> What are the defaults if not set?
>
By default, periodic ESS TX and RX threshold are not enabled. To enable
TX or RX threshold, both packet threshold count and max burst size must
be set to a non-zero value.
Unfortunately, I did not document it in this file after I made a change
to remove the enabling of TX/RX threshold property. I can update this
patch series with this information. Thanks.
BR,
Thinh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-29 20:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 1:51 [PATCH v3 00/15] usb: dwc3: Add new updates for DWC_usb31 Thinh Nguyen
[not found] ` <cover.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-18 1:57 ` [PATCH v3 08/15] usb: dwc3: Make TX/RX threshold configurable Thinh Nguyen
[not found] ` <4afe5640926fac3698abb323cb7be01f32b30ab7.1516239813.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-29 18:46 ` Rob Herring
2018-01-29 20:08 ` Thinh Nguyen
2018-01-18 1:58 ` [PATCH v3 12/15] usb: dwc3: Add disabling of start_transfer failure quirk Thinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).