From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B40B8C3F68F for ; Thu, 26 Dec 2019 05:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80A2A2080D for ; Thu, 26 Dec 2019 05:56:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DMm+e+Pb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726127AbfLZF4e (ORCPT ); Thu, 26 Dec 2019 00:56:34 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:64394 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfLZF4e (ORCPT ); Thu, 26 Dec 2019 00:56:34 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577339793; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=OBzp2vx5t+U+RC6FagxULdtyTXd6+xbZUL8IMXMmGv8=; b=DMm+e+PbrqALUAGEBs+o5IaBm8G792K8BNz6mrxqDNp/W4vbYGpO8iS/gYBU8K+srnkkj/dL OdJ4ml308ETNo+tMZh3y54NXtK4uUbnk0qpZFl4cnR5V014smHy1hLlHQ9KeVtO8YefVkaWa pN7NDkQUfbdl+IlFge3pvUPRQjU= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e044b91.7f315a318688-smtp-out-n03; Thu, 26 Dec 2019 05:56:33 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CB968C4479D; Thu, 26 Dec 2019 05:56:31 +0000 (UTC) Received: from [10.206.25.219] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sanm) by smtp.codeaurora.org (Postfix) with ESMTPSA id 969F9C43383; Thu, 26 Dec 2019 05:56:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 969F9C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=sanm@codeaurora.org Subject: Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Felipe Balbi , Stephen Boyd , linux-arm-msm , linux-usb@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Manu Gautam References: <1576474742-23409-1-git-send-email-sanm@codeaurora.org> <1576474742-23409-2-git-send-email-sanm@codeaurora.org> From: "Sandeep Maheswaram (Temp)" Message-ID: Date: Thu, 26 Dec 2019 11:26:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi On 12/18/2019 12:44 AM, Doug Anderson wrote: > Hi, > > On Sun, Dec 15, 2019 at 9:40 PM Sandeep Maheswaram wrote: >> >> >> + items: >> + - description: System Config NOC clock. Not present on "qcom,msm8996-dwc3" compatible. >> + - description: Master/Core clock, have to be >= 125 MHz for SS operation and >= 60MHz for HS operation > To make the grammer gooder, s/have/has/ > > >> + - description: System bus AXI clock. Not present on "qcom,msm8996-dwc3" compatible. >> + - description: Mock utmi clock needed for ITP/SOF generation in host mode.Its frequency should be 19.2MHz. >> + - description: Sleep clock, used for wakeup when USB3 core goes into low power mode (U3). > * Please word wrap to ~80 chracters. > * As Stephen says, order matters. Please match order of old bindings > (and in clock-names) > * Please end each with a period. Regarding the order of clocks, If I change the order  I am facing error in make dtbs_check linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@a6f8800: clock-names:0: 'core' was expected linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@a6f8800: clock-names:1: 'mock_utmi' was expected linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@a6f8800: clock-names:2: 'sleep' was expected linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@a6f8800: clock-names:3: 'cfg_noc' was expected linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@a6f8800: clock-names:4: 'iface' was expected Need to modify in the sc7180.dtsi and sdm845.dtsi  to avoid the error  . Please let me know how to proceed. > > >> + clock-names: >> + minItems: 3 >> + items: >> + - const: cfg_noc >> + - const: core >> + - const: iface >> + - const: mock_utmi >> + - const: sleep >> + >> > -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation