From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Claudiu.Beznea@microchip.com, robh+dt@kernel.org,
mark.rutland@arm.com, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com,
tglx@linutronix.de
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support
Date: Tue, 10 Dec 2019 12:51:08 +0100 [thread overview]
Message-ID: <d104a0d3-950d-3132-4bf8-d06ccb7c6f25@linaro.org> (raw)
In-Reply-To: <3e49256f-9452-cede-5fa8-443c15857e1b@microchip.com>
On 10/12/2019 12:43, Claudiu.Beznea@microchip.com wrote:
>
>
> On 09.12.2019 19:04, Daniel Lezcano wrote:
>> On 04/12/2019 15:42, Claudiu Beznea wrote:
>>> Add driver for Microchip PIT64B timer. Timer could be used in continuous
>>> mode or oneshot mode. The hardware has 2x32 bit registers for period
>>> emulating a 64 bit timer. The LSB_PR and MSB_PR registers are used to
>>> set the period value (compare value). TLSB and TMSB keeps the current
>>> value of the counter. After a compare the TLSB and TMSB register resets.
>>> The driver uses PIT64B timer for clocksource or clockevent. First
>>> requested timer would be registered as clockevent, second one would be
>>> registered as clocksource. Individual PIT64B hardware resources were used
>>> for clocksource and clockevent to be able to support high resolution
>>> timers with this hardware implementation.
>>>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>>> ---
[ ... ]
>> Also, the 'high' part change may be checked, like:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/drivers/clocksource/timer-imx-sysctr.c?h=bleeding-edge#n51
>
> The IP guarantees that the reading of counter is atomic if
> MCHP_PIT64B_TLSBR is read first. With this, would you still want to add the
> check you mention above?
No, sorry I should have read the comment :/
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2019-12-10 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 14:42 [PATCH v3 0/2] add Microchip PIT64B timer Claudiu Beznea
2019-12-04 14:42 ` [PATCH v3 1/2] dt-bindings: arm: atmel: add bindings for PIT64B Claudiu Beznea
2019-12-04 14:42 ` [PATCH v3 2/2] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support Claudiu Beznea
2019-12-09 17:04 ` Daniel Lezcano
2019-12-10 11:43 ` Claudiu.Beznea
2019-12-10 11:51 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d104a0d3-950d-3132-4bf8-d06ccb7c6f25@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).