From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2BEC4742C for ; Tue, 10 Nov 2020 22:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36A5820781 for ; Tue, 10 Nov 2020 22:53:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MUDOBG08" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732168AbgKJWxC (ORCPT ); Tue, 10 Nov 2020 17:53:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730254AbgKJWxC (ORCPT ); Tue, 10 Nov 2020 17:53:02 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FF32C0613D1; Tue, 10 Nov 2020 14:53:02 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id s2so1016137plr.9; Tue, 10 Nov 2020 14:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZmvMxu6FYct1bFT3DYxE4BnG0fwWxsbRm1OndcvTrnA=; b=MUDOBG08gM/XIzxTpJ2/X9JNBLDIOJLomHaHeOe3E0atWr7O21L707iaH42+1PGyxs t2C9m29amMtw0XvFqOgD7m/6gnj9BwWDWMU5fQj7aKz/kD4LMZUWEMUCAxEL6dzZ2ebC QZPEdOASr3cQHf0yTO21FHyOL5nF4J4+jHTSvEnCu4wKcoRbr/L3qcaGmHpiJ/AA+Uhg 4wiupdx/O8023kcy35hOgxsXgi1Vv/+dL9AzwSgPk+vd+vfcDPieXulPeIp1/fjkuL64 z3loKR7LoyHhcrf1KKBNcwMqiFkMEaXQR9Ztai9Up4zdE8QgusGSTKnoI6XDKB5aF5/d q3Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZmvMxu6FYct1bFT3DYxE4BnG0fwWxsbRm1OndcvTrnA=; b=XXQjYUctXUiftaLpINsVmixax9vkILQIBBUcXRACnQFYvX3XkL1eioYFM4VwjDT1b3 A3FySppn44diR6tgT5fgJFl2hVidAXYdDcCXOAywolnz+pntjmzp6XKmAXKWBk7Pp8Sp lirbkhjV80wS6LfxKauqSizG9kx9KYVNrJebs/96RL0pCsK7xgFF83bB/vZZZYJC91Fb Hu215bh6+i7kWSjDgfiRyNs4Yu7LK5qHP6um6068Fsdzpl0r73Jm8DDBe9NIByQRu58d Mz7DnYgK5crug9ISUJuoWkJm6km/Hu3w1LtHZvnJrvfPx8pzHYU5dKitfPtSK1DudtLg KJqQ== X-Gm-Message-State: AOAM533gFBTWNB1NDsD1Z6SKFNjJc7q05YV9vss3jMb56pVOjRjX3QFg c2kRM8hfk4JNqIJvPqD0PIc= X-Google-Smtp-Source: ABdhPJyPhQmnv7YiTYaGgYr6ulz9t/76wGTy47FWtIxwj8/A4psTqw8VX7qudArAJn/3tgn/ufPIKQ== X-Received: by 2002:a17:902:7c12:b029:d6:ed57:fe13 with SMTP id x18-20020a1709027c12b02900d6ed57fe13mr18193835pll.59.1605048781491; Tue, 10 Nov 2020 14:53:01 -0800 (PST) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q11sm33646pgm.79.2020.11.10.14.52.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 14:53:00 -0800 (PST) Subject: Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node To: Vladimir Oltean Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Rob Herring , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , Kurt Kanzenbach References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-9-f.fainelli@gmail.com> <20201110223709.vca534wynwgfkz77@skbuf> <20201110224820.gbz3tcl6lzjbe3zo@skbuf> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 10 Nov 2020 14:52:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201110224820.gbz3tcl6lzjbe3zo@skbuf> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/10/20 2:48 PM, Vladimir Oltean wrote: > On Tue, Nov 10, 2020 at 02:40:43PM -0800, Florian Fainelli wrote: >> On 11/10/20 2:37 PM, Vladimir Oltean wrote: >>> On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote: >>>> Provide a default compatible string which is based on the 58522 SRAB >>>> compatible, this allows us to have sane defaults and silences the >>>> following warnings: >>>> >>>> arch/arm/boot/dts/bcm958522er.dt.yaml: >>>> ethernet-switch@36000: compatible: 'oneOf' conditional failed, >>>> one >>>> must be fixed: >>>> ['brcm,bcm5301x-srab'] is too short >>>> 'brcm,bcm5325' was expected >>>> 'brcm,bcm53115' was expected >>>> 'brcm,bcm53125' was expected >>>> 'brcm,bcm53128' was expected >>>> 'brcm,bcm5365' was expected >>>> 'brcm,bcm5395' was expected >>>> 'brcm,bcm5389' was expected >>>> 'brcm,bcm5397' was expected >>>> 'brcm,bcm5398' was expected >>>> 'brcm,bcm11360-srab' was expected >>>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', >>>> 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', >>>> 'brcm,bcm53019-srab'] >>>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', >>>> 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', >>>> 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] >>>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', >>>> 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', >>>> 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] >>>> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', >>>> 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] >>>> From schema: >>>> Documentation/devicetree/bindings/net/dsa/b53.yaml >>>> >>>> Signed-off-by: Florian Fainelli >>>> --- >>>> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi >>>> index 09fd7e55c069..8453865d1439 100644 >>>> --- a/arch/arm/boot/dts/bcm-nsp.dtsi >>>> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi >>>> @@ -386,7 +386,7 @@ ccbtimer1: timer@35000 { >>>> }; >>>> >>>> srab: ethernet-switch@36000 { >>>> - compatible = "brcm,nsp-srab"; >>>> + compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; >>>> reg = <0x36000 0x1000>, >>>> <0x3f308 0x8>, >>>> <0x3f410 0xc>; >>>> -- >>>> 2.25.1 >>>> >>> >>> I am not getting this. >>> The line: >>> #include "bcm-nsp.dtsi" >>> >>> can be found in: >>> >>> arch/arm/boot/dts/bcm988312hr.dts >>> arch/arm/boot/dts/bcm958625hr.dts >>> arch/arm/boot/dts/bcm958622hr.dts >>> arch/arm/boot/dts/bcm958625k.dts >>> arch/arm/boot/dts/bcm958522er.dts >>> arch/arm/boot/dts/bcm958525er.dts >>> arch/arm/boot/dts/bcm958623hr.dts >>> arch/arm/boot/dts/bcm958525xmc.dts >>> >>> >>> The pattern for the other DTS files that include this seems to be to >>> overwrite the compatible locally in bcm958522er.dts, like this: >>> >>> &srab { >>> compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; >>> }; >>> >>> Is there a reason why you are choosing to put an SoC specific compatible >>> in the common bcm-nsp.dtsi? >> >> It is necessary to silence the warnings provided in the commit message >> even when the srab node is disabled, since the dt_binding_check rule >> will check all of the nodes matching the pattern. If there is a better >> way to do this, I would gladly do it differently. >> -- >> Florian > > I am still not getting it. The exact 3 lines from above will not change > the "status" property from "disabled" to "okay", so I don't understand > why it matters whether it's enabled or not. The dt_binding_check error > isn't in the DTSI, it's in bcm958522er.dts. All that needs to be done is > that the bcm958522er.dts needs to override the compatible from the DTSI > and only the compatible, I believe. With no occurrence of an incomplete > list of compatibles in any final DTS, the dt_binding_check should not > complain about that single occurrence in the DTSI as far as I know (and > I did not test this). There is not a switch being enabled in arch/arm/boot/dts/bcm958522er.dts, so sure, I could add the 3 lines you quote above and that would silence the warning, but that does not scale at all across DTS files including bcm5301x.dtsi for instance, it sort of does for those including bcm-nsp.dtsi. -- Florian