Re: [PATCH v7 16/20] arm64: tegra: Enable wake from deep sleep on RTC alarm

From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
	linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org,
	linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
	jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v7 16/20] arm64: tegra: Enable wake from deep sleep on RTC alarm
Date: Wed, 31 Jul 2019 14:08:38 -0700	[thread overview]
Message-ID: <d4709085-f705-2608-08a8-65b238ae8844@nvidia.com> (raw)
In-Reply-To: <1233ad49-22eb-a90a-d7cf-5fe133ded177@gmail.com>


On 7/31/19 4:04 AM, Dmitry Osipenko wrote:
> 31.07.2019 3:20, Sowjanya Komatineni пишет:
>> This patch updates device tree for RTC and PMC to allow system wake
>> from deep sleep on RTC alarm.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra210.dtsi | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>> index 659753118e96..30a7c48385a2 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>> @@ -768,7 +768,8 @@
>>   	rtc@7000e000 {
>>   		compatible = "nvidia,tegra210-rtc", "nvidia,tegra20-rtc";
>>   		reg = <0x0 0x7000e000 0x0 0x100>;
>> -		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
>> +		interrupts = <16 IRQ_TYPE_LEVEL_HIGH>;
>> +		interrupt-parent = <&pmc>;
>>   		clocks = <&tegra_car TEGRA210_CLK_RTC>;
>>   		clock-names = "rtc";
>>   	};
>> @@ -778,6 +779,8 @@
>>   		reg = <0x0 0x7000e400 0x0 0x400>;
>>   		clocks = <&tegra_car TEGRA210_CLK_PCLK>, <&clk32k_in>;
>>   		clock-names = "pclk", "clk32k_in";
>> +		#interrupt-cells = <2>;
>> +		interrupt-controller;
>>   
>>   		powergates {
>>   			pd_audio: aud {
>>
> Is this a backwards-compatible change? Or it's not really worth to care
> about the compatibility with older kernel versions, I'm not sure about
> overall state of T210 in the upstream kernel.
I don't think its required to be backwards-compatible as SC7 entry/exit 
implementation for T210 is with this patch series onwards..