From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"sbkim73@samsung.com" <sbkim73@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"wens@csie.org" <wens@csie.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rf@opensource.cirrus.com" <rf@opensource.cirrus.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"tony@atomide.com" <tony@atomide.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
"krzk@kernel.org" <krzk@kernel.org>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"Mutanen, Mikko" <Mikko.Mutanen@fi.rohmeurope.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"milo.kim@ti.com" <milo.kim@ti.com>,
"agross@kernel.org" <agross@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Laine, Markus" <Markus.Laine@fi.rohmeurope.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"sre@kernel.org" <sre@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"andrei.stefanescu@microchip.com"
<andrei.stefanescu@microchip.com>,
"support.opensource@diasemi.com" <support.opensource@diasemi.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC PATCH v3 4/8] regulator: rename regulator_linear_range to linear_range
Date: Mon, 24 Feb 2020 12:20:11 +0000 [thread overview]
Message-ID: <d66373944b9afa9e2387d7bf95deb9d997906396.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20200224115349.GD6215@sirena.org.uk>
Hello Mark,
On Mon, 2020-02-24 at 11:53 +0000, Mark Brown wrote:
> On Thu, Feb 20, 2020 at 09:36:10AM +0200, Matti Vaittinen wrote:
> > Rename the "regulator_linear_range" to more generic linear_range
> > as a first step towards converting the "regulator_linear_range"
> > to common helpers.
>
> Doesn't this introduce a build break when applied by itself? Patches
> should be bisectable, if you want to split things up you should
> introduce the new API then use it.
Uh, I need to double check but this shouldn't cause build break as only
the name of the struct is changed - and I intended to change it both in
regulator header and in all of the drivers using it at same time. Or
did I do some brainfart here?
I just wanted to minimize the changes in patch with the widest
audience.
Oh, after rebasing to linux 5.6-rc2 I see that there are few new users
of regulator_linear_range (I should have known that...) - natuarlly all
of the users need to be covered before applying this.
Br,
Matti Vaittinen
next prev parent reply other threads:[~2020-02-24 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 7:33 [RFC PATCH v3 0/8] Support ROHM BD99954 charger IC Matti Vaittinen
2020-02-20 7:34 ` [RFC PATCH v3 1/8] dt-bindings: battry: add new battery parameters Matti Vaittinen
2020-02-20 7:35 ` [RFC PATCH v3 2/8] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-02-20 20:34 ` Rob Herring
2020-02-20 7:35 ` [RFC PATCH v3 3/8] drivers: base: add linear ranges helpers Matti Vaittinen
2020-02-20 7:47 ` Randy Dunlap
2020-02-20 8:34 ` Vaittinen, Matti
2020-02-20 7:36 ` [RFC PATCH v3 4/8] regulator: rename regulator_linear_range to linear_range Matti Vaittinen
2020-02-24 11:53 ` Mark Brown
2020-02-24 12:20 ` Vaittinen, Matti [this message]
2020-02-20 7:36 ` [RFC PATCH v3 5/8] regulator: use linear_ranges helper Matti Vaittinen
2020-02-24 11:57 ` Mark Brown
2020-02-25 6:23 ` Vaittinen, Matti
2020-02-25 15:33 ` Mark Brown
2020-03-03 8:04 ` Vaittinen, Matti
2020-02-20 7:37 ` [RFC PATCH v3 6/8] power: supply: bd70528: use linear ranges Matti Vaittinen
2020-02-20 7:37 ` [RFC PATCH v3 7/8] power: supply: add battery parameters Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66373944b9afa9e2387d7bf95deb9d997906396.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=Markus.Laine@fi.rohmeurope.com \
--cc=Mikko.Mutanen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=andrei.stefanescu@microchip.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=milo.kim@ti.com \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=sbkim73@samsung.com \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).