From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Zev Weiss" <zev@bewilderbeest.net>, "Joel Stanley" <joel@jms.id.au>
Cc: openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Lubomir Rintel" <lkundrak@v3.sk>, - <devicetree@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed,sirq-active-high
Date: Thu, 01 Apr 2021 14:34:44 +1030 [thread overview]
Message-ID: <d66753ee-7db2-41e5-9fe5-762b1ab678bc@www.fastmail.com> (raw)
In-Reply-To: <20210401005702.28271-4-zev@bewilderbeest.net>
On Thu, 1 Apr 2021, at 11:27, Zev Weiss wrote:
> This provides a simpler, more direct alternative to the deprecated
> aspeed,sirq-polarity-sense property for indicating the polarity of
> the Aspeed VUART's SIRQ line.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> Documentation/devicetree/bindings/serial/8250.yaml | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml
> b/Documentation/devicetree/bindings/serial/8250.yaml
> index 491b9297432d..e79bb6ab9d2c 100644
> --- a/Documentation/devicetree/bindings/serial/8250.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> @@ -12,8 +12,9 @@ maintainers:
> allOf:
> - $ref: /schemas/serial.yaml#
> - if:
> - required:
> - - aspeed,sirq-polarity-sense
> + anyOf:
> + - required: [ aspeed,sirq-active-high ]
Do you think we could make use of the approach I put forward here?
https://lore.kernel.org/openbmc/20210319062752.145730-18-andrew@aj.id.au/T/#u
Andrew
next prev parent reply other threads:[~2021-04-01 4:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210330002338.335-1-zev@bewilderbeest.net>
2021-03-30 0:23 ` [PATCH 2/3] dt-bindings: serial: 8250: update for aspeed,sirq-active-high Zev Weiss
2021-03-30 22:39 ` Rob Herring
2021-03-30 23:04 ` Zev Weiss
[not found] ` <20210401005702.28271-1-zev@bewilderbeest.net>
2021-04-01 0:57 ` [PATCH v2 1/3] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense Zev Weiss
2021-04-01 3:53 ` Joel Stanley
2021-04-01 0:57 ` [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed,sirq-active-high Zev Weiss
2021-04-01 4:04 ` Andrew Jeffery [this message]
2021-04-01 4:57 ` Zev Weiss
2021-04-01 14:56 ` [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed, sirq-active-high Rob Herring
2021-03-30 23:26 ` [PATCH 2/3] dt-bindings: serial: 8250: update for aspeed,sirq-active-high Joel Stanley
2021-03-30 0:23 ` [PATCH 3/3] ARM: dts: aspeed: add ASRock E3C246D4I BMC Zev Weiss
2021-03-31 7:41 ` Joel Stanley
2021-03-31 7:43 ` Joel Stanley
2021-03-31 7:50 ` Joel Stanley
2021-04-01 2:51 ` [PATCH] " Zev Weiss
2021-04-01 3:51 ` Joel Stanley
2021-04-01 4:09 ` Zev Weiss
2021-04-01 0:04 ` [PATCH 3/3] " Andrew Jeffery
2021-04-01 0:26 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66753ee-7db2-41e5-9fe5-762b1ab678bc@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).