Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

From: Hans Verkuil <hverkuil@xs4all.nl>
To: Shunqian Zheng <zhengsq@rock-chips.com>,
	linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, hans.verkuil@cisco.com,
	tfiga@chromium.org, laurent.pinchart@ideasonboard.com,
	zyc@rock-chips.com, eddie.cai.linux@gmail.com,
	jeffy.chen@rock-chips.com, allon.huang@rock-chips.com,
	devicetree@vger.kernel.org, heiko@sntech.de, robh+dt@kernel.org,
	Joao.Pinto@synopsys.com, Luis.Oliveira@synopsys.com,
	Jose.Abreu@synopsys.com, jacob2.chen@rock-chips.com
Subject: Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions
Date: Wed, 7 Feb 2018 17:31:34 +0100	[thread overview]
Message-ID: <d98ac356-a482-f26f-fd6b-6142281d99c3@xs4all.nl> (raw)
In-Reply-To: <1514533978-20408-4-git-send-email-zhengsq@rock-chips.com>

On 12/29/2017 08:52 AM, Shunqian Zheng wrote:
> From: Jeffy Chen <jeffy.chen@rock-chips.com>
> 
> Add the header for userspace
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
> ---
>  include/uapi/linux/rkisp1-config.h | 757 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 757 insertions(+)
>  create mode 100644 include/uapi/linux/rkisp1-config.h
> 
> diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
> new file mode 100644
> index 0000000..0f9f4226
> --- /dev/null
> +++ b/include/uapi/linux/rkisp1-config.h
> @@ -0,0 +1,757 @@

<snip>

> +/**
> + * enum cifisp_exp_ctrl_auotostop - stop modes

auotostop -> autostop

> + * @CIFISP_EXP_CTRL_AUTOSTOP_0: continous measurement

continous -> continuous

> + * @CIFISP_EXP_CTRL_AUTOSTOP_1: stop measuring after a complete frame
> + */
> +enum cifisp_exp_ctrl_auotostop {

auotostop -> autostop

> +	CIFISP_EXP_CTRL_AUTOSTOP_0 = 0,
> +	CIFISP_EXP_CTRL_AUTOSTOP_1 = 1,
> +};

Just noticed this :-)

Regards,

	Hans