From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729B6C4338F for ; Tue, 17 Aug 2021 14:07:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5212360F11 for ; Tue, 17 Aug 2021 14:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237090AbhHQOH7 (ORCPT ); Tue, 17 Aug 2021 10:07:59 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:38810 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbhHQOH7 (ORCPT ); Tue, 17 Aug 2021 10:07:59 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 03A753F110 for ; Tue, 17 Aug 2021 14:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629209245; bh=jfQmfS4UcdDZ/PX6E9b//KKI404jw/6q3qCv8x9JyfM=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Os4mdLh+71ZiNH656PyVcYAj/sImwgdt8cKsITw3VPzyDo7RK4Gqgk0vNRL9rRqL2 xEjw3jdIg5jNsF80yLNMLDkXZ/9YtRPTjs0WfGT0/MOSc855orxNT43A1nTmn4Zesz k1eNQYtoKAuTD1/g+jXT+TyvOmKvwS2+4tWtFOzz3Vd51qk9Mv91FppeN881CZz0vB b95SkH7DkHQMYC63yvcNVkM5h59pYxfM5tTcRwA2GOldHkOl2mSPKsXFksCJD6MU8T O5MOvjZtMPitBIoFw5sZafBsxnfSkKUTqB1xfT/66yxbHQkMZ/2OzJJ3tc4uHxb/Pk s2qzHfX4zPEqg== Received: by mail-ej1-f69.google.com with SMTP id nb40-20020a1709071ca8b02905992266c319so6033077ejc.21 for ; Tue, 17 Aug 2021 07:07:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jfQmfS4UcdDZ/PX6E9b//KKI404jw/6q3qCv8x9JyfM=; b=eH6YvsMKj02NqsxWofJjauB+PVlQo5mep90XjG1/FZmxk5vnIi8zTEvQZeL/2P3vrh BJLxjCLMa3ExzQsUKFKOJ2L5W2TYAM8h7zF5TeY1n+s5epVmfynhv5a96IpI2VvYbIkv jWC2fcDNEhEfnfQ2iQ18+9hUp93X/x1W6fGUsZRPqPFwMZ6GlOloKPgWZnouFW9rvpV+ tT8/K/1o+VT8a3hotdMiFz18WkCSozOFFkX4xcFRQoKTkO3yFqqag2L5R1n8RW9KGX8S xFeLRNp/RkBi6vuzMQnLMciyk8bpPZ9AO/gKAxE9JS53wiIos16LTbQFW8WMl7lzBpaQ 8uuQ== X-Gm-Message-State: AOAM532AKHYu9Sdmf2enBigPttCYDPIFO8c5fPrtmLdTBc4pz3CK4e8G yiOR8WEtvvevTJh7OCPW1CnAOfINbEqDZx2bJlgXNEpp7reHOV917vFOoNPPyoaEOWkkQPHI9Rm BM6MRIZCpH2qMl7Lc39aLzHkIOElJIH+tMNrd2+o= X-Received: by 2002:a05:6402:35c9:: with SMTP id z9mr4369310edc.249.1629209243910; Tue, 17 Aug 2021 07:07:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyszAFp2YNN5KP+dS332IXz7EIzwQDE7qq9Fr9F3rL6OyeZKaqCv4G6V53FVjOklm6MHgpHCA== X-Received: by 2002:a05:6402:35c9:: with SMTP id z9mr4369292edc.249.1629209243737; Tue, 17 Aug 2021 07:07:23 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id m6sm1049328edc.82.2021.08.17.07.07.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 07:07:22 -0700 (PDT) Subject: Re: [PATCH 2/2] dt-bindings: rng: convert Samsung Exynos TRNG to dtschema To: Lukasz Stelmach Cc: Thomas Gleixner , Marc Zyngier , Rob Herring , Matt Mackall , Herbert Xu , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org References: From: Krzysztof Kozlowski Message-ID: Date: Tue, 17 Aug 2021 16:07:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/08/2021 14:34, Lukasz Stelmach wrote: > It was <2021-08-17 wto 12:05>, when Krzysztof Kozlowski wrote: >> On 17/08/2021 11:55, Lukasz Stelmach wrote: >>> It was <2021-08-11 śro 10:43>, when Krzysztof Kozlowski wrote: >>>> Convert Samsung Exynos SoC True Random Number Generator bindings to DT >>>> schema format using json-schema. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> .../bindings/rng/samsung,exynos5250-trng.txt | 17 ------- >>>> .../bindings/rng/samsung,exynos5250-trng.yaml | 44 +++++++++++++++++++ >>>> MAINTAINERS | 2 +- >>>> 3 files changed, 45 insertions(+), 18 deletions(-) >>>> delete mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >>>> create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >>>> b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >>>> deleted file mode 100644 >>>> index 5a613a4ec780..000000000000 >>>> --- a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt >>>> +++ /dev/null >>>> @@ -1,17 +0,0 @@ >>>> -Exynos True Random Number Generator >>>> - >>>> -Required properties: >>>> - >>>> -- compatible : Should be "samsung,exynos5250-trng". >>>> -- reg : Specifies base physical address and size of the registers map. >>>> -- clocks : Phandle to clock-controller plus clock-specifier pair. >>>> -- clock-names : "secss" as a clock name. >>>> - >>>> -Example: >>>> - >>>> - rng@10830600 { >>>> - compatible = "samsung,exynos5250-trng"; >>>> - reg = <0x10830600 0x100>; >>>> - clocks = <&clock CLK_SSS>; >>>> - clock-names = "secss"; >>>> - }; >>>> diff --git >>>> a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >>>> b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >>>> new file mode 100644 >>>> index 000000000000..a50c34d5d199 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.yaml >>>> @@ -0,0 +1,44 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: >>>> https://protect2.fireeye.com/v1/url?k=f38ca35b-ac179a0d-f38d2814-0cc47a31ce52-1faa1ecb65482b8a&q=1&e=8b3490f9-a5fc-4da0-b2ee-7b0aec781403&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Frng%2Fsamsung%2Cexynos5250-trng.yaml%23 >>>> +$schema: >>>> https://protect2.fireeye.com/v1/url?k=9409519d-cb9268cb-9408dad2-0cc47a31ce52-12394c4409905980&q=1&e=8b3490f9-a5fc-4da0-b2ee-7b0aec781403&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >>>> + >>>> +title: Samsung Exynos SoC True Random Number Generator >>>> + >>>> +maintainers: >>>> + - Krzysztof Kozlowski >>>> + - Łukasz Stelmach >>>> + >>>> +properties: >>>> + compatible: >>>> + const: samsung,exynos5250-trng >>>> + >>>> + clocks: >>>> + maxItems: 1 >>> >>> How about copying description from above into the description: property? >> >> But what to copy? There is no description except generic clock bindings. >> > > The description that "was" in the txt file. But there was no description of fields except copy&paste of the core schema. Do you describe C code like: ... /* unsigned int is a integer number greater or equal 0 */ unsigned int i; ... Best regards, Krzysztof