From: Kever Yang <kever.yang@rock-chips.com>
To: Elaine Zhang <zhangqing@rock-chips.com>,
mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org,
heiko@sntech.de
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
cl@rock-chips.com, huangtao@rock-chips.com,
tony.xie@rock-chips.com, finley.xiao@rock-chips.com
Subject: Re: [PATCH v3 1/4] dt-binding: clock: Document rockchip,rk3568-cru bindings
Date: Fri, 5 Mar 2021 09:41:24 +0800 [thread overview]
Message-ID: <db38c068-651e-edd6-fb3f-4768fab91ad7@rock-chips.com> (raw)
In-Reply-To: <20210301064749.10392-2-zhangqing@rock-chips.com>
On 2021/3/1 下午2:47, Elaine Zhang wrote:
> Document the device tree bindings of the rockchip Rk3568 SoC
> clock driver in Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
Patch looks good to me.
Reviewed-by: Kever Yang <kever.yang@rock-chips.com
<mailto:kever.yang@rock-chips.com>>
Thanks,
- Kever
> ---
> .../bindings/clock/rockchip,rk3568-cru.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml b/Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml
> new file mode 100644
> index 000000000000..b2c26097827f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/rockchip,rk3568-cru.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROCKCHIP rk3568 Family Clock Control Module Binding
> +
> +maintainers:
> + - Elaine Zhang <zhangqing@rock-chips.com>
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +description: |
> + The RK3568 clock controller generates the clock and also implements a
> + reset controller for SoC peripherals.
> + (examples: provide SCLK_UART1\PCLK_UART1 and SRST_P_UART1\SRST_S_UART1 for UART module)
> + Each clock is assigned an identifier and client nodes can use this identifier
> + to specify the clock which they consume. All available clocks are defined as
> + preprocessor macros in the dt-bindings/clock/rk3568-cru.h headers and can be
> + used in device tree sources.
> +
> +properties:
> + compatible:
> + enum:
> + - rockchip,rk3568-cru
> + - rockchip,rk3568-pmucru
> +
> + reg:
> + maxItems: 1
> +
> + "#clock-cells":
> + const: 1
> +
> + "#reset-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - "#clock-cells"
> + - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + # Clock Control Module node:
> + - |
> + pmucru: clock-controller@fdd00000 {
> + compatible = "rockchip,rk3568-pmucru";
> + reg = <0xfdd00000 0x1000>;
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + };
> + - |
> + cru: clock-controller@fdd20000 {
> + compatible = "rockchip,rk3568-cru";
> + reg = <0xfdd20000 0x1000>;
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + };
next prev parent reply other threads:[~2021-03-05 1:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 6:47 [PATCH v3 0/4] clk: rockchip: add clock controller for rk3568 Elaine Zhang
2021-03-01 6:47 ` [PATCH v3 1/4] dt-binding: clock: Document rockchip,rk3568-cru bindings Elaine Zhang
2021-03-05 1:41 ` Kever Yang [this message]
2021-03-08 17:27 ` [PATCH v3 1/4] dt-binding: clock: Document rockchip, rk3568-cru bindings Rob Herring
2021-03-01 6:47 ` [PATCH v3 2/4] clk: rockchip: add dt-binding header for rk3568 Elaine Zhang
2021-03-05 2:14 ` Kever Yang
2021-03-08 17:28 ` Rob Herring
2021-03-01 6:47 ` [PATCH v3 3/4] clk: rockchip: support more core div setting Elaine Zhang
2021-03-05 2:14 ` Kever Yang
2021-03-01 6:47 ` [PATCH v3 4/4] clk: rockchip: add clock controller for rk3568 Elaine Zhang
2021-03-05 2:14 ` Kever Yang
2021-03-13 22:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db38c068-651e-edd6-fb3f-4768fab91ad7@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).