From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01FAC4741F for ; Mon, 9 Nov 2020 14:01:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8916520789 for ; Mon, 9 Nov 2020 14:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mxc0HTmP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbgKIOBG (ORCPT ); Mon, 9 Nov 2020 09:01:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54779 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730197AbgKIOBG (ORCPT ); Mon, 9 Nov 2020 09:01:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604930464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+UKQzgtuYMyW/SoLBP9eW/fTlDRQd3FvWyc619DNi0=; b=Mxc0HTmPx+jDks0rtd4SiVE94TRbBSH4mXVjEochVbj7lJsqruyCke5grBCy3f/evYJvHK /fCnVjve9ekcDv4X3G0K6lPtBGPuYa7cDXwESUJL2zhm6QisPo7/QKZvHoHgw8cnTkNsc0 h+8VH9zwlR16k4oXuFpZlk6bY2SGhLw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-H5VJxHOpNBq9rWLeF-911w-1; Mon, 09 Nov 2020 09:01:01 -0500 X-MC-Unique: H5VJxHOpNBq9rWLeF-911w-1 Received: by mail-ej1-f70.google.com with SMTP id o27so3423653eji.12 for ; Mon, 09 Nov 2020 06:01:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9+UKQzgtuYMyW/SoLBP9eW/fTlDRQd3FvWyc619DNi0=; b=sjTuwai3vkkbo9L1BmARD0kd0uyGaN4UEx7HREX8khlcIJ0xbW5bYhV4soBm2ki+In +qBh+kCM2hnhscCPuvDupM6ZaYc3eSwjdEnxtvVAtCLhjppUXd7nIDgl89AoROuzTb65 8PQntIa+UI27ibJwVRfLEi3d3dGCPXlrE+gaKJJJlblJbXb81QF5CkvHfaKlHCQRn7nU urha3rWFQLbVQcXM+YbJqkBMCtxbNhEIx6x0iYMVNZy+efSEFsg90GvUU5jXiENqwv8a qffDe8ZCYLqhfyDCTfxRo9GfdakxXbrBTVikdBor/T7aiEWbw660m2mHs8oF82ZOy7au MDDg== X-Gm-Message-State: AOAM533ryYhlCJiwy/Y9HPEXWWPVHJiM9nF1zpDo+B0vWmZPG+XI/Tle VBYXE4KNhtGTk7VgWrBcHs/JvzfwcJQ/KA2M+nhFylOx/5mK25o8gHVkGWJRoq/83l/EuBAE7Lw snIyE+65DjixCLdG9orm5BA== X-Received: by 2002:aa7:d599:: with SMTP id r25mr14877793edq.280.1604930459901; Mon, 09 Nov 2020 06:00:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfNo4nDfbngeabQIMVcUapycE4qgM2KZLqawKsUA5teTo9BtvSSvPibXOweDelEQCXirQs/w== X-Received: by 2002:aa7:d599:: with SMTP id r25mr14877784edq.280.1604930459724; Mon, 09 Nov 2020 06:00:59 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-6c10-fbf3-14c4-884c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:6c10:fbf3:14c4:884c]) by smtp.gmail.com with ESMTPSA id n12sm3949807ejs.19.2020.11.09.06.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 06:00:59 -0800 (PST) Subject: Re: [PATCH v2 3/9] ata: ahci: custom irq init for host init To: sven.auhagen@voleatech.de, axboe@kernel.dk, robh+dt@kernel.org, tglx@linutronix.de, maz@kernel.org, gregory.clement@bootlin.com Cc: linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, rjw@rjwysocki.net, viresh.kumar@linaro.org, antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com References: <20201104155237.77772-1-sven.auhagen@voleatech.de> <20201104155237.77772-4-sven.auhagen@voleatech.de> From: Hans de Goede Message-ID: Date: Mon, 9 Nov 2020 15:00:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201104155237.77772-4-sven.auhagen@voleatech.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 11/4/20 4:52 PM, sven.auhagen@voleatech.de wrote: > From: Sven Auhagen > > Disable the platform irq init in ahci init platform host > if it was initiated by a custom function. > To check for it I am using the AHCI_HFLAG_MULTI_MSI flag. > > Suggested-by: Hans de Goede > Signed-off-by: Sven Auhagen The code is fine here. But I'm not entirely happy with the commit message how about: """ ata: libahci_platform: Do not try to get an IRQ when AHCI_HFLAG_MULTI_MSI is set When the ahci-host AHCI_HFLAG_MULTI_MSI flag is set then the driver must provide a get_irq_vector callback and take care of getting the IRQs itself. So in this case ahci_platform_init_host() should not try to get an IRQ itself. """ With the commit message updated to the above (or something similar) you may add my: Reviewed-by: Hans de Goede I've also just given you my Reviewed-by for patch 4 and 5, and the result already has a Reviewed-by. So if you can sendout a v3 of this series with the commit message for this patch fixed, then it is ready for merging from my pov. Regards, Hans > --- > drivers/ata/libahci_platform.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c > index de638dafce21..f6f2a111d226 100644 > --- a/drivers/ata/libahci_platform.c > +++ b/drivers/ata/libahci_platform.c > @@ -581,14 +581,16 @@ int ahci_platform_init_host(struct platform_device *pdev, > struct ata_host *host; > int i, irq, n_ports, rc; > > - irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(dev, "no irq\n"); > - return irq; > - } > + if (!(hpriv->flags & AHCI_HFLAG_MULTI_MSI)) { > + irq = platform_get_irq(pdev, 0); > + if (irq <= 0) { > + if (irq != -EPROBE_DEFER) > + dev_err(dev, "no irq\n"); > + return irq; > + } > > - hpriv->irq = irq; > + hpriv->irq = irq; > + } > > /* prepare host */ > pi.private_data = (void *)(unsigned long)hpriv->flags; >