From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsi@lists.ozlabs.org, linux-spi@vger.kernel.org,
linux-i2c@vger.kernel.org, lakshmiy@us.ibm.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
andrew@codeconstruct.com.au
Subject: Re: [PATCH v3 12/14] ARM: dts: aspeed: Add IBM P11 FSI devices
Date: Fri, 26 Apr 2024 08:31:00 +0200 [thread overview]
Message-ID: <dc106aa2-8f69-4f71-ad9f-6dfb97c63a50@kernel.org> (raw)
In-Reply-To: <20240425213701.655540-13-eajames@linux.ibm.com>
On 25/04/2024 23:36, Eddie James wrote:
> Add the P11 FSI device tree for use in upcoming BMC systems.
> Unlike P10, there is no system with only two processors, so
> only the quad processor FSI layout is necessary.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 1696 +++++++++++++++++
> 1 file changed, 1696 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi
>
> diff --git a/arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi b/arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi
> new file mode 100644
> index 000000000000..c3a0ecf12aa0
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi
> @@ -0,0 +1,1696 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2024 IBM Corp.
> +
> +&fsim0 {
This does not make sense. You do not include any file here, so what do
you want to override?
How can you even test this file?
> + status = "okay";
> +
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_HIGH>;
> +
> +
> +&cfam3_i2c16 {
> + fsi-i2cr@20 {
> + compatible = "ibm,i2cr-fsi-master";
> + reg = <0x20>;
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + cfam@0,0 {
> + reg = <0 0>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + chip-id = <0>;
> +
> + scom416: scom@1000 {
> + compatible = "ibm,i2cr-scom";
> + reg = <0x1000 0x400>;
> + };
> +
> + sbefifo416: sbefifo@2400 {
> + compatible = "ibm,odyssey-sbefifo";
> + reg = <0x2400 0x400>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> + };
> +};
> +
> +&cfam3_i2c17 {
This looks randomly ordered.
> +&fsi_occ1 {
> + reg = <2>;
> +};
> +
> +&fsi_occ2 {
> + reg = <3>;
> +};
> +
> +&fsi_occ3 {
> + reg = <4>;
> +};
> +
> +/ {
Nope. Root node never goes to end of file. Look at all modern DTS.
> + aliases {
> + i2c100 = &cfam0_i2c0;
> + i2c101 = &cfam0_i2c1;
> + i2c110 = &cfam0_i2c10;
> + i2c111 = &cfam0_i2c11;
> + i2c112 = &cfam0_i2c12;
> + i2c113 = &cfam0_i2c13;
> + i2c114 = &cfam0_i2c14;
> + i2c115 = &cfam0_i2c15;
> + i2c202 = &cfam1_i2c2;
> + i2c203 = &cfam1_i2c3;
> + i2c210 = &cfam1_i2c10;
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-26 6:31 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:36 [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Eddie James
2024-04-25 21:36 ` [PATCH v3 01/14] dt-bindings: spi: Document the IBM Power SPI controller Eddie James
2024-04-25 23:39 ` Rob Herring
2024-04-26 6:15 ` Krzysztof Kozlowski
2024-04-26 14:49 ` Eddie James
2024-04-28 16:39 ` Krzysztof Kozlowski
2024-04-29 14:38 ` Eddie James
2024-04-29 18:17 ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 02/14] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-04-25 21:36 ` [PATCH v3 03/14] dt-bindings: fsi: Document the FSI2PIB engine Eddie James
2024-04-26 6:17 ` Krzysztof Kozlowski
2024-04-26 6:18 ` Krzysztof Kozlowski
2024-04-26 15:00 ` Eddie James
2024-04-28 16:41 ` Krzysztof Kozlowski
2024-04-29 14:42 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 04/14] dt-bindings: fsi: p9-occ: Switch to yaml format Eddie James
2024-04-26 6:19 ` Krzysztof Kozlowski
2024-04-26 15:05 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 05/14] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-26 6:20 ` Krzysztof Kozlowski
2024-04-26 15:09 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 06/14] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-04-25 23:40 ` Rob Herring
2024-04-26 6:23 ` Krzysztof Kozlowski
2024-04-26 15:11 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 07/14] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-04-25 21:36 ` [PATCH v3 08/14] dt-bindings: fsi: ast2600-fsi-master: Switch to yaml format Eddie James
2024-04-26 6:25 ` Krzysztof Kozlowski
2024-04-26 15:13 ` Eddie James
2024-04-26 18:43 ` Rob Herring
2024-04-25 21:36 ` [PATCH v3 09/14] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
2024-04-26 6:26 ` Krzysztof Kozlowski
2024-04-26 15:19 ` Eddie James
2024-04-28 16:43 ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 10/14] dt-bindings: i2c: i2c-fsi: Switch to yaml format Eddie James
2024-04-26 0:21 ` kernel test robot
2024-04-26 6:29 ` Krzysztof Kozlowski
2024-04-26 15:23 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 11/14] dt-bindings: arm: aspeed: add IBM P11 BMC boards Eddie James
2024-04-25 21:36 ` [PATCH v3 12/14] ARM: dts: aspeed: Add IBM P11 FSI devices Eddie James
2024-04-26 6:31 ` Krzysztof Kozlowski [this message]
2024-04-26 13:18 ` Eddie James
2024-04-28 16:39 ` Krzysztof Kozlowski
2024-04-25 21:37 ` [PATCH v3 13/14] ARM: dts: aspeed: Add IBM P11 Blueridge BMC system Eddie James
2024-04-26 6:35 ` Krzysztof Kozlowski
2024-04-26 13:22 ` Eddie James
2024-04-25 21:37 ` [PATCH v3 14/14] ARM: dts: aspeed: Add IBM P11 Fuji " Eddie James
2024-04-26 6:36 ` Krzysztof Kozlowski
2024-04-26 14:22 ` [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc106aa2-8f69-4f71-ad9f-6dfb97c63a50@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).