From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46258CCA473 for ; Thu, 9 Jun 2022 07:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235876AbiFIHT2 (ORCPT ); Thu, 9 Jun 2022 03:19:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238571AbiFIHT1 (ORCPT ); Thu, 9 Jun 2022 03:19:27 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132612432FD; Thu, 9 Jun 2022 00:19:25 -0700 (PDT) X-UUID: 89c5cc1d5e284946acc21aa84de72ca1-20220609 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:5edffd8c-77a7-4991-bb69-badb40d81d77,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:f59d38e5-2ba2-4dc1-b6c5-11feb6c769e0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 89c5cc1d5e284946acc21aa84de72ca1-20220609 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 931788558; Thu, 09 Jun 2022 15:19:21 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 9 Jun 2022 15:18:50 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 9 Jun 2022 15:18:49 +0800 Message-ID: Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: Rex-BC Chen To: CK Hu , Guillaume Ranquet , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , Helge Deller , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= CC: Markus Schneider-Pargmann , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-fbdev@vger.kernel.org" Date: Thu, 9 Jun 2022 15:18:49 +0800 In-Reply-To: <387fc4f9a65b87467fbff3878ad371bee4552e6e.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <387fc4f9a65b87467fbff3878ad371bee4552e6e.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 2022-06-07 at 16:01 +0800, CK Hu wrote: > Hi, Rex: > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > From: Markus Schneider-Pargmann > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > > > It supports the mt8195, the embedded DisplayPort units. It offers > > DisplayPort 1.4 with up to 4 lanes. > > > > The driver creates a child device for the phy. The child device > > will > > never exist without the parent being active. As they are sharing a > > register range, the parent passes a regmap pointer to the child so > > that > > both can work with the same register range. The phy driver sets > > device > > data that is read by the parent to get the phy device that can be > > used > > to control the phy properties. > > > > This driver is based on an initial version by > > Jason-JH.Lin . > > > > Signed-off-by: Markus Schneider-Pargmann > > Signed-off-by: Guillaume Ranquet > > --- > > [snip] > > > + > > +static void mtk_dp_state_handler(struct mtk_dp *mtk_dp) > > +{ > > + switch (mtk_dp->state) { > > Does mtk_dp->state has any relation with mtk_dp->train_state. If yes, > mix mtk_dp->state and mtk_dp->train_state into one state. If no, move > calling mtk_dp_state_handler() out of mtk_dp_train_handler(). > > Regards, > CK > Hello CK, OK, I will refine this flow. About the state machine of traning flow, we can review in v11. BRs, Bo-Chen > > + case MTK_DP_STATE_INITIAL: > > + mtk_dp_video_mute(mtk_dp, true); > > + mtk_dp->state = MTK_DP_STATE_IDLE; > > + break; > > + > > + case MTK_DP_STATE_IDLE: > > + if (mtk_dp->train_state == MTK_DP_TRAIN_STATE_NORMAL) > > + mtk_dp->state = MTK_DP_STATE_PREPARE; > > + break; > > + > > + case MTK_DP_STATE_PREPARE: > > + mtk_dp_video_config(mtk_dp); > > + mtk_dp_video_enable(mtk_dp, true); > > + > > + mtk_dp->state = MTK_DP_STATE_NORMAL; > > + break; > > + > > + case MTK_DP_STATE_NORMAL: > > + if (mtk_dp->train_state != MTK_DP_TRAIN_STATE_NORMAL) { > > + mtk_dp_video_mute(mtk_dp, true); > > + mtk_dp->state = MTK_DP_STATE_IDLE; > > + } > > + break; > > + > > + default: > > + break; > > + } > > +} > >