From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: CK Hu <ck.hu@mediatek.com>, matthias.bgg@kernel.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com, p.zabel@pengutronix.de,
airlied@linux.ie, mturquette@baylibre.com, sboyd@kernel.org,
ulrich.hecht+renesas@gmail.com,
laurent.pinchart@ideasonboard.com, sean.wang@mediatek.com,
sean.wang@kernel.org, rdunlap@infradead.org, wens@csie.org,
hsinyi@chromium.org, frank-w@public-files.de,
drinkcat@chromium.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, mbrugger@suse.com
Subject: Re: [resend PATCH v6 01/12] dt-bindings: display: mediatek: Add mmsys binding description
Date: Mon, 9 Dec 2019 09:48:17 +0100 [thread overview]
Message-ID: <dec02ff4-6627-2755-b05b-2ab0560feee7@collabora.com> (raw)
In-Reply-To: <1575868373.7013.4.camel@mtksdaap41>
Hi Matthias,
On 9/12/19 6:12, CK Hu wrote:
> Hi, Matthias:
>
> On Sat, 2019-12-07 at 23:47 +0100, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> The MediaTek DRM has a block called mmsys, which sets
>> the routing and enalbes the different blocks.
Typo s/enalbes/enables/
>> This patch adds one line for the mmsys bindings description.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> ---
>> .../display/mediatek/mediatek,disp.txt | 28 ++++++++++---------
>> 1 file changed, 15 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>> index 8469de510001..c71c8a4b73ff 100644
>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>> @@ -27,20 +27,22 @@ Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt.
>>
>> Required properties (all function blocks):
>> - compatible: "mediatek,<chip>-disp-<function>", one of
>> - "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending, csc)
>> - "mediatek,<chip>-disp-rdma" - read DMA / line buffer
>> - "mediatek,<chip>-disp-wdma" - write DMA
>> - "mediatek,<chip>-disp-color" - color processor
>> - "mediatek,<chip>-disp-aal" - adaptive ambient light controller
>> - "mediatek,<chip>-disp-gamma" - gamma correction
>> - "mediatek,<chip>-disp-merge" - merge streams from two RDMA sources
>> - "mediatek,<chip>-disp-split" - split stream to two encoders
>> - "mediatek,<chip>-disp-ufoe" - data compression engine
>> - "mediatek,<chip>-dsi" - DSI controller, see mediatek,dsi.txt
>> - "mediatek,<chip>-dpi" - DPI controller, see mediatek,dpi.txt
>> - "mediatek,<chip>-disp-mutex" - display mutex
>> - "mediatek,<chip>-disp-od" - overdrive
>> + "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending, csc)
>
> This patch conflicts with 5.5-rc, please resend this patch base on
> 5.5-rc1.
>
>> + "mediatek,<chip>-disp-rdma" - read DMA / line buffer
>> + "mediatek,<chip>-disp-wdma" - write DMA
>> + "mediatek,<chip>-disp-color" - color processor
>> + "mediatek,<chip>-disp-aal" - adaptive ambient light controller
>> + "mediatek,<chip>-disp-gamma" - gamma correction
>> + "mediatek,<chip>-disp-merge" - merge streams from two RDMA sources
>> + "mediatek,<chip>-disp-split" - split stream to two encoders
>> + "mediatek,<chip>-disp-ufoe" - data compression engine
>> + "mediatek,<chip>-dsi" - DSI controller, see mediatek,dsi.txt
>> + "mediatek,<chip>-dpi" - DPI controller, see mediatek,dpi.txt
>> + "mediatek,<chip>-disp-mutex" - display mutex
>> + "mediatek,<chip>-disp-od" - overdrive
>> + "mediatek,<chip>-mmsys", "syscon" - provide clocks and components management
>> the supported chips are mt2701, mt2712 and mt8173.
>
> The original binding document for mmsys is in [1], I think we should not
> define it in duplicate. Maybe you could remove the original document.
>
> [1]
> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Cmmsys.txt
>
> Regards,
> CK
>
>> +
>> - reg: Physical base address and length of the function block register space
>> - interrupts: The interrupt signal from the function block (required, except for
>> merge and split function blocks).
>
next prev parent reply other threads:[~2019-12-09 8:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 22:47 [resend PATCH v6 00/12] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg
2019-12-07 22:47 ` [resend PATCH v6 01/12] dt-bindings: display: mediatek: Add mmsys binding description matthias.bgg
2019-12-09 5:12 ` CK Hu
2019-12-09 8:48 ` Enric Balletbo i Serra [this message]
2020-02-13 18:17 ` Matthias Brugger
2019-12-18 16:39 ` Rob Herring
2019-12-07 22:47 ` [resend PATCH v6 02/12] dt-bindings: mediatek: Add compatible for mt7623 matthias.bgg
2019-12-09 8:51 ` Enric Balletbo i Serra
2019-12-18 17:02 ` Rob Herring
2019-12-07 22:47 ` [resend PATCH v6 03/12] drm/mediatek: Use regmap for register access matthias.bgg
2019-12-09 5:16 ` CK Hu
2019-12-07 22:47 ` [resend PATCH v6 04/12] drm: mediatek: Omit warning on probe defers matthias.bgg
2019-12-09 5:19 ` CK Hu
2019-12-09 9:39 ` Enric Balletbo i Serra
2020-02-13 18:58 ` Matthias Brugger
2019-12-07 22:47 ` [resend PATCH v6 05/12] media: mtk-mdp: Check return value of of_clk_get matthias.bgg
2019-12-09 9:50 ` Enric Balletbo i Serra
2019-12-07 22:47 ` [resend PATCH v6 06/12] clk: mediatek: mt2701: switch mmsys to platform device probing matthias.bgg
2019-12-09 9:58 ` Enric Balletbo i Serra
2020-02-13 19:11 ` Matthias Brugger
2019-12-07 22:47 ` [resend PATCH v6 07/12] clk: mediatek: mt2712e: switch " matthias.bgg
2019-12-09 9:59 ` Enric Balletbo i Serra
2019-12-07 22:47 ` [resend PATCH v6 08/12] clk: mediatek: mt6779: switch mmsys " matthias.bgg
2019-12-09 10:01 ` Enric Balletbo i Serra
2019-12-07 22:47 ` [resend PATCH v6 09/12] clk: mediatek: mt6797: switch " matthias.bgg
2019-12-07 22:47 ` [resend PATCH v6 10/12] clk: mediatek: mt8183: switch mmsys " matthias.bgg
2019-12-09 8:51 ` CK Hu
2020-02-13 19:35 ` Matthias Brugger
2019-12-07 22:47 ` [resend PATCH v6 11/12] clk: mediatek: mt8173: " matthias.bgg
2019-12-07 22:47 ` [resend PATCH v6 12/12] drm/mediatek: Add support for mmsys through a pdev matthias.bgg
2019-12-09 5:34 ` CK Hu
2020-02-13 19:46 ` Matthias Brugger
2019-12-09 10:15 ` Enric Balletbo i Serra
2020-02-13 2:57 ` [resend PATCH v6 00/12] arm/arm64: mediatek: Fix mmsys device probing CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dec02ff4-6627-2755-b05b-2ab0560feee7@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).