From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: arm: stm32: lxa,stm32mp157c-mc1: add extra SiP compatible
Date: Tue, 10 Nov 2020 11:26:24 +0100 [thread overview]
Message-ID: <decb0b4e-e6bf-98c5-df77-6b5f2405ae7f@pengutronix.de> (raw)
In-Reply-To: <20201109163733.GA1404197@bogus>
Hello Rob,
On 11/9/20 5:37 PM, Rob Herring wrote:
> On Wed, Nov 04, 2020 at 12:39:31PM +0100, Ahmad Fatoum wrote:
>> I know that bindings and device tree patches should be separate. Does
>> this apply here as well? Should I split the dts change into a follow-up
>> commit?
>
> Yes.
>
>> Is it ok that dtbs_check will report an intermittent breakage?
>
> If the binding comes first, it won't break.
>
> But generally, 'dtbs_check' being warning free is not yet a requirement.
> That will probably first have to be per platform.
here the old binding is deleted, so between the patches, there will be
a dtbs_check warning, which is why I asked. I've now split it up with
binding first.
>> + - const: oct,stm32mp15xx-osd32
>
> 'oct' is not docuemnted in vendor-prefixes.yaml.
Huh, I only checked whether it's in use, not if it's documented.
I just sent out a v2 with your points addressed.
Thanks for review,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2020-11-10 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 11:39 [PATCH v1] dt-bindings: arm: stm32: lxa,stm32mp157c-mc1: add extra SiP compatible Ahmad Fatoum
2020-11-09 16:37 ` Rob Herring
2020-11-10 10:26 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=decb0b4e-e6bf-98c5-df77-6b5f2405ae7f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).