devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Matt Merhar <mattmerhar@protonmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Bob Ham <rah@settrans.net>, Leonardo Bras <leobras.c@gmail.com>,
	Michael Brougham <jusplainmike@gmail.com>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ARM: tegra: Add device-tree for Ouya
Date: Fri, 25 Sep 2020 03:12:52 +0300	[thread overview]
Message-ID: <df2d6a8d-8a6c-464b-8f35-a7994ea01534@gmail.com> (raw)
In-Reply-To: <20200923210352.1176386-2-pgwipeout@gmail.com>

...
> +/ {
> +	model = "Ouya Game Console";
> +	compatible = "ouya,ouya", "nvidia,tegra30";
> +
> +	aliases {
> +		rtc0 = &pmic;
> +		rtc1 = "/rtc@7000e000";
> +		serial0 = &uartd; /* Debug Port */
> +		serial1 = &uartc; /* Bluetooth */
> +		mmc0 = &sdmmc4; /* eMMC */
> +		mmc1 = &sdmmc3; /* WiFi */

Thierry may want to sort these aliases in alphabet order.

> +	};

...
> +		pmic: pmic@2d {
> +			compatible = "ti,tps65911";
> +			reg = <0x2d>;
> +
> +			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> +			#interrupt-cells = <2>;
> +			interrupt-controller;
> +
> +			ti,system-power-controller;

Are the ti,sleep-keep-ck32k and other properties not needed for Ouya
like they are needed for Nexus 7?

...
> +	sdmmc3: mmc@78000400 {
> +		status = "okay";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		bus-width = <4>;
> +		non-removable;

Recently I added assigned-clocks here for Nexus7/A500 DTs in order to
get true 50MHz for the WiFi SDIO.

> +		mmc-pwrseq = <&wifi_pwrseq>;
> +		vmmc-supply = <&sdmmc_3v3_reg>;
> +		vqmmc-supply = <&vdd_1v8>;

  reply	other threads:[~2020-09-25  0:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 21:03 [PATCH v2 0/3] Support NVIDIA Tegra-based Ouya game console Peter Geis
2020-09-23 21:03 ` [PATCH v2 1/3] ARM: tegra: Add device-tree for Ouya Peter Geis
2020-09-25  0:12   ` Dmitry Osipenko [this message]
2020-09-26  2:01     ` Peter Geis
2020-09-26 13:47       ` Dmitry Osipenko
2020-09-29  4:01         ` Dmitry Osipenko
2020-09-23 21:03 ` [PATCH v2 2/3] dt-bindings: Add vendor prefix for Ouya Inc Peter Geis
2020-09-23 21:03 ` [PATCH v2 3/3] dt-bindings: ARM: tegra: Add Ouya game console Peter Geis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df2d6a8d-8a6c-464b-8f35-a7994ea01534@gmail.com \
    --to=digetx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=jusplainmike@gmail.com \
    --cc=leobras.c@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mattmerhar@protonmail.com \
    --cc=pgwipeout@gmail.com \
    --cc=rah@settrans.net \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).