From: Alexandre Torgue <alexandre.torgue@st.com>
To: Lucas Stach <l.stach@pengutronix.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
<linux-stm32@st-md-mailman.stormreply.com>,
<mcoquelin.stm32@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@pengutronix.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board
Date: Mon, 2 Mar 2020 11:29:28 +0100 [thread overview]
Message-ID: <e227de9a-7440-7e1f-2928-5648cbbe44c1@st.com> (raw)
In-Reply-To: <fbba971d7501c774ce0081f22dcff4ef74002a4d.camel@pengutronix.de>
Hi Lucas
On 3/2/20 11:18 AM, Lucas Stach wrote:
> On Mo, 2020-03-02 at 11:06 +0100, Alexandre Torgue wrote:
>> Hi Ahmad
>>
>> Thanks for adding a new STM32 board. Some minor comments.
>>
>> On 2/26/20 3:38 PM, Ahmad Fatoum wrote:
>>> The Linux Automation MC-1 is a SBC built around the Octavo Systems
>>> OSD32MP15x SiP. The SiP features up to 1 GB DDR3 RAM, EEPROM and
>>> a PMIC. The board has eMMC and a SD slot for storage and GbE
>>> for both connectivity and power.
>>>
>>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de
>>> ---
> [...]
>>> +
>>> +&gpu {
>>> + status = "okay";
>>> +};
>
> This question is more to the ST guys than this specific DT: Why is the
> GPU marked as disabled in the SoC dtsi file? This device is always
> present on the SoC and AFAICS there are no board level dependencies, so
> there is no reason to have it disabled by default, right? Removing the
> status property from the dtsi would remove the need for this override
> on the board DT.
You are right. With new stm32 device tree diversity, it makes no longer
sens to disable GPU node in stm32mp157 dtsi file. Indeed, we use now
dedicated files for each SoC (stm32mp151 / stm32mp153 /stm32mp157).
Ahmad, can you add this modification in your series please ?
regards
Alex
>
> Regards,
> Lucas
>
next prev parent reply other threads:[~2020-03-02 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 14:38 [PATCH 1/3] dt-bindings: add vendor prefix for Linux Automation GmbH Ahmad Fatoum
2020-02-26 14:38 ` [PATCH 2/3] ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board Ahmad Fatoum
2020-03-02 10:06 ` Alexandre Torgue
2020-03-02 10:18 ` Lucas Stach
2020-03-02 10:29 ` Alexandre Torgue [this message]
2020-03-02 10:35 ` Ahmad Fatoum
2020-03-02 10:34 ` Ahmad Fatoum
2020-02-26 14:38 ` [PATCH 3/3] dt-bindings: arm: stm32: document lxa,stm32mp157c-mc1 compatible Ahmad Fatoum
2020-03-03 14:30 ` Rob Herring
2020-03-03 14:30 ` [PATCH 1/3] dt-bindings: add vendor prefix for Linux Automation GmbH Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e227de9a-7440-7e1f-2928-5648cbbe44c1@st.com \
--to=alexandre.torgue@st.com \
--cc=a.fatoum@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).