From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56264C2D0E1 for ; Tue, 8 Sep 2020 20:13:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 276F6208FE for ; Tue, 8 Sep 2020 20:13:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mU7jGnXs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729822AbgIHUNE (ORCPT ); Tue, 8 Sep 2020 16:13:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729941AbgIHPLR (ORCPT ); Tue, 8 Sep 2020 11:11:17 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72C25C09B04F; Tue, 8 Sep 2020 07:48:55 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B154F47; Tue, 8 Sep 2020 16:48:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599576522; bh=lvuH3mHmFR9FWeXOZYD3vPI3zMXgRaK78p8ySrX6YIs=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=mU7jGnXsS6A3cBz+uMMka46IWBFtttpP68LYhszJ2OVdvY4JbfMcwnzD3cY8a0dp/ AXR5fUeGyRT4QrhaNXkB6BZ0/4eRjlnZuEuZweVPTBgOmz0lmp6JHABR0zNgHTYgZu kN5TcnDtVLPGUgDd1WOoP6B+H5uO32Fvjg1EnSNs= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible. To: Laurent Pinchart Cc: Kuninori Morimoto , Rob Herring , Geert Uytterhoeven , David Airlie , Daniel Vetter , Magnus , Linux-Renesas , Linux-DT , "(Renesas) shimoda" , dri-devel@lists.freedesktop.org References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87lfhlrtwp.wl-kuninori.morimoto.gx@renesas.com> <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> <20200908144317.GA11405@pendragon.ideasonboard.com> <20200908144623.GB11405@pendragon.ideasonboard.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Tue, 8 Sep 2020 15:48:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200908144623.GB11405@pendragon.ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, On 08/09/2020 15:46, Laurent Pinchart wrote: > On Tue, Sep 08, 2020 at 05:43:25PM +0300, Laurent Pinchart wrote: >> Hi Kieran, >> >> On Tue, Sep 08, 2020 at 03:18:20PM +0100, Kieran Bingham wrote: >>> On 08/09/2020 01:34, Kuninori Morimoto wrote: >>>> From: Kuninori Morimoto >>>> >>>> required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" >>> >>> Hrm, technically the driver will currently only match on : >>> "renesas,rcar-gen3-hdmi" >>> >>> But I see how the '-dw-' has probably snuck in from other devices, and >>> is inappropriate. >>> >>> Perhaps this should be more clear that it matches on the generic compatible: >>> renesas,rcar-gen3-hdmi >>> >>> (or a combination of both?) >>> >>>> Signed-off-by: Kuninori Morimoto >>> >>> But if the generic isn't required, then this patch alone does fix what I >>> would call an error, so ... >> >> You're right, the generic compatible string should be required. I'll >> update this patch accordingly, and will address the bindings as part of >> the conversion to YAML. > > Proposed new commit: > > commit cc487cbb06d841ca76efade63201a41bd04f6015 > Author: Kuninori Morimoto > Date: Tue Sep 8 09:34:11 2020 +0900 > > dt-bindings: display: renesas: dw-hdmi: Tidyup example compatible > > The DT example erronously uses the "renesas,r8a7795-dw-hdmi", when the > correct value is "renesas,r8a7795-hdmi". It is furthermore missing the > generic "renesas,rcar-gen3-hdmi" compatible string. Fix it. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Laurent Pinchart > Reviewed-by: Kieran Bingham > [Add "renesas,rcar-gen3-hdmi" and rework commit message] > Signed-off-by: Laurent Pinchart > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > index f275997ab947..9c56c5169a88 100644 > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > @@ -43,7 +43,7 @@ Optional properties: > Example: > > hdmi0: hdmi@fead0000 { > - compatible = "renesas,r8a7795-dw-hdmi"; > + compatible = "renesas,r8a7795-hdmi", "renesas,rcar-gen3-hdmi"; > reg = <0 0xfead0000 0 0x10000>; > interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; > Perfect, looks good to me. -- Kieran >>> Reviewed-by: Kieran Bingham >>> >>> We could always make this more clear when converting to YAML. >>> >>>> --- >>>> .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt >>>> index 819f3e31013c..e6526ab485d0 100644 >>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt >>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt >>>> @@ -42,7 +42,7 @@ Optional properties: >>>> Example: >>>> >>>> hdmi0: hdmi@fead0000 { >>>> - compatible = "renesas,r8a7795-dw-hdmi"; >>>> + compatible = "renesas,r8a7795-hdmi"; >>>> reg = <0 0xfead0000 0 0x10000>; >>>> interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; >>>> clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; >