From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Kurt Kanzenbach <kurt@kmk-computers.de>
Subject: Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node
Date: Tue, 10 Nov 2020 07:46:52 -0800 [thread overview]
Message-ID: <e711ac85-5826-4a49-ee21-e80d27acb38c@broadcom.com> (raw)
In-Reply-To: <5c424006-90ea-aee3-db2e-96b3a627a4a6@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
On 11/10/2020 1:31 AM, Rafał Miłecki wrote:
> 10.11.2020 04:31, Florian Fainelli wrote:
>> Provide an empty 'ports' container node with the correct #address-cells
>> and #size-cells properties. This silences the following warning:
>>
>> arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml:
>> ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed:
>> 'ports' is a required property
>> 'ethernet-ports' is a required property
>> From schema:
>> Documentation/devicetree/bindings/net/dsa/b53.yaml
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> arch/arm/boot/dts/bcm5301x.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi
>> b/arch/arm/boot/dts/bcm5301x.dtsi
>> index 807580dd89f5..89993a8a6765 100644
>> --- a/arch/arm/boot/dts/bcm5301x.dtsi
>> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
>> @@ -489,6 +489,10 @@ srab: ethernet-switch@18007000 {
>> status = "disabled";
>> /* ports are defined in board DTS */
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>
> You can drop those two lines from board files now I believe.
>
> grep "ports {" arch/arm/boot/dts/bcm470*
> + arch/arm/boot/dts/bcm953012er.dts
Yes, indeed, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4178 bytes --]
next prev parent reply other threads:[~2020-11-10 15:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 3:31 [PATCH 00/10] Broadcom b53 YAML bindings Florian Fainelli
2020-11-10 3:31 ` [PATCH 01/10] dt-bindings: net: dsa: Extend switch nodes pattern Florian Fainelli
2020-11-10 19:42 ` Vladimir Oltean
2020-11-11 22:24 ` Rob Herring
2020-11-10 3:31 ` [PATCH 02/10] dt-bindings: net: dsa: Document sfp and managed properties Florian Fainelli
2020-11-11 22:33 ` Rob Herring
2020-11-10 3:31 ` [PATCH 03/10] ARM: dts: BCM5301X: Update Ethernet switch node name Florian Fainelli
2020-11-10 19:46 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node Florian Fainelli
2020-11-10 22:06 ` Vladimir Oltean
2020-11-10 22:11 ` Florian Fainelli
2020-11-11 13:06 ` Rafał Miłecki
2020-11-10 3:31 ` [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node Florian Fainelli
2020-11-10 9:31 ` Rafał Miłecki
2020-11-10 15:46 ` Florian Fainelli [this message]
2020-11-10 22:12 ` Vladimir Oltean
2020-11-10 22:13 ` Florian Fainelli
2020-11-11 1:48 ` Florian Fainelli
2020-11-11 12:27 ` Rafał Miłecki
2020-11-10 3:31 ` [PATCH 06/10] ARM: dts: NSP: Update ethernet switch node name Florian Fainelli
2020-11-10 22:16 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name Florian Fainelli
2020-11-10 22:27 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node Florian Fainelli
2020-11-10 22:37 ` Vladimir Oltean
2020-11-10 22:40 ` Florian Fainelli
2020-11-10 22:48 ` Vladimir Oltean
2020-11-10 22:52 ` Florian Fainelli
2020-11-10 23:06 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 09/10] ARM: dts: NSP: Provide defaults ports container node Florian Fainelli
2020-11-10 3:31 ` [PATCH 10/10] dt-bindings: net: dsa: b53: Add YAML bindings Florian Fainelli
2020-11-10 13:21 ` Kurt Kanzenbach
2020-11-10 15:46 ` Florian Fainelli
2020-11-10 22:43 ` Vladimir Oltean
2020-11-11 22:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e711ac85-5826-4a49-ee21-e80d27acb38c@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=kurt@kmk-computers.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=vivien.didelot@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).