From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FDBC4363D for ; Thu, 24 Sep 2020 11:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C6162395B for ; Thu, 24 Sep 2020 11:31:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="ALBCS4kz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbgIXLbG (ORCPT ); Thu, 24 Sep 2020 07:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgIXLbG (ORCPT ); Thu, 24 Sep 2020 07:31:06 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2787AC0613CE; Thu, 24 Sep 2020 04:31:06 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 7280122F9C; Thu, 24 Sep 2020 13:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1600947062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y9uiVuDlDurWMBLr4DK3ZvbWHNzJ3UuorXgrA6S7yTo=; b=ALBCS4kz/N/WYzAl+Gfzrx0IfLLa5cL3I2vF7nmngeS2eABzmOVm2TNFLrmsXdP0i1RPlR c61YLjyGNaPRgzTAECQKGS61p6D0xx+HQZlik8zLenvVbTXVMTPHkIRaBC/TSj3NgRj5BA V0/NwlJ7kG9i21VqnWXopznrvkLRmto= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 24 Sep 2020 13:31:00 +0200 From: Michael Walle To: Leo Li Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, Shawn Guo , Rob Herring , Marc Kleine-Budde , Joakim Zhang Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes In-Reply-To: References: <20200923095711.11355-1-michael@walle.cc> <20200923095711.11355-2-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am 2020-09-24 02:35, schrieb Leo Li: >> -----Original Message----- >> From: Michael Walle >> Sent: Wednesday, September 23, 2020 4:57 AM >> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; >> linux- >> kernel@vger.kernel.org; linux-can@vger.kernel.org >> Cc: Shawn Guo ; Leo Li ; Rob >> Herring ; Marc Kleine-Budde ; >> Joakim Zhang ; Michael Walle >> >> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes >> >> The LS1028A has two FlexCAN controller. These are compatible with the >> ones >> from the LX2160A. Add the nodes. >> >> The first controller was tested on the Kontron sl28 board. >> >> Signed-off-by: Michael Walle >> --- >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 >> ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> index 0efeb8fa773e..807ee921ec12 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> @@ -386,6 +386,24 @@ >> status = "disabled"; >> }; >> >> + can0: can@2180000 { >> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- >> flexcan"; > > The explicit compatible strings cannot be found in the binding, but > matched by the "fsl,-flexcan" pattern in the binding. Is > this considered to be acceptable now? What is the consequence if it is not acceptable? replacing the pattern with individual compatible strings? -michael