From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen
Date: Thu, 12 Dec 2019 17:22:35 +0100 [thread overview]
Message-ID: <e9c3d1d5f8b57d92e5823f74762a2de2b20f8e88.camel@collabora.co.uk> (raw)
In-Reply-To: <20191212160722.wgqjeeknvm257hwi@pengutronix.de>
On Thu, 2019-12-12 at 17:07 +0100, Marco Felsch wrote:
> Hi Sjoerd,
>
> On 19-12-12 17:02, Sjoerd Simons wrote:
> > Sabrelite boards can have an lvds screen attached with a built-in
> > i2c touch
> > screen. Enable this in the dtsi.
>
> Can this be any screen available on the market?
I guess i should have been more clear here; This is the touchscreen in
the hannstar display (already part of the dts) that was sold as an
accessoiry to the sabrelite.
Same as the screen that can be used on the boundary nitrogen6 boards
(which do have the touch part already enabled in the dts)
>
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > ---
> >
> > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > index 8468216dae9b..382b127b2251 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > @@ -416,6 +416,14 @@ &i2c3 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_i2c3>;
> > status = "okay";
> > +
> > + touchscreen@4 {
> > + compatible = "eeti,egalax_ts";
> > + reg = <0x04>;
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > + wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
>
> The wakeup-gpio and the irq-line are sharing the same gpio line?
>
> Regards,
> Marco
>
> > + };
> > };
> >
> > &iomuxc {
> > --
> > 2.24.0
> >
> >
> >
--
Sjoerd Simons
Collabora Ltd.
next prev parent reply other threads:[~2019-12-12 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 16:02 [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen Sjoerd Simons
2019-12-12 16:07 ` Marco Felsch
2019-12-12 16:22 ` Sjoerd Simons [this message]
2019-12-12 16:25 ` Marco Felsch
2019-12-13 9:03 ` Sjoerd Simons
2019-12-12 16:23 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3d1d5f8b57d92e5823f74762a2de2b20f8e88.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).