From: Sudeep Holla <sudeep.holla@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Liviu Dudau <liviu.dudau@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] arm64: dts: juno: fix graph node unit addresses for coresight components
Date: Wed, 16 May 2018 12:49:25 +0100 [thread overview]
Message-ID: <eba4cddf-f668-a5e1-acea-5e6538c230f0@arm.com> (raw)
In-Reply-To: <574f6959-6a84-9e0e-3d89-84d2d75d9191@arm.com>
On 16/05/18 12:23, Suzuki K Poulose wrote:
> On 05/16/2018 11:34 AM, Sudeep Holla wrote:
[..]
>> Hi Suzuki/Mathieu,
>>
>> I did a quick scan @ drivers/hwtracing/coresight/of_coresight.c to
>> check if reg field is being used or not and whether this change
>> causes any regression. I don't think so, but I may be wrong, let me
>> know.
>
> Unfortunately, I think this would break the components like funnel,
> where we need the input port number for the connected master to enable
> the port. Similarly for the output port number for master components in
> the paths. I have a set of patches which address this by taking care of
> the port number order to find out the hardware port number.
>
Ah ok, I now see of_graph_parse_endpoint, sorry for missing that.
> I will dust it up and send it. That would bring up another important
> question.
>
Cool
> How do we deal with the change in the port number scheme ? e.g, should
> the new kernel support DTBs with old scheme ?
IIUC, that's needed for backward compatibility as it was used schema.
Again I may be wrong.
> If so, how do we specify that the DT uses new scheme.
Perhaps, add something to indicate the change in numbering scheme ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-05-16 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 10:34 [PATCH] arm64: dts: juno: fix graph node unit addresses for coresight components Sudeep Holla
2018-05-16 11:23 ` Suzuki K Poulose
2018-05-16 11:49 ` Sudeep Holla [this message]
2018-05-16 17:29 ` Mathieu Poirier
2018-05-16 17:40 ` Sudeep Holla
2018-05-16 21:30 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eba4cddf-f668-a5e1-acea-5e6538c230f0@arm.com \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=liviu.dudau@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).