Re: [PATCH 2/4] arm64: add basic DTS for i.MX8MQ - aisheng.dong-sgV2jX0FEOL9JmXXK+q4OQ

From: aisheng.dong-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	patchwork-lst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-imx-3arQi8VN3Tc@public.gmane.org,
	aisheng.dong-3arQi8VN3Tc@public.gmane.org
Subject: Re: [PATCH 2/4] arm64: add basic DTS for i.MX8MQ
Date: Thu, 25 Jan 2018 17:48:41 +0800	[thread overview]
Message-ID: <ebc8b28d5c2948131cc187ac8177395c@codeaurora.org> (raw)
In-Reply-To: <1516713799.25726.21.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Hi Lucas,

First of all, good to see this patch series in community.

Pengutronix has always been an active friendly contributor on IMX
upstream activities.  You Did help us a lot!

On 2018-01-23 21:23, Lucas Stach wrote:

<snip>

>> > > > +			#address-cells = <1>;
>> > > > +			#size-cells = <1>;
>> > > > +			ranges = <0x30000000 0x30000000 0x400000>;
>> > +
>> > > > > > +			gpio1: gpio@30200000 {
>> > +				compatible = "nxp,imx8mq-gpio", "fsl,imx35-gpio";
>> 
>> It looks a bit odd to have different vendor prefix for the same 
>> device.
>> But we can understand the reason.  Just curious if this is what vendor
>> kernel does?
> 
> No, I did it mostly to be consistent with the location of the DT files
> under "nxp". I'll change this to match the "freescale" location.
> 

Vendor tree mostly is still using fsl,imx8mq-xx.

And many binding doc format is:"compatible : Should be "fsl,<soc>-gpio".
So we can't use 'nxp' prefix here without changing binding doc.

Then if we decided to use 'fsl' prefix, probably we may want to fix the
rest of them in this file as well.

And i see the dtsi file does not include Freescale/NXP copyright,
is there a reason?

BTW it's quite strange that my gmail did not receive your MX8MQ patch
series except clk part.
Lucas, Could you help have me CCed next time?
I'd like to help review and test the patch series.

For this time, can you help send them all to me as attachment?

(You can also send all IMX related patches to linux-imx-3arQi8VN3Tc@public.gmane.org maillist
i created recently for tracking all IMX related upstream activities.
Most Freescale/NXP driver owners are in this list that could help on
the review. Shawn, do you think if i can put it in MAINTAINER file?)

Regards
Dong Aisheng

> Regards,
> Lucas
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html