From: Florian Fainelli <f.fainelli@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Sugaya Taichi <sugaya.taichi@socionext.com>,
Andrew Jeffery <andrew@aj.id.au>, Arnd Bergmann <arnd@arndb.de>,
Joel Stanley <joel@jms.id.au>, Vinod Koul <vkoul@kernel.org>,
"james.tai" <james.tai@realtek.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 11/12] dt-bindings: arm: Document Broadcom SoCs 'secondary-boot-reg'
Date: Wed, 5 Feb 2020 09:48:19 -0800 [thread overview]
Message-ID: <ec3d1bca-323c-d3fc-ea0e-75335b4b92dc@gmail.com> (raw)
In-Reply-To: <20200205074908.kwtqadfcwo2mtefk@gilmour.lan>
On 2/4/20 11:49 PM, Maxime Ripard wrote:
> On Tue, Feb 04, 2020 at 03:55:51PM -0800, Florian Fainelli wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
>> index c23c24ff7575..d7b181a44789 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
>> @@ -272,6 +272,39 @@ properties:
>> While optional, it is the preferred way to get access to
>> the cpu-core power-domains.
>>
>> + secondary-boot-reg:
>> + $ref: '/schemas/types.yaml#/definitions/uint32'
>> + description: |
>> + Required for systems that have an "enable-method" property value of
>> + "brcm,bcm11351-cpu-method", "brcm,bcm23550" or "brcm,bcm-nsp-smp".
>> +
>> + This includes the following SoCs: |
>> + BCM11130, BCM11140, BCM11351, BCM28145, BCM28155, BCM21664, BCM23550
>> + BCM58522, BCM58525, BCM58535, BCM58622, BCM58623, BCM58625, BCM88312
>> +
>> + The secondary-boot-reg property is a u32 value that specifies the
>> + physical address of the register used to request the ROM holding pen
>> + code release a secondary CPU. The value written to the register is
>> + formed by encoding the target CPU id into the low bits of the
>> + physical start address it should jump to.
>> +
>> +if:
>> + # If the enable-method property contains one of those values
>> + properties:
>> + enable-method:
>> + contains:
>> + enum:
>> + - brcm,bcm11351-cpu-method
>> + - brcm,bcm23550
>> + - brcm,bcm-nsp-smp
>> + # and if enable-method is present
>
> Those comments were purely for the explanation, but you can keep them
> I guess :)
>
> Regardless on whether or not you keep them, for the whole series
> Acked-by: Maxime Ripard <mripard@kernel.org>
You could almost have Signed-off-by on this one, thanks a lot for
walking me through examples.
--
Florian
next prev parent reply other threads:[~2020-02-05 17:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 23:55 [PATCH v2 00/12] dt-bindings: arm: bcm: Convert boards to YAML Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 01/12] dt-bindings: arm: bcm: Convert Cygnus " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 02/12] dt-bindings: arm: bcm: Convert Hurricane 2 " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 03/12] dt-bindings: arm: bcm: Convert Northstar Plus " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 04/12] dt-bindings: arm: bcm: Convert Northstar 2 " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 05/12] dt-bindings: arm: bcm: Convert Stingray " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 06/12] dt-bindings: arm: bcm: Convert BCM21664 " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 07/12] dt-bindings: arm: bcm: Convert BCM23550 " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 08/12] dt-bindings: arm: bcm: Convert BCM4708 " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 09/12] dt-bindings: arm: bcm: Convert BCM11351 " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 10/12] dt-bindings: arm: bcm: Convert Vulcan " Florian Fainelli
2020-02-04 23:55 ` [PATCH v2 11/12] dt-bindings: arm: Document Broadcom SoCs 'secondary-boot-reg' Florian Fainelli
2020-02-05 7:49 ` Maxime Ripard
2020-02-05 17:48 ` Florian Fainelli [this message]
2020-02-04 23:55 ` [PATCH v2 12/12] dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML Florian Fainelli
2020-02-06 19:23 ` Rob Herring
2020-03-22 21:35 ` Florian Fainelli
2020-03-23 8:40 ` Maxime Ripard
2020-03-23 10:42 ` Nicolas Saenz Julienne
2020-02-05 17:39 ` [PATCH v2 00/12] dt-bindings: arm: bcm: Convert boards " Scott Branden
2020-02-06 19:24 ` Rob Herring
2020-03-10 19:47 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3d1bca-323c-d3fc-ea0e-75335b4b92dc@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=james.tai@realtek.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=sugaya.taichi@socionext.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).