From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karthik Ramasubramanian Subject: Re: [PATCH v2 3/7] soc: qcom: Add GENI based QUP Wrapper driver Date: Fri, 16 Feb 2018 13:44:49 -0700 Message-ID: References: <1515805547-22816-1-git-send-email-kramasub@codeaurora.org> <1515805547-22816-4-git-send-email-kramasub@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-i2c-owner@vger.kernel.org To: Amit Kucheria Cc: corbet@lwn.net, Andy Gross , david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wsa@the-dreams.de, gregkh@linuxfoundation.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, Sagar Dharia , Girish Mahadevan List-Id: devicetree@vger.kernel.org On 2/14/2018 4:07 AM, Amit Kucheria wrote: > On Sat, Jan 13, 2018 at 6:35 AM, Karthikeyan Ramasubramanian > wrote: >> This driver manages the Generic Interface (GENI) firmware based Qualcomm >> Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation >> programmable module composed of multiple Serial Engines (SE) and supports >> a wide range of serial interfaces like UART, SPI, I2C, I3C, etc. This >> driver also enables managing the serial interface independent aspects of >> Serial Engines. >> >> Signed-off-by: Karthikeyan Ramasubramanian >> Signed-off-by: Sagar Dharia >> Signed-off-by: Girish Mahadevan > > >> +int geni_se_resources_off(struct geni_se_rsc *rsc) >> +{ >> + int ret = 0; >> + struct geni_se_device *geni_se_dev; >> + >> + if (unlikely(!rsc || !rsc->wrapper_dev)) >> + return -EINVAL; >> + >> + geni_se_dev = dev_get_drvdata(rsc->wrapper_dev); >> + if (unlikely(!geni_se_dev)) >> + return -ENODEV; >> + >> + ret = pinctrl_select_state(rsc->geni_pinctrl, rsc->geni_gpio_sleep); > > You need to include linux/pinctrl/consumer.h for devm_pinctrl_get > > I couldn't compile test it w/o it. > I think marking the dependencies might help with this compilation issue. Else I will include the concerned header file. One way or the other, I will ensure that this issue does not get hit in my follow-up patch series. Regards, Karthik. -- Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project