* [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data
2019-11-23 20:13 [PATCH 0/4] ls1028a: dts fixes and new board support Michael Walle
@ 2019-11-23 20:13 ` Michael Walle
2019-12-09 6:24 ` Shawn Guo
2019-11-23 20:13 ` [PATCH 2/4] arm64: dts: ls1028a: add missing sai nodes Michael Walle
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: Michael Walle @ 2019-11-23 20:13 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
This was tested on a custom board.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index dc75534a4754..f2e71fd57b20 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -573,7 +573,7 @@
0x00010004 0x0000003d
0x00010005 0x00000045
0x00010006 0x0000004d
- 0x00010007 0x00000045
+ 0x00010007 0x00000055
0x00010008 0x0000005e
0x00010009 0x00000066
0x0001000a 0x0000006e
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data
2019-11-23 20:13 ` [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data Michael Walle
@ 2019-12-09 6:24 ` Shawn Guo
2019-12-09 6:39 ` [EXT] " Andy Tang
2019-12-09 8:41 ` Michael Walle
0 siblings, 2 replies; 14+ messages in thread
From: Shawn Guo @ 2019-12-09 6:24 UTC (permalink / raw)
To: Michael Walle, Yuantian Tang
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
+ Yuantian Tang, who is the author of existing code.
On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
> This was tested on a custom board.
Can you add more info about why this is an error and how it is being
identified?
Shawn
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index dc75534a4754..f2e71fd57b20 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -573,7 +573,7 @@
> 0x00010004 0x0000003d
> 0x00010005 0x00000045
> 0x00010006 0x0000004d
> - 0x00010007 0x00000045
> + 0x00010007 0x00000055
> 0x00010008 0x0000005e
> 0x00010009 0x00000066
> 0x0001000a 0x0000006e
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [EXT] Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data
2019-12-09 6:24 ` Shawn Guo
@ 2019-12-09 6:39 ` Andy Tang
2019-12-09 8:41 ` Michael Walle
1 sibling, 0 replies; 14+ messages in thread
From: Andy Tang @ 2019-12-09 6:39 UTC (permalink / raw)
To: Shawn Guo, Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Leo Li, Rob Herring,
Mark Rutland
Hi Shawn,
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年12月9日 14:25
> To: Michael Walle <michael@walle.cc>; Andy Tang <andy.tang@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> Subject: [EXT] Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU
> calibration data
>
> Caution: EXT Email
>
> + Yuantian Tang, who is the author of existing code.
>
> On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
> > This was tested on a custom board.
>
> Can you add more info about why this is an error and how it is being
> identified?
I am not sure how Michael figured out this error but he/she is correct.
I must have made a mistake when sending these data out.
Thanks Shawn and Michael.
Acked-by: Tang Yuantian <andy.tang@nxp.com>
BR,
Andy
>
> Shawn
>
> >
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index dc75534a4754..f2e71fd57b20 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -573,7 +573,7 @@
> > 0x00010004
> 0x0000003d
> > 0x00010005
> 0x00000045
> > 0x00010006
> 0x0000004d
> > - 0x00010007
> 0x00000045
> > + 0x00010007
> 0x00000055
> > 0x00010008
> 0x0000005e
> > 0x00010009
> 0x00000066
> > 0x0001000a
> 0x0000006e
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data
2019-12-09 6:24 ` Shawn Guo
2019-12-09 6:39 ` [EXT] " Andy Tang
@ 2019-12-09 8:41 ` Michael Walle
1 sibling, 0 replies; 14+ messages in thread
From: Michael Walle @ 2019-12-09 8:41 UTC (permalink / raw)
To: Shawn Guo
Cc: Yuantian Tang, linux-arm-kernel, devicetree, linux-kernel,
Li Yang, Rob Herring, Mark Rutland
Am 2019-12-09 07:24, schrieb Shawn Guo:
> + Yuantian Tang, who is the author of existing code.
>
> On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
>> This was tested on a custom board.
>
> Can you add more info about why this is an error and how it is being
> identified?
sorry. there was a more elaborate commit message. something went wrong
here.
-michael
>
> Shawn
>
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index dc75534a4754..f2e71fd57b20 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -573,7 +573,7 @@
>> 0x00010004 0x0000003d
>> 0x00010005 0x00000045
>> 0x00010006 0x0000004d
>> - 0x00010007 0x00000045
>> + 0x00010007 0x00000055
>> 0x00010008 0x0000005e
>> 0x00010009 0x00000066
>> 0x0001000a 0x0000006e
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/4] arm64: dts: ls1028a: add missing sai nodes
2019-11-23 20:13 [PATCH 0/4] ls1028a: dts fixes and new board support Michael Walle
2019-11-23 20:13 ` [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data Michael Walle
@ 2019-11-23 20:13 ` Michael Walle
2019-12-09 6:31 ` Shawn Guo
2019-11-23 20:13 ` [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node Michael Walle
2019-11-23 20:13 ` [PATCH 4/4] arm64: dts: freescale: add Kontron sl28 support Michael Walle
3 siblings, 1 reply; 14+ messages in thread
From: Michael Walle @ 2019-11-23 20:13 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
The LS1028A has six SAI cores.
Signed-off-by: Michael Walle <michael@walle.cc>
---
.../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 42 +++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index f2e71fd57b20..6730922c2d47 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -534,6 +534,20 @@
status = "disabled";
};
+ sai3: audio-controller@f120000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0xf120000 0x0 0x10000>;
+ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clockgen 4 1>, <&clockgen 4 1>,
+ <&clockgen 4 1>, <&clockgen 4 1>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 8>,
+ <&edma0 1 7>;
+ status = "disabled";
+ };
+
sai4: audio-controller@f130000 {
#sound-dai-cells = <0>;
compatible = "fsl,vf610-sai";
@@ -548,6 +562,34 @@
status = "disabled";
};
+ sai5: audio-controller@f140000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0xf140000 0x0 0x10000>;
+ interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clockgen 4 1>, <&clockgen 4 1>,
+ <&clockgen 4 1>, <&clockgen 4 1>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 12>,
+ <&edma0 1 11>;
+ status = "disabled";
+ };
+
+ sai6: audio-controller@f150000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0xf150000 0x0 0x10000>;
+ interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clockgen 4 1>, <&clockgen 4 1>,
+ <&clockgen 4 1>, <&clockgen 4 1>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 14>,
+ <&edma0 1 13>;
+ status = "disabled";
+ };
+
tmu: tmu@1f00000 {
compatible = "fsl,qoriq-tmu";
reg = <0x0 0x1f80000 0x0 0x10000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/4] arm64: dts: ls1028a: add missing sai nodes
2019-11-23 20:13 ` [PATCH 2/4] arm64: dts: ls1028a: add missing sai nodes Michael Walle
@ 2019-12-09 6:31 ` Shawn Guo
0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2019-12-09 6:31 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
On Sat, Nov 23, 2019 at 09:13:15PM +0100, Michael Walle wrote:
> The LS1028A has six SAI cores.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index f2e71fd57b20..6730922c2d47 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -534,6 +534,20 @@
> status = "disabled";
> };
>
> + sai3: audio-controller@f120000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0xf120000 0x0 0x10000>;
> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&clockgen 4 1>, <&clockgen 4 1>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 8>,
> + <&edma0 1 7>;
> + status = "disabled";
> + };
> +
> sai4: audio-controller@f130000 {
> #sound-dai-cells = <0>;
> compatible = "fsl,vf610-sai";
> @@ -548,6 +562,34 @@
> status = "disabled";
> };
>
> + sai5: audio-controller@f140000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0xf140000 0x0 0x10000>;
> + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&clockgen 4 1>, <&clockgen 4 1>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 12>,
> + <&edma0 1 11>;
> + status = "disabled";
> + };
> +
> + sai6: audio-controller@f150000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0xf150000 0x0 0x10000>;
> + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> + <&clockgen 4 1>, <&clockgen 4 1>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 14>,
> + <&edma0 1 13>;
> + status = "disabled";
> + };
> +
> tmu: tmu@1f00000 {
Not sure what your base is, but I have tmu@1f80000. And that makes
the patch applying fail here.
Shawn
> compatible = "fsl,qoriq-tmu";
> reg = <0x0 0x1f80000 0x0 0x10000>;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
2019-11-23 20:13 [PATCH 0/4] ls1028a: dts fixes and new board support Michael Walle
2019-11-23 20:13 ` [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data Michael Walle
2019-11-23 20:13 ` [PATCH 2/4] arm64: dts: ls1028a: add missing sai nodes Michael Walle
@ 2019-11-23 20:13 ` Michael Walle
2019-11-26 6:40 ` [EXT] " Kuldeep Singh
2019-11-23 20:13 ` [PATCH 4/4] arm64: dts: freescale: add Kontron sl28 support Michael Walle
3 siblings, 1 reply; 14+ messages in thread
From: Michael Walle @ 2019-11-23 20:13 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 6730922c2d47..650b277ddd66 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -260,6 +260,19 @@
status = "disabled";
};
+ fspi: spi@20c0000 {
+ compatible = "nxp,lx2160a-fspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x20c0000 0x0 0x10000>,
+ <0x0 0x20000000 0x0 0x10000000>;
+ reg-names = "fspi_base", "fspi_mmap";
+ interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "fspi_en", "fspi";
+ status = "disabled";
+ };
+
esdhc: mmc@2140000 {
compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
reg = <0x0 0x2140000 0x0 0x10000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* RE: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
2019-11-23 20:13 ` [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node Michael Walle
@ 2019-11-26 6:40 ` Kuldeep Singh
2019-11-26 10:08 ` Michael Walle
0 siblings, 1 reply; 14+ messages in thread
From: Kuldeep Singh @ 2019-11-26 6:40 UTC (permalink / raw)
To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Leo Li, Rob Herring, Mark Rutland
Hi Michael,
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org>
> On Behalf Of Michael Walle
> Sent: Sunday, November 24, 2019 1:43 AM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> Michael Walle <michael@walle.cc>
> Subject: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
There's already a patch[1] sent upstream and is under review.
It includes dts(i) entries for LS1028. I will be sending the next version
[1] https://patchwork.kernel.org/patch/11139365/
>
> Caution: EXT Email
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 6730922c2d47..650b277ddd66 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -260,6 +260,19 @@
> status = "disabled";
> };
>
> + fspi: spi@20c0000 {
> + compatible = "nxp,lx2160a-fspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x20c0000 0x0 0x10000>,
> + <0x0 0x20000000 0x0 0x10000000>;
> + reg-names = "fspi_base", "fspi_mmap";
> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clockgen 4 3>, <&clockgen 4 3>;
> + clock-names = "fspi_en", "fspi";
> + status = "disabled";
> + };
> +
> esdhc: mmc@2140000 {
> compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> reg = <0x0 0x2140000 0x0 0x10000>;
> --
> 2.20.1
Regards
Kuldeep
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
2019-11-26 6:40 ` [EXT] " Kuldeep Singh
@ 2019-11-26 10:08 ` Michael Walle
2019-12-02 5:43 ` Kuldeep Singh
0 siblings, 1 reply; 14+ messages in thread
From: Michael Walle @ 2019-11-26 10:08 UTC (permalink / raw)
To: Kuldeep Singh
Cc: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo, Leo Li,
Rob Herring, Mark Rutland
Hi Kuldeep,
Am 2019-11-26 07:40, schrieb Kuldeep Singh:
> Hi Michael,
>
>> -----Original Message-----
>> From: devicetree-owner@vger.kernel.org
>> <devicetree-owner@vger.kernel.org>
>> On Behalf Of Michael Walle
>> Sent: Sunday, November 24, 2019 1:43 AM
>> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
>> linux-
>> kernel@vger.kernel.org
>> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
>> Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
>> Michael Walle <michael@walle.cc>
>> Subject: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
>
> There's already a patch[1] sent upstream and is under review.
> It includes dts(i) entries for LS1028. I will be sending the next
> version
I've seen that, but there wasn't any reply for almost two months now.
But
if you're sending your next version, this patch can be dropped from this
series.
-michael
>
> [1] https://patchwork.kernel.org/patch/11139365/
>>
>> Caution: EXT Email
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 6730922c2d47..650b277ddd66 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -260,6 +260,19 @@
>> status = "disabled";
>> };
>>
>> + fspi: spi@20c0000 {
>> + compatible = "nxp,lx2160a-fspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x20c0000 0x0 0x10000>,
>> + <0x0 0x20000000 0x0 0x10000000>;
>> + reg-names = "fspi_base", "fspi_mmap";
>> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clockgen 4 3>, <&clockgen 4 3>;
>> + clock-names = "fspi_en", "fspi";
>> + status = "disabled";
>> + };
>> +
>> esdhc: mmc@2140000 {
>> compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
>> reg = <0x0 0x2140000 0x0 0x10000>;
>> --
>> 2.20.1
>
> Regards
> Kuldeep
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
2019-11-26 10:08 ` Michael Walle
@ 2019-12-02 5:43 ` Kuldeep Singh
0 siblings, 0 replies; 14+ messages in thread
From: Kuldeep Singh @ 2019-12-02 5:43 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo, Leo Li,
Rob Herring, Mark Rutland
Hi,
> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Tuesday, November 26, 2019 3:38 PM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Shawn Guo <shawnguo@kernel.org>; Leo Li
> <leoyang.li@nxp.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>
> Subject: Re: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
>
> Caution: EXT Email
>
> Hi Kuldeep,
>
> Am 2019-11-26 07:40, schrieb Kuldeep Singh:
> > Hi Michael,
> >
> >> -----Original Message-----
> >> From: devicetree-owner@vger.kernel.org
> >> <devicetree-owner@vger.kernel.org>
> >> On Behalf Of Michael Walle
> >> Sent: Sunday, November 24, 2019 1:43 AM
> >> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> >> linux-
> >> kernel@vger.kernel.org
> >> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>;
> Rob
> >> Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> >> Michael Walle <michael@walle.cc>
> >> Subject: [EXT] [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node
> >
> > There's already a patch[1] sent upstream and is under review.
> > It includes dts(i) entries for LS1028. I will be sending the next
> > version
>
> I've seen that, but there wasn't any reply for almost two months now.
> But
> if you're sending your next version, this patch can be dropped from this
> series.
Okay.
--Kuldeep
>
> -michael
>
> >
> > [1]
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.kernel.org%2Fpatch%2F11139365%2F&data=02%7C01%7Ckuld
> eep.sing
> >
> h%40nxp.com%7C327363e5ba97483c9add08d77258875d%7C686ea1d3bc2
> b4c6fa92cd
> >
> 99c5c301635%7C0%7C0%7C637103596868168346&sdata=yDJ1ggrIuR
> v1%2Br%2F
> > 9Ez1uvv0EpFB8Mns5%2Ffn%2F7zG5InA%3D&reserved=0
> >>
> >> Caution: EXT Email
> >>
> >> Signed-off-by: Michael Walle <michael@walle.cc>
> >> ---
> >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 13 +++++++++++++
> >> 1 file changed, 13 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> index 6730922c2d47..650b277ddd66 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> @@ -260,6 +260,19 @@
> >> status = "disabled";
> >> };
> >>
> >> + fspi: spi@20c0000 {
> >> + compatible = "nxp,lx2160a-fspi";
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + reg = <0x0 0x20c0000 0x0 0x10000>,
> >> + <0x0 0x20000000 0x0 0x10000000>;
> >> + reg-names = "fspi_base", "fspi_mmap";
> >> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&clockgen 4 3>, <&clockgen 4 3>;
> >> + clock-names = "fspi_en", "fspi";
> >> + status = "disabled";
> >> + };
> >> +
> >> esdhc: mmc@2140000 {
> >> compatible = "fsl,ls1028a-esdhc", "fsl,esdhc";
> >> reg = <0x0 0x2140000 0x0 0x10000>;
> >> --
> >> 2.20.1
> >
> > Regards
> > Kuldeep
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/4] arm64: dts: freescale: add Kontron sl28 support
2019-11-23 20:13 [PATCH 0/4] ls1028a: dts fixes and new board support Michael Walle
` (2 preceding siblings ...)
2019-11-23 20:13 ` [PATCH 3/4] arm64: dts: ls1028a: add FlexSPI node Michael Walle
@ 2019-11-23 20:13 ` Michael Walle
2019-12-09 6:43 ` Shawn Guo
3 siblings, 1 reply; 14+ messages in thread
From: Michael Walle @ 2019-11-23 20:13 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
Add device tree files for the Kontron SMARC-sAL28 board and its
carriers.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/Makefile | 4 +
.../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 27 +++
.../fsl-ls1028a-kontron-sl28-var3-ads2.dts | 73 ++++++++
.../fsl-ls1028a-kontron-sl28-var4.dts | 34 ++++
.../freescale/fsl-ls1028a-kontron-sl28.dts | 158 ++++++++++++++++++
5 files changed, 296 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 93fce8f0c66d..080c5a59d6bd 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -4,6 +4,10 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-oxalis.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-kbox-a-230-ls.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28-var3-ads2.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28-var4.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-rdb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
new file mode 100644
index 000000000000..97e72c94b7fc
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Device Tree File for the Kontron KBox A-230-LS.
+ *
+ * This consists of a Kontron SMARC-sAL28 (Dual PHY) and a special
+ * carrier (s1914).
+ *
+ * Copyright (C) 2019 Michael Walle <michael@walle.cc>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a-kontron-sl28-var4.dts"
+
+/ {
+ model = "Kontron KBox A-230-LS";
+ compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var3",
+ "kontron,sl28", "fsl,ls1028a";
+};
+
+&i2c4 {
+ eeprom@50 {
+ compatible = "atmel,24c32";
+ reg = <0x50>;
+ pagesize = <32>;
+ };
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
new file mode 100644
index 000000000000..a4640e6b3928
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Device Tree file for the Kontron SMARC-sAL28 board on a SMARC Eval 2.0
+ * carrier (ADS2).
+ *
+ * Copyright (C) 2019 Michael Walle <michael@walle.cc>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a-kontron-sl28.dts"
+
+/ {
+ model = "Kontron SMARC-sAL28 (Single PHY) on SMARC Eval 2.0 carrier";
+ compatible = "kontron,sl28-var3-ads2", "kontron,sl28", "fsl,ls1028a";
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Headphone", "Headphone Jack",
+ "Line", "Line Out Jack";
+ simple-audio-card,routing =
+ "Line Out Jack", "LINEOUTR",
+ "Line Out Jack", "LINEOUTL",
+ "Headphone Jack", "HPOUTR",
+ "Headphone Jack", "HPOUTL";
+ simple-audio-card,mclk-fs = <256>;
+
+ simple-audio-card,cpu {
+ sound-dai = <&sai6>;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&wm8904>;
+ frame-master;
+ bitclock-master;
+ };
+ };
+};
+
+&i2c4 {
+ status = "okay";
+
+ wm8904: wm8904@1a {
+ #sound-dai-cells = <0>;
+ compatible = "wlf,wm8904";
+ reg = <0x1a>;
+ clocks = <&wm8904_mclk>;
+ clock-names = "mclk";
+ assigned-clocks = <&wm8904_mclk>;
+ assigned-clock-rates = <1250000>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c32";
+ reg = <0x50>;
+ pagesize = <32>;
+ };
+};
+
+&sai6 {
+ status = "okay";
+};
+
+&soc {
+ wm8904_mclk: wm8904-mclk@f130080 {
+ compatible = "fsl,vf610-sai-clock";
+ reg = <0x0 0xf130080 0x0 0x80>;
+ clocks = <&clockgen 4 1>;
+ #clock-cells = <0>;
+ };
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
new file mode 100644
index 000000000000..5c8b13108e4d
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Device Tree file for the Kontron SMARC-sAL28 board.
+ *
+ * This is for the network variant 4 which has two ethernet ports. It
+ * extends the base and provides one more port connected via RGMII.
+ *
+ * Copyright (C) 2019 Michael Walle <michael@walle.cc>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a-kontron-sl28.dts"
+
+/ {
+ model = "Kontron SMARC-sAL28 (Dual PHY)";
+ compatible = "kontron,sl28-var4", "kontron,sl28", "fsl,ls1028a";
+};
+
+&enetc_port1 {
+ phy-handle = <&phy1>;
+ phy-connection-type = "rgmii-id";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ phy1: ethernet-phy@4 {
+ reg = <0x4>;
+ eee-broken-1000t;
+ eee-broken-100tx;
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
new file mode 100644
index 000000000000..a18cb4395ad0
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -0,0 +1,158 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Device Tree file for the Kontron SMARC-sAL28 board.
+ *
+ * Copyright (C) 2019 Michael Walle <michael@walle.cc>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a.dtsi"
+
+/ {
+ model = "Kontron SMARC-sAL28";
+ compatible = "kontron,sl28", "fsl,ls1028a";
+
+ aliases {
+ crypto = &crypto;
+ serial0 = &duart0;
+ serial1 = &duart1;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+};
+
+&duart0 {
+ status = "okay";
+};
+
+&duart1 {
+ status = "okay";
+};
+
+&enetc_port0 {
+ phy-handle = <&phy0>;
+ phy-connection-type = "sgmii";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ phy0: ethernet-phy@5 {
+ reg = <0x5>;
+ eee-broken-1000t;
+ eee-broken-100tx;
+ };
+ };
+};
+
+&esdhc {
+ sd-uhs-sdr104;
+ sd-uhs-sdr50;
+ sd-uhs-sdr25;
+ sd-uhs-sdr12;
+ status = "okay";
+};
+
+&esdhc1 {
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ bus-width = <8>;
+ status = "okay";
+};
+
+&fspi {
+ status = "okay";
+
+ w25q32jw@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "w25q32jw", "jedec,spi-nor";
+ m25p,fast-read;
+ spi-max-frequency = <133000000>;
+ reg = <0>;
+ /* The following setting enables 1-1-2 (CMD-ADDR-DATA) mode */
+ spi-rx-bus-width = <2>; /* 2 SPI Rx lines */
+ spi-tx-bus-width = <1>; /* 1 SPI Tx line */
+
+ partition@0 {
+ reg = <0x000000 0x010000>;
+ label = "rcw";
+ read-only;
+ };
+
+ partition@10000 {
+ reg = <0x010000 0x0f0000>;
+ label = "failsafe bootloader";
+ read-only;
+ };
+
+ partition@100000 {
+ reg = <0x100000 0x040000>;
+ label = "failsafe DP firmware";
+ read-only;
+ };
+
+ partition@140000 {
+ reg = <0x140000 0x0a0000>;
+ label = "failsafe trusted firmware";
+ read-only;
+ };
+
+ partition@1e0000 {
+ reg = <0x1e0000 0x020000>;
+ label = "reserved";
+ read-only;
+ };
+
+ partition@200000 {
+ reg = <0x200000 0x010000>;
+ label = "configuration store";
+ };
+
+ partition@210000 {
+ reg = <0x210000 0x0f0000>;
+ label = "bootloader";
+ };
+
+ partition@300000 {
+ reg = <0x300000 0x040000>;
+ label = "DP firmware";
+ };
+
+ partition@340000 {
+ reg = <0x340000 0x0a0000>;
+ label = "trusted firmware";
+ };
+
+ partition@3e0000 {
+ reg = <0x3e0000 0x020000>;
+ label = "bootloader environment";
+ };
+ };
+};
+
+&i2c0 {
+ status = "okay";
+
+ rtc@32 {
+ compatible = "microcrystal,rv8803";
+ reg = <0x32>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c32";
+ reg = <0x50>;
+ pagesize = <32>;
+ };
+};
+
+&i2c3 {
+ status = "okay";
+};
+
+&i2c4 {
+ status = "okay";
+};
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] arm64: dts: freescale: add Kontron sl28 support
2019-11-23 20:13 ` [PATCH 4/4] arm64: dts: freescale: add Kontron sl28 support Michael Walle
@ 2019-12-09 6:43 ` Shawn Guo
2019-12-09 8:54 ` Michael Walle
0 siblings, 1 reply; 14+ messages in thread
From: Shawn Guo @ 2019-12-09 6:43 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
On Sat, Nov 23, 2019 at 09:13:17PM +0100, Michael Walle wrote:
> Add device tree files for the Kontron SMARC-sAL28 board and its
> carriers.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 4 +
> .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 27 +++
> .../fsl-ls1028a-kontron-sl28-var3-ads2.dts | 73 ++++++++
> .../fsl-ls1028a-kontron-sl28-var4.dts | 34 ++++
> .../freescale/fsl-ls1028a-kontron-sl28.dts | 158 ++++++++++++++++++
> 5 files changed, 296 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 93fce8f0c66d..080c5a59d6bd 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -4,6 +4,10 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-oxalis.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-kbox-a-230-ls.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28-var3-ads2.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28-var4.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> new file mode 100644
> index 000000000000..97e72c94b7fc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -0,0 +1,27 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Device Tree File for the Kontron KBox A-230-LS.
> + *
> + * This consists of a Kontron SMARC-sAL28 (Dual PHY) and a special
> + * carrier (s1914).
> + *
> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
> + *
> + */
> +
> +/dts-v1/;
> +#include "fsl-ls1028a-kontron-sl28-var4.dts"
> +
> +/ {
> + model = "Kontron KBox A-230-LS";
> + compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var3",
> + "kontron,sl28", "fsl,ls1028a";
Any new compatible needs to be documented.
> +};
> +
> +&i2c4 {
> + eeprom@50 {
> + compatible = "atmel,24c32";
> + reg = <0x50>;
> + pagesize = <32>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> new file mode 100644
> index 000000000000..a4640e6b3928
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> @@ -0,0 +1,73 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Device Tree file for the Kontron SMARC-sAL28 board on a SMARC Eval 2.0
> + * carrier (ADS2).
> + *
> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
> + *
> + */
> +
> +/dts-v1/;
> +#include "fsl-ls1028a-kontron-sl28.dts"
> +
> +/ {
> + model = "Kontron SMARC-sAL28 (Single PHY) on SMARC Eval 2.0 carrier";
> + compatible = "kontron,sl28-var3-ads2", "kontron,sl28", "fsl,ls1028a";
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Headphone", "Headphone Jack",
> + "Line", "Line Out Jack";
> + simple-audio-card,routing =
> + "Line Out Jack", "LINEOUTR",
> + "Line Out Jack", "LINEOUTL",
> + "Headphone Jack", "HPOUTR",
> + "Headphone Jack", "HPOUTL";
> + simple-audio-card,mclk-fs = <256>;
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai6>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&wm8904>;
> + frame-master;
> + bitclock-master;
> + };
> + };
> +};
> +
> +&i2c4 {
> + status = "okay";
> +
> + wm8904: wm8904@1a {
audio-codec for node name.
> + #sound-dai-cells = <0>;
> + compatible = "wlf,wm8904";
> + reg = <0x1a>;
> + clocks = <&wm8904_mclk>;
> + clock-names = "mclk";
> + assigned-clocks = <&wm8904_mclk>;
> + assigned-clock-rates = <1250000>;
> + };
> +
> + eeprom@50 {
> + compatible = "atmel,24c32";
> + reg = <0x50>;
> + pagesize = <32>;
> + };
> +};
> +
> +&sai6 {
> + status = "okay";
> +};
> +
> +&soc {
> + wm8904_mclk: wm8904-mclk@f130080 {
> + compatible = "fsl,vf610-sai-clock";
Unsupported/undocumented binding?
> + reg = <0x0 0xf130080 0x0 0x80>;
> + clocks = <&clockgen 4 1>;
> + #clock-cells = <0>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
> new file mode 100644
> index 000000000000..5c8b13108e4d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Device Tree file for the Kontron SMARC-sAL28 board.
> + *
> + * This is for the network variant 4 which has two ethernet ports. It
> + * extends the base and provides one more port connected via RGMII.
> + *
> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
> + *
> + */
> +
> +/dts-v1/;
> +#include "fsl-ls1028a-kontron-sl28.dts"
> +
> +/ {
> + model = "Kontron SMARC-sAL28 (Dual PHY)";
> + compatible = "kontron,sl28-var4", "kontron,sl28", "fsl,ls1028a";
> +};
> +
> +&enetc_port1 {
> + phy-handle = <&phy1>;
> + phy-connection-type = "rgmii-id";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + phy1: ethernet-phy@4 {
> + reg = <0x4>;
> + eee-broken-1000t;
> + eee-broken-100tx;
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> new file mode 100644
> index 000000000000..a18cb4395ad0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -0,0 +1,158 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Device Tree file for the Kontron SMARC-sAL28 board.
> + *
> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
> + *
> + */
> +
> +/dts-v1/;
> +#include "fsl-ls1028a.dtsi"
> +
> +/ {
> + model = "Kontron SMARC-sAL28";
> + compatible = "kontron,sl28", "fsl,ls1028a";
> +
> + aliases {
> + crypto = &crypto;
> + serial0 = &duart0;
> + serial1 = &duart1;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> +
> +&duart1 {
> + status = "okay";
> +};
> +
> +&enetc_port0 {
> + phy-handle = <&phy0>;
> + phy-connection-type = "sgmii";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + phy0: ethernet-phy@5 {
> + reg = <0x5>;
> + eee-broken-1000t;
> + eee-broken-100tx;
> + };
> + };
> +};
> +
> +&esdhc {
> + sd-uhs-sdr104;
> + sd-uhs-sdr50;
> + sd-uhs-sdr25;
> + sd-uhs-sdr12;
> + status = "okay";
> +};
> +
> +&esdhc1 {
> + mmc-hs200-1_8v;
> + mmc-hs400-1_8v;
> + bus-width = <8>;
> + status = "okay";
> +};
> +
> +&fspi {
> + status = "okay";
> +
> + w25q32jw@0 {
Use a generic node name.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "w25q32jw", "jedec,spi-nor";
Is "w25q32jw" documented somewhere?
Shawn
> + m25p,fast-read;
> + spi-max-frequency = <133000000>;
> + reg = <0>;
> + /* The following setting enables 1-1-2 (CMD-ADDR-DATA) mode */
> + spi-rx-bus-width = <2>; /* 2 SPI Rx lines */
> + spi-tx-bus-width = <1>; /* 1 SPI Tx line */
> +
> + partition@0 {
> + reg = <0x000000 0x010000>;
> + label = "rcw";
> + read-only;
> + };
> +
> + partition@10000 {
> + reg = <0x010000 0x0f0000>;
> + label = "failsafe bootloader";
> + read-only;
> + };
> +
> + partition@100000 {
> + reg = <0x100000 0x040000>;
> + label = "failsafe DP firmware";
> + read-only;
> + };
> +
> + partition@140000 {
> + reg = <0x140000 0x0a0000>;
> + label = "failsafe trusted firmware";
> + read-only;
> + };
> +
> + partition@1e0000 {
> + reg = <0x1e0000 0x020000>;
> + label = "reserved";
> + read-only;
> + };
> +
> + partition@200000 {
> + reg = <0x200000 0x010000>;
> + label = "configuration store";
> + };
> +
> + partition@210000 {
> + reg = <0x210000 0x0f0000>;
> + label = "bootloader";
> + };
> +
> + partition@300000 {
> + reg = <0x300000 0x040000>;
> + label = "DP firmware";
> + };
> +
> + partition@340000 {
> + reg = <0x340000 0x0a0000>;
> + label = "trusted firmware";
> + };
> +
> + partition@3e0000 {
> + reg = <0x3e0000 0x020000>;
> + label = "bootloader environment";
> + };
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +
> + rtc@32 {
> + compatible = "microcrystal,rv8803";
> + reg = <0x32>;
> + };
> +
> + eeprom@50 {
> + compatible = "atmel,24c32";
> + reg = <0x50>;
> + pagesize = <32>;
> + };
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> +};
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] arm64: dts: freescale: add Kontron sl28 support
2019-12-09 6:43 ` Shawn Guo
@ 2019-12-09 8:54 ` Michael Walle
0 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2019-12-09 8:54 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
Am 2019-12-09 07:43, schrieb Shawn Guo:
> On Sat, Nov 23, 2019 at 09:13:17PM +0100, Michael Walle wrote:
>> Add device tree files for the Kontron SMARC-sAL28 board and its
>> carriers.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/Makefile | 4 +
>> .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 27 +++
>> .../fsl-ls1028a-kontron-sl28-var3-ads2.dts | 73 ++++++++
>> .../fsl-ls1028a-kontron-sl28-var4.dts | 34 ++++
>> .../freescale/fsl-ls1028a-kontron-sl28.dts | 158
>> ++++++++++++++++++
>> 5 files changed, 296 insertions(+)
>> create mode 100644
>> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
>> create mode 100644
>> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
>> create mode 100644
>> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
>> create mode 100644
>> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
>>
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile
>> b/arch/arm64/boot/dts/freescale/Makefile
>> index 93fce8f0c66d..080c5a59d6bd 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -4,6 +4,10 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-oxalis.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) +=
>> fsl-ls1028a-kontron-kbox-a-230-ls.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) +=
>> fsl-ls1028a-kontron-sl28-var3-ads2.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-kontron-sl28-var4.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-rdb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
>> diff --git
>> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
>> new file mode 100644
>> index 000000000000..97e72c94b7fc
>> --- /dev/null
>> +++
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
>> @@ -0,0 +1,27 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Device Tree File for the Kontron KBox A-230-LS.
>> + *
>> + * This consists of a Kontron SMARC-sAL28 (Dual PHY) and a special
>> + * carrier (s1914).
>> + *
>> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
>> + *
>> + */
>> +
>> +/dts-v1/;
>> +#include "fsl-ls1028a-kontron-sl28-var4.dts"
>> +
>> +/ {
>> + model = "Kontron KBox A-230-LS";
>> + compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var3",
>> + "kontron,sl28", "fsl,ls1028a";
>
> Any new compatible needs to be documented.
There is actually no ls1028a board documented ;) I'd add the rdb as well
as the qds to Documentation/devicetree/bindings/arm/fsl.yaml in the next
series. Or is that just for arm and not arm64?
>
>> +};
>> +
>> +&i2c4 {
>> + eeprom@50 {
>> + compatible = "atmel,24c32";
>> + reg = <0x50>;
>> + pagesize = <32>;
>> + };
>> +};
>> diff --git
>> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
>> new file mode 100644
>> index 000000000000..a4640e6b3928
>> --- /dev/null
>> +++
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
>> @@ -0,0 +1,73 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Device Tree file for the Kontron SMARC-sAL28 board on a SMARC Eval
>> 2.0
>> + * carrier (ADS2).
>> + *
>> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
>> + *
>> + */
>> +
>> +/dts-v1/;
>> +#include "fsl-ls1028a-kontron-sl28.dts"
>> +
>> +/ {
>> + model = "Kontron SMARC-sAL28 (Single PHY) on SMARC Eval 2.0
>> carrier";
>> + compatible = "kontron,sl28-var3-ads2", "kontron,sl28",
>> "fsl,ls1028a";
>> +
>> + sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,widgets =
>> + "Headphone", "Headphone Jack",
>> + "Line", "Line Out Jack";
>> + simple-audio-card,routing =
>> + "Line Out Jack", "LINEOUTR",
>> + "Line Out Jack", "LINEOUTL",
>> + "Headphone Jack", "HPOUTR",
>> + "Headphone Jack", "HPOUTL";
>> + simple-audio-card,mclk-fs = <256>;
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&sai6>;
>> + };
>> +
>> + simple-audio-card,codec {
>> + sound-dai = <&wm8904>;
>> + frame-master;
>> + bitclock-master;
>> + };
>> + };
>> +};
>> +
>> +&i2c4 {
>> + status = "okay";
>> +
>> + wm8904: wm8904@1a {
>
> audio-codec for node name.
ok
>
>> + #sound-dai-cells = <0>;
>> + compatible = "wlf,wm8904";
>> + reg = <0x1a>;
>> + clocks = <&wm8904_mclk>;
>> + clock-names = "mclk";
>> + assigned-clocks = <&wm8904_mclk>;
>> + assigned-clock-rates = <1250000>;
>> + };
>> +
>> + eeprom@50 {
>> + compatible = "atmel,24c32";
>> + reg = <0x50>;
>> + pagesize = <32>;
>> + };
>> +};
>> +
>> +&sai6 {
>> + status = "okay";
>> +};
>> +
>> +&soc {
>> + wm8904_mclk: wm8904-mclk@f130080 {
>> + compatible = "fsl,vf610-sai-clock";
>
> Unsupported/undocumented binding?
under review here:
https://lore.kernel.org/linux-devicetree/20191122235622.8818-1-michael@walle.cc/
>
>> + reg = <0x0 0xf130080 0x0 0x80>;
>> + clocks = <&clockgen 4 1>;
>> + #clock-cells = <0>;
>> + };
>> +};
>> diff --git
>> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
>> new file mode 100644
>> index 000000000000..5c8b13108e4d
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
>> @@ -0,0 +1,34 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Device Tree file for the Kontron SMARC-sAL28 board.
>> + *
>> + * This is for the network variant 4 which has two ethernet ports. It
>> + * extends the base and provides one more port connected via RGMII.
>> + *
>> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
>> + *
>> + */
>> +
>> +/dts-v1/;
>> +#include "fsl-ls1028a-kontron-sl28.dts"
>> +
>> +/ {
>> + model = "Kontron SMARC-sAL28 (Dual PHY)";
>> + compatible = "kontron,sl28-var4", "kontron,sl28", "fsl,ls1028a";
>> +};
>> +
>> +&enetc_port1 {
>> + phy-handle = <&phy1>;
>> + phy-connection-type = "rgmii-id";
>> +
>> + mdio {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + phy1: ethernet-phy@4 {
>> + reg = <0x4>;
>> + eee-broken-1000t;
>> + eee-broken-100tx;
>> + };
>> + };
>> +};
>> diff --git
>> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
>> new file mode 100644
>> index 000000000000..a18cb4395ad0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
>> @@ -0,0 +1,158 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Device Tree file for the Kontron SMARC-sAL28 board.
>> + *
>> + * Copyright (C) 2019 Michael Walle <michael@walle.cc>
>> + *
>> + */
>> +
>> +/dts-v1/;
>> +#include "fsl-ls1028a.dtsi"
>> +
>> +/ {
>> + model = "Kontron SMARC-sAL28";
>> + compatible = "kontron,sl28", "fsl,ls1028a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + serial0 = &duart0;
>> + serial1 = &duart1;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0:115200n8";
>> + };
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> +
>> +&duart1 {
>> + status = "okay";
>> +};
>> +
>> +&enetc_port0 {
>> + phy-handle = <&phy0>;
>> + phy-connection-type = "sgmii";
>> +
>> + mdio {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + phy0: ethernet-phy@5 {
>> + reg = <0x5>;
>> + eee-broken-1000t;
>> + eee-broken-100tx;
>> + };
>> + };
>> +};
>> +
>> +&esdhc {
>> + sd-uhs-sdr104;
>> + sd-uhs-sdr50;
>> + sd-uhs-sdr25;
>> + sd-uhs-sdr12;
>> + status = "okay";
>> +};
>> +
>> +&esdhc1 {
>> + mmc-hs200-1_8v;
>> + mmc-hs400-1_8v;
>> + bus-width = <8>;
>> + status = "okay";
>> +};
>> +
>> +&fspi {
>> + status = "okay";
>> +
>> + w25q32jw@0 {
>
> Use a generic node name.
>
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "w25q32jw", "jedec,spi-nor";
>
> Is "w25q32jw" documented somewhere?
seems like it should only be "jedec,spi-nor" anyway:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=10a6a6975691775bbcc677a04c6fd3120b5c1160
I'll send a v2 series. There were updates to the sound node in the
meantime.
>
> Shawn
>
>> + m25p,fast-read;
>> + spi-max-frequency = <133000000>;
>> + reg = <0>;
>> + /* The following setting enables 1-1-2 (CMD-ADDR-DATA) mode */
>> + spi-rx-bus-width = <2>; /* 2 SPI Rx lines */
>> + spi-tx-bus-width = <1>; /* 1 SPI Tx line */
>> +
>> + partition@0 {
>> + reg = <0x000000 0x010000>;
>> + label = "rcw";
>> + read-only;
>> + };
>> +
>> + partition@10000 {
>> + reg = <0x010000 0x0f0000>;
>> + label = "failsafe bootloader";
>> + read-only;
>> + };
>> +
>> + partition@100000 {
>> + reg = <0x100000 0x040000>;
>> + label = "failsafe DP firmware";
>> + read-only;
>> + };
>> +
>> + partition@140000 {
>> + reg = <0x140000 0x0a0000>;
>> + label = "failsafe trusted firmware";
>> + read-only;
>> + };
>> +
>> + partition@1e0000 {
>> + reg = <0x1e0000 0x020000>;
>> + label = "reserved";
>> + read-only;
>> + };
>> +
>> + partition@200000 {
>> + reg = <0x200000 0x010000>;
>> + label = "configuration store";
>> + };
>> +
>> + partition@210000 {
>> + reg = <0x210000 0x0f0000>;
>> + label = "bootloader";
>> + };
>> +
>> + partition@300000 {
>> + reg = <0x300000 0x040000>;
>> + label = "DP firmware";
>> + };
>> +
>> + partition@340000 {
>> + reg = <0x340000 0x0a0000>;
>> + label = "trusted firmware";
>> + };
>> +
>> + partition@3e0000 {
>> + reg = <0x3e0000 0x020000>;
>> + label = "bootloader environment";
>> + };
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>> +
>> + rtc@32 {
>> + compatible = "microcrystal,rv8803";
>> + reg = <0x32>;
>> + };
>> +
>> + eeprom@50 {
>> + compatible = "atmel,24c32";
>> + reg = <0x50>;
>> + pagesize = <32>;
>> + };
>> +};
>> +
>> +&i2c3 {
>> + status = "okay";
>> +};
>> +
>> +&i2c4 {
>> + status = "okay";
>> +};
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 14+ messages in thread