From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A07C4338F for ; Wed, 25 Aug 2021 10:54:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAA0C610D0 for ; Wed, 25 Aug 2021 10:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238324AbhHYKzN convert rfc822-to-8bit (ORCPT ); Wed, 25 Aug 2021 06:55:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231697AbhHYKzN (ORCPT ); Wed, 25 Aug 2021 06:55:13 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA51C061757 for ; Wed, 25 Aug 2021 03:54:27 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIqY1-0008Pr-PV; Wed, 25 Aug 2021 12:54:21 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mIqY1-0002Ry-75; Wed, 25 Aug 2021 12:54:21 +0200 Message-ID: Subject: Re: [PATCH v2 9/9] clk: imx: Add the pcc reset controller support on imx8ulp From: Philipp Zabel To: Jacky Bai , "shawnguo@kernel.org" , "robh+dt@kernel.org" , Abel Vesa , "sboyd@kernel.org" , "s.hauer@pengutronix.de" Cc: "kernel@pengutronix.de" , dl-linux-imx , "devicetree@vger.kernel.org" Date: Wed, 25 Aug 2021 12:54:21 +0200 In-Reply-To: References: <20210810062820.1062884-1-ping.bai@nxp.com> <20210810062820.1062884-10-ping.bai@nxp.com> <197a021684ea01ba50b3ab86f71525878042a8ee.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 2021-08-23 at 23:58 +0000, Jacky Bai wrote: [...] > > > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index > > > b81d6437ed95..0d1e3a6ac32a 100644 > > > --- a/drivers/clk/imx/Kconfig > > > +++ b/drivers/clk/imx/Kconfig > > > @@ -102,5 +102,6 @@ config CLK_IMX8QXP config CLK_IMX8ULP > > > tristate "IMX8ULP CCM Clock Driver" > > > depends on ARCH_MXC || COMPILE_TEST > > > + select RESET_CONTROLLER > > > > This shouldn't be required anymore, devm_reset_controller_register() has a > > stub since commit 48a74b1147f7 ("reset: Add compile-test stubs"). > > So we don't need to select 'RESET_CONTROLLER' explicitly, right? Right. regards Philipp