From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C376EC3F68F for ; Thu, 16 Jan 2020 11:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9511F207FF for ; Thu, 16 Jan 2020 11:27:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nEFmlIIk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726151AbgAPL1n (ORCPT ); Thu, 16 Jan 2020 06:27:43 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:48494 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbgAPL1n (ORCPT ); Thu, 16 Jan 2020 06:27:43 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 00GBRGdj061689; Thu, 16 Jan 2020 05:27:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1579174036; bh=myfrgAkACHwJfmdNtMcuEJNJskU9ZB6VVutnIR84JH4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nEFmlIIkHRmg720elyKMOm+dhwS+GmQz54J/Pk0oyMkOmh+nf69RXMnk221Fm2/e7 NSzzCU2NpIciRM4d5s7zg63jd0GcYITe/s87EiYMWMO+9mg4DS68MEI0wBotVnoNJ0 KvXPQQC6+eWZhLjEpa5vffjlE8C0JzoLPGRujhCI= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 00GBRGVV021247 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Jan 2020 05:27:16 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 16 Jan 2020 05:27:16 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 16 Jan 2020 05:27:15 -0600 Received: from [10.24.69.159] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00GBR8Tb095885; Thu, 16 Jan 2020 05:27:11 -0600 Subject: Re: [PATCH 2/7] dt-bindings: PCI: cadence: Add binding to specify max virtual functions To: Rob Herring CC: Lorenzo Pieralisi , Bjorn Helgaas , Andrew Murray , Tom Joseph , Arnd Bergmann , Jingoo Han , Gustavo Pimentel , Shawn Lin , Heiko Stuebner , , , Jonathan Corbet , Greg Kroah-Hartman , , , , References: <20191231113534.30405-1-kishon@ti.com> <20191231113534.30405-3-kishon@ti.com> <20200115014026.GA10726@bogus> From: Kishon Vijay Abraham I Message-ID: Date: Thu, 16 Jan 2020 16:59:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20200115014026.GA10726@bogus> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On 15/01/20 7:10 AM, Rob Herring wrote: > On Tue, Dec 31, 2019 at 05:05:29PM +0530, Kishon Vijay Abraham I wrote: >> Add binding to specify maximum number of virtual functions that can be >> associated with each physical function. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> .../devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 2 ++ >> .../devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 8 ++++++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt >> index 4a0475e2ba7e..432578202733 100644 >> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt >> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt >> @@ -9,6 +9,8 @@ Required properties: >> >> Optional properties: >> - max-functions: Maximum number of functions that can be configured (default 1). >> +- max-virtual-functions: Maximum number of virtual functions that can be >> + associated with each physical function. >> - phys: From PHY bindings: List of Generic PHY phandles. One per lane if more >> than one in the list. If only one PHY listed it must manage all lanes. >> - phy-names: List of names to identify the PHY. >> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >> index 4621c62016c7..1d4964ba494f 100644 >> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >> @@ -61,6 +61,12 @@ properties: >> minimum: 1 >> maximum: 6 >> >> + max-virtual-functions: >> + minItems: 1 >> + maxItems: 6 > > Is there a PCIe spec limit to number of virtual functions per phy > function? Or 2^32 virtual functions is okay. The PCIe spec provides a 16 bit field to specify number of virtual functions in the SR-IOV extended capability. > >> + description: As defined in >> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt > > I suspect this this be a common property. Right now we don't have common EP property binding across all controllers. Maybe should create one? Thanks Kishon