From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
Stefan Wahren <wahrenst@gmx.net>, Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH V2 2/4] thermal: Add BCM2711 thermal driver
Date: Tue, 07 Jan 2020 12:28:26 +0100 [thread overview]
Message-ID: <f14bad2513cde4e57af21fdc971638c74db9ba50.camel@suse.de> (raw)
In-Reply-To: <98b424ff-040c-b68c-04d3-823c771986fa@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]
On Mon, 2020-01-06 at 14:30 -0800, Florian Fainelli wrote:
> Hi Stefan,
>
> On 1/3/20 9:23 AM, Stefan Wahren wrote:
> > This adds the thermal sensor driver for the Broadcom BCM2711 SoC,
> > which is placed on the Raspberry Pi 4. The driver only provides
> > SoC temperature reading so far.
> >
> > Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>
> This looks good, I just have a couple of nits that you can address since
> the binding needs to be re-spun, see below, in any case:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> [snip]
>
> > + of_node_put(parent);
> > + if (IS_ERR(regmap)) {
> > + dev_err(dev, "failed to get regmap (error %ld)\n",
> > + PTR_ERR(regmap));
>
> Here we use %ld
>
> > + return PTR_ERR(regmap);
> > + }
> > + priv->regmap = regmap;
> > + priv->dev = dev;
> > +
> > + thermal = devm_thermal_zone_of_sensor_register(dev, 0, priv,
> > + &bcm2711_thermal_of_ops);
> > + if (IS_ERR(thermal)) {
> > + ret = PTR_ERR(thermal);
> > + dev_err(dev, "could not register sensor: %d\n", ret);
>
> and here we do an implicit cast into int, thus using %d, could we just
> make both consistent and use %d?
Extra nit since you're changing this. I'd suggest keeping the same format
between error messages (i.e. one encloses the error message between parentheses
and the other uses a colon).
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-07 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 17:23 [PATCH V2 0/4] ARM: Enable thermal support for Raspberry Pi 4 Stefan Wahren
2020-01-03 17:23 ` [PATCH V2 1/4] dt-bindings: Add Broadcom AVS RO thermal Stefan Wahren
2020-01-06 22:15 ` Rob Herring
2020-01-03 17:23 ` [PATCH V2 2/4] thermal: Add BCM2711 thermal driver Stefan Wahren
2020-01-06 22:30 ` Florian Fainelli
2020-01-07 11:28 ` Nicolas Saenz Julienne [this message]
2020-01-03 17:23 ` [PATCH V2 3/4] ARM: dts: bcm2711: Enable thermal Stefan Wahren
2020-01-03 17:23 ` [PATCH V2 4/4] ARM: configs: Build BCM2711 thermal as module Stefan Wahren
2020-01-06 22:39 ` [PATCH V2 0/4] ARM: Enable thermal support for Raspberry Pi 4 Florian Fainelli
2020-01-07 14:14 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14bad2513cde4e57af21fdc971638c74db9ba50.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=amit.kucheria@verdurent.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wahrenst@gmx.net \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).