devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: James Tai <james.tai@realtek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	'DTML' <devicetree@vger.kernel.org>,
	"linux-realtek-soc@lists.infradead.org" 
	<linux-realtek-soc@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/2] Initial RTD1619 SoC and Realtek Mjolnir EVB support
Date: Mon, 11 Nov 2019 05:18:40 +0100	[thread overview]
Message-ID: <f2ce8745-e056-06a5-3d55-b00ab4d82414@suse.de> (raw)
In-Reply-To: <43B123F21A8CFE44A9641C099E4196FFCF91F9CB@RTITMBSVM04.realtek.com.tw>

Hi James,

Am 08.11.19 um 10:42 schrieb James Tai:
> This series adds Device Trees for the Realtek RTD1619 SoC and Realtek's
> Mjolnir EVB.
> 
> v1 -> v2:
> * Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir
> * Add uart1 and uart2 device node into rtd16xx.dtsi
> * move cpus node and the interrupt-affinity into rtd16xx.dtsi
> * Specify the r-bus ranges

With the exception of r-bus this is getting pretty good already.
Two formal improvements:

1) The patches 1/2 and 2/2 are expected to be threaded to 0/2 (but not
2/2 to 1/2). Please check your git [sendemail] config or use --thread
--no-chain-reply-to. That helps keep the series together when people
start replying to individual patches. If your Git config seems correct,
it might also be an issue with your SMTP server.

2) Please also include a per-patch changelog like I do. I privately
shared a script how I do that in a reproducible way. This benefits
reviewers not getting CC'ed on the cover letter as well as users of the
Patchwork web interface.

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

  reply	other threads:[~2019-11-11  4:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08  9:42 [PATCH v2 0/2] Initial RTD1619 SoC and Realtek Mjolnir EVB support James Tai
2019-11-11  4:18 ` Andreas Färber [this message]
2019-11-13  2:19   ` James Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2ce8745-e056-06a5-3d55-b00ab4d82414@suse.de \
    --to=afaerber@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=james.tai@realtek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).