From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CB1C3F2D2 for ; Mon, 2 Mar 2020 10:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 947D821739 for ; Mon, 2 Mar 2020 10:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727452AbgCBKeb (ORCPT ); Mon, 2 Mar 2020 05:34:31 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:59109 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727095AbgCBKeb (ORCPT ); Mon, 2 Mar 2020 05:34:31 -0500 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1j8iP7-0005zu-RZ; Mon, 02 Mar 2020 11:34:29 +0100 Subject: Re: [PATCH 2/3] ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board To: Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com, Rob Herring , Mark Rutland Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200226143826.1146-1-a.fatoum@pengutronix.de> <20200226143826.1146-2-a.fatoum@pengutronix.de> <244a4502-03e0-836c-2ce2-7fa6cef3c188@st.com> From: Ahmad Fatoum Message-ID: Date: Mon, 2 Mar 2020 11:34:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <244a4502-03e0-836c-2ce2-7fa6cef3c188@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, On 3/2/20 11:06 AM, Alexandre Torgue wrote: >> +ðernet0 { > > you could follow alphabetic ordering (I find it easier to read, but just my opinion). >> +&pinctrl { > > Pin groups are currently defined in stm32mp15-pinctrl.dtsi. You could move this part. >> +&m4_rproc { > > you could follow alphabetic ordering. Will do. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |