From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763ECC76196 for ; Tue, 28 Mar 2023 08:07:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjC1IHb (ORCPT ); Tue, 28 Mar 2023 04:07:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjC1IHb (ORCPT ); Tue, 28 Mar 2023 04:07:31 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D90FC193; Tue, 28 Mar 2023 01:07:29 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32S7j1c8014543; Tue, 28 Mar 2023 08:07:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=8dxXEASTuugZX06RZvf5bwr82eM3WswKmCdFTJR9cdY=; b=iWiGtqPGi4P5bX4Xq742PWjUTq56iK9awn9U+/raar123tjnGQIUxoX9AGP5akJ4/iBO ftAzlkbq1LvHKivQFdxx7OXPubwOuRsIn3WipvxDfiFevM9m6dPwlQdsXH+4qIkgwfdG LhoAVNaUsKJYXG45KMupHrJKJFZclkjf1/BUBQ/MMzm7fKrlcJyJRPVgNcND5fnwBsHO 8BjboRvwSk0CLBRtMfO7LsTsasTtD/QQxnPGhYmHC1jxal2m3tV16vn8/slPhFKr9ETE eBRkzFpnbUZICcUXXB6iux7dNhTMShflsCIj5qXlyyjspFJ1viVUZ/i2zC1mMsTmJyFC KQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pkv45g1kh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Mar 2023 08:07:14 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32S87DQ3028377 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Mar 2023 08:07:13 GMT Received: from [10.233.17.245] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 28 Mar 2023 01:07:06 -0700 Message-ID: Date: Tue, 28 Mar 2023 16:07:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 3/3] Documentation: trace: Add documentation for Coresight Dummy Trace Content-Language: en-US To: Bagas Sanjaya , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski , Andy Gross , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , Jonathan Corbet CC: Leo Yan , Greg Kroah-Hartman , , , , , Tingwei Zhang , Jinlong Mao , Yuanfang Zhang , Tao Zhang , Trilok Soni , , Bjorn Andersson , References: <20230324061608.33609-1-quic_hazha@quicinc.com> <20230324061608.33609-4-quic_hazha@quicinc.com> From: Hao Zhang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: D_SNVCOQQfo8XtW0QfJGFO5RGS_HwTYp X-Proofpoint-ORIG-GUID: D_SNVCOQQfo8XtW0QfJGFO5RGS_HwTYp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-27_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 impostorscore=0 clxscore=1011 mlxlogscore=674 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303280067 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bagas, On 3/27/2023 5:06 PM, Bagas Sanjaya wrote: > On Fri, Mar 24, 2023 at 02:16:08PM +0800, Hao Zhang wrote: >> +Sysfs files and directories >> +--------------------------- >> + >> +Root: ``/sys/bus/coresight/devices/dummy`` >> + >> +---- >> + >> +:File: ``enable_source`` (RW) >> +:Notes: >> + - > 0 : enable the datasets of dummy source. >> + >> + - = 0 : disable the datasets of dummy source. >> + >> +:Syntax: >> + ``echo 1 > enable_source`` >> + >> +---- >> + >> +:File: ``enable_sink`` (RW) >> +:Notes: >> + - > 0 : enable the datasets of dummy sink. >> + >> + - = 0 : disable the datasets of dummy sink. >> + >> +:Syntax: >> + ``echo 1 > enable_sink`` > > Is enable_{source,sink} integer-valued or bit (0/1)? In other words, is > it OK to `echo 2` to both sysfs files? It should be the integer value, that is OK to "echo 2" to the sysfs files. >> + >> +---- >> + >> +Config details >> +--------------------------- >> + >> +There are two types of nodes, dummy sink and dummy source. The nodes >> +should be observed at the coresight path >> +"/sys/bus/coresight/devices". > > For consistency, inline this sysfs also (thus > ``/sys/bus/coresight/devices``. > >> +e.g. > e.g.:: (make the shell snippet below code block) I will correct it in the next version of patch. >> +/sys/bus/coresight/devices # ls -l | grep dummy > IMO I prefer `PS1=\$` (that is, omit the directory). Alternatively, > you can write `ls -l /sys/bus/coresight/devices | grep dummy` (specify > the directory to `ls`). > > Thanks. > Thanks for your comments, I will take your advice in the next version of patch. Thanks, Hao