From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82AB2C2D0CD for ; Wed, 18 Dec 2019 07:22:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 592EC24650 for ; Wed, 18 Dec 2019 07:22:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pCj4uRkC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725955AbfLRHWk (ORCPT ); Wed, 18 Dec 2019 02:22:40 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:43361 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbfLRHWk (ORCPT ); Wed, 18 Dec 2019 02:22:40 -0500 Received: by mail-lj1-f193.google.com with SMTP id a13so917950ljm.10; Tue, 17 Dec 2019 23:22:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0kDe50ALVQajh6COpe/UrxaPqNhglA1COxptN576YIM=; b=pCj4uRkCyElj5AeAO5PhsJESJOcxLi4qjraZ6wE173qh+gVANwSEFgRRvuqNXU7Z4w W01fR/62kXh0HVEz00f2md4HFbscdix0rrSM36rmN2py46usLkJMPGssK3kgyxYMC+Kq aa7uWenRckWg20Z/7YkT90pDE+ks1NPyRe4KqidckCN4Jh0Ty/ULjyjFGIG1G/up7B+I ikpX9SEKZ+yDCUTpAIg5Knru+PfbtB6sxdm9M0JUWOHzWN4dGmzlytA1++4zwkUDPMlv 4wT3oNxka7EmkFHUVmyfSbUCmNkHNP0dC5EyHPAxsI5icBgoCYOyeiUMTdjQ1Wa7lJh/ T7GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0kDe50ALVQajh6COpe/UrxaPqNhglA1COxptN576YIM=; b=dX45eKjxTrPeyKEzagQl9nHWAI/xqxIl1CwWSxUZdX+TEBjcRRXMOv11bgBicd466c zsgvg/G/Es/QvsH6Hy8pTbpqFU4v/50p/aNHC77jQG8o0OcRnBVFqGb0UyLCQAPH9kNU YW/ZfCDKUgnjd/Sa/hxPmAqIwWBj0YVhC2dnwil82nIJjS8akeMGXsUGuJPHx5Mi9Nwp NJzvprqiGmjIRB+rMVFRDARaP7DY4K49HmdW2ZQe+AxVVf8bwlr/KaoAVy61SDtUvuOL d/wGfI/gKPKcdyg3aiq7kFHMJ8i5mxyb1z2UxBdJyIRlWI/bscHqaoBZMJTRz14RVn4p Tnkw== X-Gm-Message-State: APjAAAUySj7bFXohnd40oAHGI+/7ISRav24kn1KGwokqSjIFteIFejPG tNek5BZDRpqB1OdJVaVc4f94Sf2p X-Google-Smtp-Source: APXvYqx4q8Lo5ENz2d2213O4WJ4yJft3sdaSBhYmMm5b6i5wZcbshZnhduxktZugC2Pnx+ObZIq64g== X-Received: by 2002:a2e:808a:: with SMTP id i10mr581799ljg.151.1576653757235; Tue, 17 Dec 2019 23:22:37 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id 144sm588949lfi.67.2019.12.17.23.22.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 23:22:36 -0800 (PST) Subject: Re: [PATCH v4 13/19] ASoC: tegra: Add fallback implementation for audio mclk To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, spujar@nvidia.com, josephl@nvidia.com, daniel.lezcano@linaro.org, mmaddireddy@nvidia.com, markz@nvidia.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1576613046-17159-1-git-send-email-skomatineni@nvidia.com> <1576613046-17159-14-git-send-email-skomatineni@nvidia.com> <7e49fef8-112c-1694-9316-7a23db8a01a4@gmail.com> <66a28f8a-82e8-5b12-464c-4c91441d1511@nvidia.com> From: Dmitry Osipenko Message-ID: Date: Wed, 18 Dec 2019 10:22:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <66a28f8a-82e8-5b12-464c-4c91441d1511@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 18.12.2019 10:14, Sowjanya Komatineni пишет: > > On 12/17/19 11:01 PM, Dmitry Osipenko wrote: >> 18.12.2019 09:59, Dmitry Osipenko пишет: >>> 17.12.2019 23:04, Sowjanya Komatineni пишет: >>>> mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks >>>> are moved to Tegra PMC driver with pmc as clock provider and using pmc >>>> clock ids. >>>> >>>> New device tree uses clk_out_1 from pmc clock provider. >>>> >>>> So, this patch adds implementation for mclk fallback to extern1 when >>>> retrieving mclk returns -ENOENT to be backward compatible of new device >>>> tree with older kernels. >>>> >>>> Signed-off-by: Sowjanya Komatineni >>>> --- >>>>   sound/soc/tegra/tegra_asoc_utils.c | 11 ++++++++++- >>>>   1 file changed, 10 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/sound/soc/tegra/tegra_asoc_utils.c >>>> b/sound/soc/tegra/tegra_asoc_utils.c >>>> index fe9ca8acd0fb..1b88c6043082 100644 >>>> --- a/sound/soc/tegra/tegra_asoc_utils.c >>>> +++ b/sound/soc/tegra/tegra_asoc_utils.c >>>> @@ -191,7 +191,16 @@ int tegra_asoc_utils_init(struct >>>> tegra_asoc_utils_data *data, >>>>       data->clk_cdev1 = devm_clk_get(dev, "mclk"); >>>>       if (IS_ERR(data->clk_cdev1)) { >>>>           dev_err(data->dev, "Can't retrieve clk cdev1\n"); >>>> -        return PTR_ERR(data->clk_cdev1); >>>> +        if (PTR_ERR(data->clk_cdev1) != -ENOENT) >>>> +            return PTR_ERR(data->clk_cdev1); >>>> +        /* Fall back to extern1 */ >>>> +        data->clk_cdev1 = devm_clk_get(dev, "extern1"); >>>> +        if (IS_ERR(data->clk_cdev1)) { >>>> +            dev_err(data->dev, "Can't retrieve clk extern1\n"); >>>> +            return PTR_ERR(data->clk_cdev1); >>>> +        } >>>> + >>>> +        dev_err(data->dev, "Falling back to extern1\n"); >>>>       } >>>>         /* >>>> >>> [    1.769091] ------------[ cut here ]------------ >>> [    1.769249] WARNING: CPU: 2 PID: 1 at drivers/clk/clk.c:954 >>> clk_core_disable+0xa5/0x1d4 >>> [    1.769330] clk_out_1 already disabled >>> [    1.769459] Modules linked in: >>> [    1.769541] CPU: 2 PID: 1 Comm: swapper/0 Not tainted >>> 5.5.0-rc1-next-20191213-00167-g6b9fbcdac8f3-dirty #266 >>> [    1.769676] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) >>> [    1.769775] [] (unwind_backtrace) from [] >>> (show_stack+0x11/0x14) >>> [    1.769918] [] (show_stack) from [] >>> (dump_stack+0x85/0x94) >>> [    1.770061] [] (dump_stack) from [] >>> (__warn+0xc1/0xc4) >>> [    1.770144] [] (__warn) from [] >>> (warn_slowpath_fmt+0x61/0x78) >>> [    1.770285] [] (warn_slowpath_fmt) from [] >>> (clk_core_disable+0xa5/0x1d4) >>> [    1.770427] [] (clk_core_disable) from [] >>> (clk_core_disable_lock+0x17/0x20) >>> [    1.770516] [] (clk_core_disable_lock) from [] >>> (tegra_asoc_utils_set_rate+0x53/0x208) >>> [    1.770662] [] (tegra_asoc_utils_set_rate) from >>> [] (tegra_rt5640_probe+0xd5/0x128) >>> [    1.770808] [] (tegra_rt5640_probe) from [] >>> (platform_drv_probe+0x33/0x68) >>> [    1.770958] [] (platform_drv_probe) from [] >>> (really_probe+0x14d/0x240) >>> [    1.771099] [] (really_probe) from [] >>> (driver_probe_device+0x43/0x11c) >>> [    1.771187] [] (driver_probe_device) from [] >>> (device_driver_attach+0x3d/0x40) >>> [    1.771328] [] (device_driver_attach) from [] >>> (__driver_attach+0x37/0x78) >>> [    1.771469] [] (__driver_attach) from [] >>> (bus_for_each_dev+0x43/0x6c) >>> [    1.771609] [] (bus_for_each_dev) from [] >>> (bus_add_driver+0xe3/0x148) >>> [    1.771692] [] (bus_add_driver) from [] >>> (driver_register+0x39/0xa0) >>> [    1.771833] [] (driver_register) from [] >>> (do_one_initcall+0x43/0x1bc) >>> [    1.771979] [] (do_one_initcall) from [] >>> (kernel_init_freeable+0x121/0x194) >>> [    1.772129] [] (kernel_init_freeable) from [] >>> (kernel_init+0xd/0xd0) >>> [    1.772215] [] (kernel_init) from [] >>> (ret_from_fork+0x11/0x34) >>> [    1.772349] Exception stack(0xde907fb0 to 0xde907ff8) >>> >> Although, that's probably related to the "ASoC: tegra: Add initial >> parent configuration for audio mclk". >> > Actually I see these warnings of already unprepared and already disabled > for pll_a, pll_a_out0, and clk_out_1 even without this whole patch > series as well. > > I think its from tegra_asoc_utils_set_rate() doing clk_disable_unprepare > and these clocks are already unprepared and disabled so its just warning > from clk_core_unprepare and clk_core_disable. Doesn't happen for me without this series.