From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: =?UTF-8?Q?Re:_[PATCH_v6_00/41]_ARM:_davinci:_convert_to_common_cloc?= =?UTF-8?Q?k_framework=e2=80=8b?= Date: Tue, 23 Jan 2018 14:23:10 -0600 Message-ID: References: <1516468460-4908-1-git-send-email-david@lechnology.com> <615bc302-e129-1501-63be-fa701f5ecaad@lechnology.com> <5f836454-5de7-c51d-d262-2c2dbc26e438@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bartosz Golaszewski Cc: Adam Ford , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , Bartosz Golaszewski , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On 01/23/2018 02:05 PM, David Lechner wrote: > On 01/23/2018 02:01 PM, David Lechner wrote: >> On 01/23/2018 01:53 PM, Bartosz Golaszewski wrote: >>> >>> In the mdio case - the problem is that devm_clk_get() doesn't fail, >>> but somehow the clock doesn't end up in the list of the device's >>> clocks - which is why it's not enabled by pm_runtime_get_sync(). >>> >> >> >> Right. This is because devm_clk_get() now finds the clock via device >> tree instead of a clkdev lookup entry. However, I think that the PM >> notifier registered in arch/arm/mach-davinci/pm_domain.c only uses >> the clkdev lookup to match the con_id and does not use device tree. >> The same thing is happing in mdio, emac and lcdc. >> > > Minor correction: It looks like emac doesn't do this because it doesn't > have a con_id of "fck". But, the same clock is shared by emac and mdio, so > since mdio enables the clock, emac doesn't notice or care that it did > not enable the clock itself. How about using pm_clk_add_clk() in these drivers to explicitly use the clocks for power management instead of relying on pm_clk_add_notifier() to do this implicitly? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html