From: Leonard Crestez <leonard.crestez@nxp.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"mka@chromium.org" <mka@chromium.org>,
"krzk@kernel.org" <krzk@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"angus@akkea.ca" <angus@akkea.ca>,
"martink@posteo.de" <martink@posteo.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
Jacky Bai <ping.bai@nxp.com>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"saravanak@google.com" <saravanak@google.com>,
Abel Vesa <abel.vesa@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Anson Huang <anson.huang@nxp.com>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"a.swigon@partner.samsung.com" <a.swigon@partner.samsung.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"abailon@baylibre.com" <abailon@baylibre.com>,
"georgi.djakov@linaro.org" <georgi.djakov@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 6/6] arm64: dts: imx8m: Add ddr controller nodes
Date: Mon, 11 Nov 2019 14:29:15 +0000 [thread overview]
Message-ID: <feb66325049ac098ef178abd1de14ddd1c840a13.camel@nxp.com> (raw)
In-Reply-To: <20191104220144.GA5218@bogus>
On Mon, 2019-11-04 at 16:01 -0600, Rob Herring wrote:
> On Thu, Oct 31, 2019 at 11:50:27PM +0200, Leonard Crestez wrote:
> > This is used by the imx-ddrc devfreq driver to implement dynamic
> > frequency scaling of DRAM.
> >
> > Add a devfreq-event link to the dram PMU in order to support on-
> > demand scaling of ddrc based on measured dram bandwidth usage.
> >
> > Support for proactive scaling via interconnect will come later. The
> > high-performance bus masters which need that (display, vpu, gpu)
> > are not yet enabled in upstream anyway.
> >
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 ++++++++++++++
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 17 ++++++++++++-
> > .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 ++++++++++++++
> > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 16 ++++++++++++-
> > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24
> > +++++++++++++++++++
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 16 ++++++++++++-
> > 6 files changed, 106 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index 4f5e408d6e6a..be9abd8e4478 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -69,16 +69,34 @@
> > simple-audio-card,codec {
> > sound-dai = <&wm8524>;
> > clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
> > };
> > };
> > +
> > + ddrc_opp_table: ddrc-opp-table {
> > + compatible = "operating-points-v2";
> > +
> > + opp-25M {
> > + opp-hz = /bits/ 64 <25000000>;
> > + };
> > + opp-100M {
> > + opp-hz = /bits/ 64 <100000000>;
> > + };
> > + opp-750M {
> > + opp-hz = /bits/ 64 <750000000>;
> > + };
> > + };
> > };
> >
> > &A53_0 {
> > cpu-supply = <&buck2_reg>;
> > };
> >
> > +&ddrc {
> > + operating-points-v2 = <&ddrc_opp_table>;
> > +};
> > +
> > &fec1 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_fec1>;
> > phy-mode = "rgmii-id";
> > phy-handle = <ðphy0>;
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 6edbdfe2d0d7..5404870d80d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -856,11 +856,26 @@
> > #interrupt-cells = <3>;
> > interrupt-controller;
> > interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > };
> >
> > - ddr-pmu@3d800000 {
> > + ddrc: dram-controller@3d400000 {
> > + compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-
> > ddrc";
> > + reg = <0x3d400000 0x400000>;
>
> Do you really need the OS to map 4MB of register space? Virtual
> space on 64-bit doesn't matter, but it's still wasting 2KB of memory
> just to map all that if only a few pages are needed. Adds up if the
> whole DT is done this way.
This driver doesn't actually map registers, they're only touched from
firmware.
Information is from memory map.
> > + clock-names = "dram_core",
> > + "dram_pll",
> > + "dram_alt",
> > + "dram_apb";
> > + clocks = <&clk IMX8MM_CLK_DRAM_CORE>,
> > + <&clk IMX8MM_DRAM_PLL>,
> > + <&clk IMX8MM_CLK_DRAM_ALT>,
> > + <&clk IMX8MM_CLK_DRAM_APB>;
> > + devfreq-events = <&ddr_pmu>;
> > + operating-points-v2 = <&ddrc_opp_table>;
> > + };
> > +
> > + ddr_pmu: ddr-pmu@3d800000 {
> > compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-
> > ddr-pmu";
> > reg = <0x3d800000 0x400000>;
> > interrupt-parent = <&gic>;
> > interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> > };
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > index 071949412caf..ab2060667671 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> > @@ -9,16 +9,34 @@
> > #include "imx8mn-evk.dtsi"
> >
> > / {
> > model = "NXP i.MX8MNano DDR4 EVK board";
> > compatible = "fsl,imx8mn-ddr4-evk", "fsl,imx8mn";
> > +
> > + ddrc_opp_table: ddrc-opp-table {
>
> I think it would be better to put this under the ddrc node (and
> named 'opp-table'). Yes, it's kind of silly to have a phandle to a
> child node, but that still works.
That looks much nicer, fixed in v4.
I had to also update yaml to explicitly allow an "opp-table" child.
--
Regards,
Leonard
prev parent reply other threads:[~2019-11-11 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:50 [PATCH v3 0/6] PM / devfreq: Add dynamic scaling for imx ddr controller Leonard Crestez
2019-10-31 21:50 ` [PATCH v3 1/6] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks Leonard Crestez
2019-12-02 3:12 ` Shawn Guo
2019-12-02 4:19 ` Leonard Crestez
2019-10-31 21:50 ` [PATCH v3 2/6] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE Leonard Crestez
2019-10-31 21:50 ` [PATCH v3 3/6] dt-bindings: devfreq: Add bindings for imx ddr controller Leonard Crestez
2019-11-04 22:21 ` Rob Herring
2019-11-05 19:25 ` Leonard Crestez
2019-11-05 20:13 ` Rob Herring
2019-10-31 21:50 ` [PATCH v3 4/6] PM / devfreq: Add dynamic scaling " Leonard Crestez
2019-12-02 5:38 ` Shawn Guo
2019-12-02 9:12 ` Leonard Crestez
2019-12-02 13:34 ` Shawn Guo
2019-10-31 21:50 ` [PATCH v3 5/6] PM / devfreq: imx-ddrc: Measure bandwidth with perf Leonard Crestez
2019-10-31 21:50 ` [PATCH v3 6/6] arm64: dts: imx8m: Add ddr controller nodes Leonard Crestez
2019-11-04 22:01 ` Rob Herring
2019-11-11 14:29 ` Leonard Crestez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb66325049ac098ef178abd1de14ddd1c840a13.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=a.swigon@partner.samsung.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=angus@akkea.ca \
--cc=anson.huang@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martink@posteo.de \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).